Skip to content
Snippets Groups Projects
  • jugglinmike's avatar
    ab4ff914
    Add tests for assignment target validation of new ES2015 forms (#693) · ab4ff914
    jugglinmike authored
    This re-factors some existing Sputnik tests to be more targeted and to use a
    pattern that can be generalized to other forms. We could test these all day,
    but I've limited myself to forms introduced in ES2015, specifically
    YieldExpression and new.target. Note that SpiderMonkey incorrectly throws a
    SyntaxError for these.
    I thoughtlessly wrote ReferenceError tests for yield = 1 until I realized
    that such productions are not actually recognized by the grammar, so the early
    errors do not apply. Instead, I've added a negative syntax test for that case.
    
    * Refactor test for valid cover
    
    * Add tests for ValidSimpleAssignmentTarget
    
    Ensure that constructs introduced in ES2015 are disallowed as assignment
    targets, with or without a "cover" grammar.
    
    * Add test for grammar precedence of YieldExpression
    ab4ff914
    History
    Add tests for assignment target validation of new ES2015 forms (#693)
    jugglinmike authored
    This re-factors some existing Sputnik tests to be more targeted and to use a
    pattern that can be generalized to other forms. We could test these all day,
    but I've limited myself to forms introduced in ES2015, specifically
    YieldExpression and new.target. Note that SpiderMonkey incorrectly throws a
    SyntaxError for these.
    I thoughtlessly wrote ReferenceError tests for yield = 1 until I realized
    that such productions are not actually recognized by the grammar, so the early
    errors do not apply. Instead, I've added a negative syntax test for that case.
    
    * Refactor test for valid cover
    
    * Add tests for ValidSimpleAssignmentTarget
    
    Ensure that constructs introduced in ES2015 are disallowed as assignment
    targets, with or without a "cover" grammar.
    
    * Add test for grammar precedence of YieldExpression