From 2878106ca0f0abf061d9676607931b3886d7d05d Mon Sep 17 00:00:00 2001 From: Daniel Ehrenberg <microdan@gmail.com> Date: Thu, 6 Apr 2017 18:05:43 +0200 Subject: [PATCH] Fix offset for detached TypedArray test (#946) Bug was reported by @anba at https://github.com/tc39/ecma262/pull/852#issuecomment-291781031 Without this change, you'd expect a RangeError rather than a TypeError. --- .../TypedArrays/buffer-arg-byteoffset-to-number-detachbuffer.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/built-ins/TypedArrays/buffer-arg-byteoffset-to-number-detachbuffer.js b/test/built-ins/TypedArrays/buffer-arg-byteoffset-to-number-detachbuffer.js index c290dcdc11..9357cd0e35 100644 --- a/test/built-ins/TypedArrays/buffer-arg-byteoffset-to-number-detachbuffer.js +++ b/test/built-ins/TypedArrays/buffer-arg-byteoffset-to-number-detachbuffer.js @@ -15,6 +15,6 @@ includes: [testTypedArray.js, detachArrayBuffer.js] testWithTypedArrayConstructors(function(TA) { var offset = TA.BYTES_PER_ELEMENT; var buffer = new ArrayBuffer(3 * offset); - var byteOffset = { valueOf() { $DETACHBUFFER(buffer); return 1; } }; + var byteOffset = { valueOf() { $DETACHBUFFER(buffer); return offset; } }; assert.throws(TypeError, () => new TA(buffer, byteOffset)); }); -- GitLab