From 3a3ced170e394b6c9283a51d0efcf335c9b2dd70 Mon Sep 17 00:00:00 2001 From: Mike Pennisi <mike@mikepennisi.com> Date: Tue, 22 Mar 2016 09:51:05 -0400 Subject: [PATCH] Correct example in contribution guidelines As written, the example for asserting runtime errors is written with an early error. Because the error is expected to be reported prior to program execution, the `assert.throws` function cannot be used to detect it. Demonstrate the usage of the helper function with a runtime error. --- CONTRIBUTING.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 655cf10072..c368f65b40 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -193,8 +193,8 @@ var var = var; Expectations for **runtime errors** should be defined using the `assert.throws` method and the appropriate JavaScript Error constructor function: ```javascript -assert.throws(ReferenceError, function() { - 1 += 1; // expect this to throw ReferenceError +assert.throws(TypeError, function() { + null(); // expect this statement to throw a TypeError }); ``` -- GitLab