From 3ac4b240bbfecdcc5cfa9deafad20043bc8301a6 Mon Sep 17 00:00:00 2001
From: Rick Waldron <waldron.rick@gmail.com>
Date: Thu, 19 Mar 2015 14:54:24 -0400
Subject: [PATCH] computed-property-names: follow up corrections. Fixes gh-198
---
...nnot-be-generator.js => constructor-can-be-generator.js} | 6 ++----
...tor-cannot-be-getter.js => constructor-can-be-getter.js} | 1 -
...tor-cannot-be-setter.js => constructor-can-be-setter.js} | 1 -
...tructor-no-duplicate-1.js => constructor-duplicate-1.js} | 0
...tructor-no-duplicate-2.js => constructor-duplicate-2.js} | 0
...tructor-no-duplicate-3.js => constructor-duplicate-3.js} | 0
6 files changed, 2 insertions(+), 6 deletions(-)
rename test/language/computed-property-names/class/method/{constructor-cannot-be-generator.js => constructor-can-be-generator.js} (63%)
rename test/language/computed-property-names/class/method/{constructor-cannot-be-getter.js => constructor-can-be-getter.js} (92%)
rename test/language/computed-property-names/class/method/{constructor-cannot-be-setter.js => constructor-can-be-setter.js} (93%)
rename test/language/computed-property-names/class/method/{constructor-no-duplicate-1.js => constructor-duplicate-1.js} (100%)
rename test/language/computed-property-names/class/method/{constructor-no-duplicate-2.js => constructor-duplicate-2.js} (100%)
rename test/language/computed-property-names/class/method/{constructor-no-duplicate-3.js => constructor-duplicate-3.js} (100%)
diff --git a/test/language/computed-property-names/class/method/constructor-cannot-be-generator.js b/test/language/computed-property-names/class/method/constructor-can-be-generator.js
similarity index 63%
rename from test/language/computed-property-names/class/method/constructor-cannot-be-generator.js
rename to test/language/computed-property-names/class/method/constructor-can-be-generator.js
index 83a8f4ed04..e2bcdfe4c4 100644
--- a/test/language/computed-property-names/class/method/constructor-cannot-be-generator.js
+++ b/test/language/computed-property-names/class/method/constructor-can-be-generator.js
@@ -3,10 +3,8 @@
/*---
es6id: 14.5.3
description: >
- computed property generator method names cannot be "constructor"
-negative: SyntaxError
+ computed property generator method names can be called "constructor"
---*/
class C4 {
- *['constructor']() {
- }
+ *['constructor']() {}
}
diff --git a/test/language/computed-property-names/class/method/constructor-cannot-be-getter.js b/test/language/computed-property-names/class/method/constructor-can-be-getter.js
similarity index 92%
rename from test/language/computed-property-names/class/method/constructor-cannot-be-getter.js
rename to test/language/computed-property-names/class/method/constructor-can-be-getter.js
index 318b58b824..8bdb071e72 100644
--- a/test/language/computed-property-names/class/method/constructor-cannot-be-getter.js
+++ b/test/language/computed-property-names/class/method/constructor-can-be-getter.js
@@ -4,7 +4,6 @@
es6id: 14.5.3
description: >
computed property getter names can be called "constructor"
-negative: SyntaxError
---*/
class C4 {
get ['constructor']() {}
diff --git a/test/language/computed-property-names/class/method/constructor-cannot-be-setter.js b/test/language/computed-property-names/class/method/constructor-can-be-setter.js
similarity index 93%
rename from test/language/computed-property-names/class/method/constructor-cannot-be-setter.js
rename to test/language/computed-property-names/class/method/constructor-can-be-setter.js
index 0ae0295e64..e273f87acb 100644
--- a/test/language/computed-property-names/class/method/constructor-cannot-be-setter.js
+++ b/test/language/computed-property-names/class/method/constructor-can-be-setter.js
@@ -4,7 +4,6 @@
es6id: 14.5.3
description: >
computed property setter names can be called "constructor"
-negative: SyntaxError
---*/
class C4 {
set ['constructor'](_) {}
diff --git a/test/language/computed-property-names/class/method/constructor-no-duplicate-1.js b/test/language/computed-property-names/class/method/constructor-duplicate-1.js
similarity index 100%
rename from test/language/computed-property-names/class/method/constructor-no-duplicate-1.js
rename to test/language/computed-property-names/class/method/constructor-duplicate-1.js
diff --git a/test/language/computed-property-names/class/method/constructor-no-duplicate-2.js b/test/language/computed-property-names/class/method/constructor-duplicate-2.js
similarity index 100%
rename from test/language/computed-property-names/class/method/constructor-no-duplicate-2.js
rename to test/language/computed-property-names/class/method/constructor-duplicate-2.js
diff --git a/test/language/computed-property-names/class/method/constructor-no-duplicate-3.js b/test/language/computed-property-names/class/method/constructor-duplicate-3.js
similarity index 100%
rename from test/language/computed-property-names/class/method/constructor-no-duplicate-3.js
rename to test/language/computed-property-names/class/method/constructor-duplicate-3.js
--
GitLab