From 3f96092cb90ab5eacb6308a83f5b60c4eb1a19b6 Mon Sep 17 00:00:00 2001
From: Valerie R Young <valerie@bocoup.com>
Date: Tue, 13 Mar 2018 15:06:12 -0400
Subject: [PATCH] BigInt: fix, set only BigInts to index to avoid false
 negatives

---
 .../DefineOwnProperty/BigInt/detached-buffer-realm.js  |  2 +-
 .../DefineOwnProperty/BigInt/detached-buffer.js        |  2 +-
 .../BigInt/key-is-greater-than-last-index.js           |  4 ++--
 .../DefineOwnProperty/BigInt/key-is-lower-than-zero.js |  2 +-
 .../DefineOwnProperty/BigInt/key-is-minus-zero.js      |  2 +-
 .../DefineOwnProperty/BigInt/key-is-not-integer.js     | 10 +++++-----
 .../BigInt/key-is-numericindex-desc-configurable.js    |  2 +-
 .../BigInt/key-is-numericindex-desc-not-enumerable.js  |  2 +-
 .../BigInt/key-is-numericindex-desc-not-writable.js    |  2 +-
 .../internals/Set/BigInt/detached-buffer-realm.js      |  2 +-
 10 files changed, 15 insertions(+), 15 deletions(-)

diff --git a/test/built-ins/TypedArrayConstructors/internals/DefineOwnProperty/BigInt/detached-buffer-realm.js b/test/built-ins/TypedArrayConstructors/internals/DefineOwnProperty/BigInt/detached-buffer-realm.js
index 3fa462103a..52d2ad0950 100644
--- a/test/built-ins/TypedArrayConstructors/internals/DefineOwnProperty/BigInt/detached-buffer-realm.js
+++ b/test/built-ins/TypedArrayConstructors/internals/DefineOwnProperty/BigInt/detached-buffer-realm.js
@@ -29,7 +29,7 @@ features: [BigInt, cross-realm, Reflect, TypedArray]
 
 var other = $262.createRealm().global;
 var desc = {
-  value: 0,
+  value: 0n,
   configurable: false,
   enumerable: true,
   writable: true
diff --git a/test/built-ins/TypedArrayConstructors/internals/DefineOwnProperty/BigInt/detached-buffer.js b/test/built-ins/TypedArrayConstructors/internals/DefineOwnProperty/BigInt/detached-buffer.js
index f201761566..17417b995d 100644
--- a/test/built-ins/TypedArrayConstructors/internals/DefineOwnProperty/BigInt/detached-buffer.js
+++ b/test/built-ins/TypedArrayConstructors/internals/DefineOwnProperty/BigInt/detached-buffer.js
@@ -27,7 +27,7 @@ features: [BigInt, Reflect, TypedArray]
 ---*/
 
 var desc = {
-  value: 0,
+  value: 0n,
   configurable: false,
   enumerable: true,
   writable: true
diff --git a/test/built-ins/TypedArrayConstructors/internals/DefineOwnProperty/BigInt/key-is-greater-than-last-index.js b/test/built-ins/TypedArrayConstructors/internals/DefineOwnProperty/BigInt/key-is-greater-than-last-index.js
index c558041e15..3177065146 100644
--- a/test/built-ins/TypedArrayConstructors/internals/DefineOwnProperty/BigInt/key-is-greater-than-last-index.js
+++ b/test/built-ins/TypedArrayConstructors/internals/DefineOwnProperty/BigInt/key-is-greater-than-last-index.js
@@ -25,7 +25,7 @@ testWithBigIntTypedArrayConstructors(function(TA) {
 
   assert.sameValue(
     Reflect.defineProperty(sample, "2", {
-      value: 42,
+      value: 42n,
       configurable: false,
       enumerable: true,
       writable: true
@@ -36,7 +36,7 @@ testWithBigIntTypedArrayConstructors(function(TA) {
 
   assert.sameValue(
     Reflect.defineProperty(sample, "3", {
-      value: 42,
+      value: 42n,
       configurable: false,
       enumerable: true,
       writable: true
diff --git a/test/built-ins/TypedArrayConstructors/internals/DefineOwnProperty/BigInt/key-is-lower-than-zero.js b/test/built-ins/TypedArrayConstructors/internals/DefineOwnProperty/BigInt/key-is-lower-than-zero.js
index c9ff538985..b2afcf4853 100644
--- a/test/built-ins/TypedArrayConstructors/internals/DefineOwnProperty/BigInt/key-is-lower-than-zero.js
+++ b/test/built-ins/TypedArrayConstructors/internals/DefineOwnProperty/BigInt/key-is-lower-than-zero.js
@@ -23,7 +23,7 @@ testWithBigIntTypedArrayConstructors(function(TA) {
 
   assert.sameValue(
     Reflect.defineProperty(sample, "-1", {
-      value: 42,
+      value: 42n,
       configurable: false,
       enumerable: true,
       writable: true
diff --git a/test/built-ins/TypedArrayConstructors/internals/DefineOwnProperty/BigInt/key-is-minus-zero.js b/test/built-ins/TypedArrayConstructors/internals/DefineOwnProperty/BigInt/key-is-minus-zero.js
index 73dcde780b..a45c75dbe4 100644
--- a/test/built-ins/TypedArrayConstructors/internals/DefineOwnProperty/BigInt/key-is-minus-zero.js
+++ b/test/built-ins/TypedArrayConstructors/internals/DefineOwnProperty/BigInt/key-is-minus-zero.js
@@ -23,7 +23,7 @@ testWithBigIntTypedArrayConstructors(function(TA) {
 
   assert.sameValue(
     Reflect.defineProperty(sample, "-0", {
-      value: 42,
+      value: 42n,
       configurable: false,
       enumerable: true,
       writable: true
diff --git a/test/built-ins/TypedArrayConstructors/internals/DefineOwnProperty/BigInt/key-is-not-integer.js b/test/built-ins/TypedArrayConstructors/internals/DefineOwnProperty/BigInt/key-is-not-integer.js
index 15bc69fb42..e4a90f0ec5 100644
--- a/test/built-ins/TypedArrayConstructors/internals/DefineOwnProperty/BigInt/key-is-not-integer.js
+++ b/test/built-ins/TypedArrayConstructors/internals/DefineOwnProperty/BigInt/key-is-not-integer.js
@@ -21,7 +21,7 @@ testWithBigIntTypedArrayConstructors(function(TA) {
 
   assert.sameValue(
     Reflect.defineProperty(sample, "0.1", {
-      value: 42,
+      value: 42n,
       configurable: false,
       enumerable: true,
       writable: true
@@ -38,7 +38,7 @@ testWithBigIntTypedArrayConstructors(function(TA) {
 
   assert.sameValue(
     Reflect.defineProperty(sample, "0.000001", {
-      value: 42,
+      value: 42n,
       configurable: false,
       enumerable: true,
       writable: true
@@ -58,7 +58,7 @@ testWithBigIntTypedArrayConstructors(function(TA) {
 
   assert.sameValue(
     Reflect.defineProperty(sample, "1.1", {
-      value: 42,
+      value: 42n,
       configurable: false,
       enumerable: true,
       writable: true
@@ -75,7 +75,7 @@ testWithBigIntTypedArrayConstructors(function(TA) {
 
   assert.sameValue(
     Reflect.defineProperty(sample, "Infinity", {
-      value: 42,
+      value: 42n,
       configurable: false,
       enumerable: true,
       writable: true
@@ -99,7 +99,7 @@ testWithBigIntTypedArrayConstructors(function(TA) {
 
   assert.sameValue(
     Reflect.defineProperty(sample, "-Infinity", {
-      value: 42,
+      value: 42n,
       configurable: false,
       enumerable: true,
       writable: true
diff --git a/test/built-ins/TypedArrayConstructors/internals/DefineOwnProperty/BigInt/key-is-numericindex-desc-configurable.js b/test/built-ins/TypedArrayConstructors/internals/DefineOwnProperty/BigInt/key-is-numericindex-desc-configurable.js
index 51fd77203b..59b5abd434 100644
--- a/test/built-ins/TypedArrayConstructors/internals/DefineOwnProperty/BigInt/key-is-numericindex-desc-configurable.js
+++ b/test/built-ins/TypedArrayConstructors/internals/DefineOwnProperty/BigInt/key-is-numericindex-desc-configurable.js
@@ -23,7 +23,7 @@ testWithBigIntTypedArrayConstructors(function(TA) {
 
   assert.sameValue(
     Reflect.defineProperty(sample, "0", {
-      value: 42,
+      value: 42n,
       configurable: true,
       enumerable: true,
       writable: true
diff --git a/test/built-ins/TypedArrayConstructors/internals/DefineOwnProperty/BigInt/key-is-numericindex-desc-not-enumerable.js b/test/built-ins/TypedArrayConstructors/internals/DefineOwnProperty/BigInt/key-is-numericindex-desc-not-enumerable.js
index 37315f7c98..4b46693b01 100644
--- a/test/built-ins/TypedArrayConstructors/internals/DefineOwnProperty/BigInt/key-is-numericindex-desc-not-enumerable.js
+++ b/test/built-ins/TypedArrayConstructors/internals/DefineOwnProperty/BigInt/key-is-numericindex-desc-not-enumerable.js
@@ -23,7 +23,7 @@ testWithBigIntTypedArrayConstructors(function(TA) {
 
   assert.sameValue(
     Reflect.defineProperty(sample, "0", {
-      value: 42,
+      value: 42n,
       configurable: false,
       enumerable: false,
       writable: true
diff --git a/test/built-ins/TypedArrayConstructors/internals/DefineOwnProperty/BigInt/key-is-numericindex-desc-not-writable.js b/test/built-ins/TypedArrayConstructors/internals/DefineOwnProperty/BigInt/key-is-numericindex-desc-not-writable.js
index 26f4363fec..8e7bdf4d56 100644
--- a/test/built-ins/TypedArrayConstructors/internals/DefineOwnProperty/BigInt/key-is-numericindex-desc-not-writable.js
+++ b/test/built-ins/TypedArrayConstructors/internals/DefineOwnProperty/BigInt/key-is-numericindex-desc-not-writable.js
@@ -23,7 +23,7 @@ testWithBigIntTypedArrayConstructors(function(TA) {
 
   assert.sameValue(
     Reflect.defineProperty(sample, "0", {
-      value: 42,
+      value: 42n,
       configurable: false,
       enumerable: true,
       writable: false
diff --git a/test/built-ins/TypedArrayConstructors/internals/Set/BigInt/detached-buffer-realm.js b/test/built-ins/TypedArrayConstructors/internals/Set/BigInt/detached-buffer-realm.js
index f7e71ff0eb..f5e15d83eb 100644
--- a/test/built-ins/TypedArrayConstructors/internals/Set/BigInt/detached-buffer-realm.js
+++ b/test/built-ins/TypedArrayConstructors/internals/Set/BigInt/detached-buffer-realm.js
@@ -35,6 +35,6 @@ testWithBigIntTypedArrayConstructors(function(TA) {
   $DETACHBUFFER(sample.buffer);
 
   assert.throws(TypeError, function() {
-    sample[0] = 0;
+    sample[0] = 0n;
   });
 });
-- 
GitLab