From 6030e4ed712804eebd8491151d708677c0d6cccd Mon Sep 17 00:00:00 2001 From: Leo Balter <leonardo.balter@gmail.com> Date: Fri, 7 Apr 2017 11:34:55 -0400 Subject: [PATCH] Update object literal expressions for readability MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit After @rwaldron's feedback: The purpose of the `!` operator is to evaluate an UnaryExpression, coerce the result to a boolean value and then return the negated value of that operation. But that's not what you're trying to do at all—you just want to evaluate the expression to the right of the operator, nothing more, nothing less. In this specific case, you don't even really care about the evaluation, the goal is write valid (or invalid, as the case may be) syntax that is will be parsed according to a specific grammar rule that requires some operator to signal that the thing is an expression and not a Block Statement. --- ...rly-errors-object-method-arguments-in-formal-parameters.js | 4 ++-- .../early-errors-object-method-async-lineterminator.js | 4 ++-- .../early-errors-object-method-await-in-formals-default.js | 4 ++-- .../early-errors-object-method-await-in-formals.js | 4 ++-- .../early-errors-object-method-body-contains-super-call.js | 4 ++-- .../early-errors-object-method-duplicate-parameters.js | 4 ++-- .../early-errors-object-method-eval-in-formal-parameters.js | 4 ++-- .../early-errors-object-method-formals-body-duplicate.js | 4 ++-- .../early-errors-object-method-formals-contains-super-call.js | 4 ++-- 9 files changed, 18 insertions(+), 18 deletions(-) diff --git a/test/language/expressions/object/method-definition/early-errors-object-method-arguments-in-formal-parameters.js b/test/language/expressions/object/method-definition/early-errors-object-method-arguments-in-formal-parameters.js index 4d67144a28..a7266b66b4 100644 --- a/test/language/expressions/object/method-definition/early-errors-object-method-arguments-in-formal-parameters.js +++ b/test/language/expressions/object/method-definition/early-errors-object-method-arguments-in-formal-parameters.js @@ -10,6 +10,6 @@ negative: type: SyntaxError flags: [onlyStrict] ---*/ -!{ +({ async foo (arguments) { } -} +}) diff --git a/test/language/expressions/object/method-definition/early-errors-object-method-async-lineterminator.js b/test/language/expressions/object/method-definition/early-errors-object-method-async-lineterminator.js index 1a87c5d857..35d23cf6fc 100644 --- a/test/language/expressions/object/method-definition/early-errors-object-method-async-lineterminator.js +++ b/test/language/expressions/object/method-definition/early-errors-object-method-async-lineterminator.js @@ -14,7 +14,7 @@ negative: type: SyntaxError ---*/ -!{ +({ async foo() { } -} +}) diff --git a/test/language/expressions/object/method-definition/early-errors-object-method-await-in-formals-default.js b/test/language/expressions/object/method-definition/early-errors-object-method-await-in-formals-default.js index 8b6dc5ebff..256aeb536b 100644 --- a/test/language/expressions/object/method-definition/early-errors-object-method-await-in-formals-default.js +++ b/test/language/expressions/object/method-definition/early-errors-object-method-await-in-formals-default.js @@ -9,7 +9,7 @@ negative: phase: early type: SyntaxError ---*/ -!{ +({ async foo (x = await) { } -} +}) diff --git a/test/language/expressions/object/method-definition/early-errors-object-method-await-in-formals.js b/test/language/expressions/object/method-definition/early-errors-object-method-await-in-formals.js index c606a9a449..566c98f698 100644 --- a/test/language/expressions/object/method-definition/early-errors-object-method-await-in-formals.js +++ b/test/language/expressions/object/method-definition/early-errors-object-method-await-in-formals.js @@ -9,6 +9,6 @@ negative: phase: early type: SyntaxError ---*/ -!{ +({ async foo (await) { } -} +}) diff --git a/test/language/expressions/object/method-definition/early-errors-object-method-body-contains-super-call.js b/test/language/expressions/object/method-definition/early-errors-object-method-body-contains-super-call.js index 8f8852146c..9a226b5669 100644 --- a/test/language/expressions/object/method-definition/early-errors-object-method-body-contains-super-call.js +++ b/test/language/expressions/object/method-definition/early-errors-object-method-body-contains-super-call.js @@ -9,6 +9,6 @@ negative: phase: early type: SyntaxError ---*/ -!{ +({ async foo () { super() } -} +}) diff --git a/test/language/expressions/object/method-definition/early-errors-object-method-duplicate-parameters.js b/test/language/expressions/object/method-definition/early-errors-object-method-duplicate-parameters.js index aee8ea55e8..0f135f6294 100644 --- a/test/language/expressions/object/method-definition/early-errors-object-method-duplicate-parameters.js +++ b/test/language/expressions/object/method-definition/early-errors-object-method-duplicate-parameters.js @@ -10,6 +10,6 @@ negative: phase: early type: SyntaxError ---*/ -!{ +({ async foo(a, a) { } -} +}) diff --git a/test/language/expressions/object/method-definition/early-errors-object-method-eval-in-formal-parameters.js b/test/language/expressions/object/method-definition/early-errors-object-method-eval-in-formal-parameters.js index b80ee27ac1..b1a0da9fa5 100644 --- a/test/language/expressions/object/method-definition/early-errors-object-method-eval-in-formal-parameters.js +++ b/test/language/expressions/object/method-definition/early-errors-object-method-eval-in-formal-parameters.js @@ -10,6 +10,6 @@ negative: type: SyntaxError flags: [onlyStrict] ---*/ -!{ +({ async foo(eval) { } -} +}) diff --git a/test/language/expressions/object/method-definition/early-errors-object-method-formals-body-duplicate.js b/test/language/expressions/object/method-definition/early-errors-object-method-formals-body-duplicate.js index 62bc0144e4..a356280bde 100644 --- a/test/language/expressions/object/method-definition/early-errors-object-method-formals-body-duplicate.js +++ b/test/language/expressions/object/method-definition/early-errors-object-method-formals-body-duplicate.js @@ -10,6 +10,6 @@ negative: type: SyntaxError ---*/ -!{ +({ async function foo(bar) { let bar; } -} +}) diff --git a/test/language/expressions/object/method-definition/early-errors-object-method-formals-contains-super-call.js b/test/language/expressions/object/method-definition/early-errors-object-method-formals-contains-super-call.js index b3b50267ad..afc07f5347 100644 --- a/test/language/expressions/object/method-definition/early-errors-object-method-formals-contains-super-call.js +++ b/test/language/expressions/object/method-definition/early-errors-object-method-formals-contains-super-call.js @@ -9,6 +9,6 @@ negative: phase: early type: SyntaxError ---*/ -!{ +({ async foo(foo = super()) { } -} +}) -- GitLab