From 628faa5e06604c8355255e34cd8c129dec70301b Mon Sep 17 00:00:00 2001 From: Rick Waldron <waldron.rick@gmail.com> Date: Fri, 30 Nov 2018 09:31:54 -0500 Subject: [PATCH] Eliminate false positives: Object.fromEntries --- .../Object/fromEntries/iterator-closed-for-null-entry.js | 1 + .../Object/fromEntries/iterator-closed-for-string-entry.js | 1 + .../iterator-not-closed-for-next-returning-non-object.js | 1 + .../fromEntries/iterator-not-closed-for-uncallable-next.js | 1 + test/built-ins/Object/fromEntries/requires-argument.js | 1 + .../Object/fromEntries/string-entry-primitive-throws.js | 1 + 6 files changed, 6 insertions(+) diff --git a/test/built-ins/Object/fromEntries/iterator-closed-for-null-entry.js b/test/built-ins/Object/fromEntries/iterator-closed-for-null-entry.js index 6907a65cad..ec4bd3fefd 100644 --- a/test/built-ins/Object/fromEntries/iterator-closed-for-null-entry.js +++ b/test/built-ins/Object/fromEntries/iterator-closed-for-null-entry.js @@ -49,6 +49,7 @@ var iterable = { }, }; +assert.sameValue(typeof Object.fromEntries, 'function'); assert.throws(TypeError, function() { Object.fromEntries(iterable); }); diff --git a/test/built-ins/Object/fromEntries/iterator-closed-for-string-entry.js b/test/built-ins/Object/fromEntries/iterator-closed-for-string-entry.js index 81a27e0731..1910005bd7 100644 --- a/test/built-ins/Object/fromEntries/iterator-closed-for-string-entry.js +++ b/test/built-ins/Object/fromEntries/iterator-closed-for-string-entry.js @@ -49,6 +49,7 @@ var iterable = { }, }; +assert.sameValue(typeof Object.fromEntries, 'function'); assert.throws(TypeError, function() { Object.fromEntries(iterable); }); diff --git a/test/built-ins/Object/fromEntries/iterator-not-closed-for-next-returning-non-object.js b/test/built-ins/Object/fromEntries/iterator-not-closed-for-next-returning-non-object.js index fba4fbe67e..0af8935bf1 100644 --- a/test/built-ins/Object/fromEntries/iterator-not-closed-for-next-returning-non-object.js +++ b/test/built-ins/Object/fromEntries/iterator-not-closed-for-next-returning-non-object.js @@ -45,6 +45,7 @@ var iterable = { }, }; +assert.sameValue(typeof Object.fromEntries, 'function'); assert.throws(TypeError, function() { Object.fromEntries(iterable); }); diff --git a/test/built-ins/Object/fromEntries/iterator-not-closed-for-uncallable-next.js b/test/built-ins/Object/fromEntries/iterator-not-closed-for-uncallable-next.js index 74ad7a739c..aca63b824d 100644 --- a/test/built-ins/Object/fromEntries/iterator-not-closed-for-uncallable-next.js +++ b/test/built-ins/Object/fromEntries/iterator-not-closed-for-uncallable-next.js @@ -36,6 +36,7 @@ var iterable = { }, }; +assert.sameValue(typeof Object.fromEntries, 'function'); assert.throws(TypeError, function() { Object.fromEntries(iterable); }); diff --git a/test/built-ins/Object/fromEntries/requires-argument.js b/test/built-ins/Object/fromEntries/requires-argument.js index 19b91a5307..850a6bc4ea 100644 --- a/test/built-ins/Object/fromEntries/requires-argument.js +++ b/test/built-ins/Object/fromEntries/requires-argument.js @@ -14,6 +14,7 @@ info: | features: [Object.fromEntries] ---*/ +assert.sameValue(typeof Object.fromEntries, 'function'); assert.throws(TypeError, function() { Object.fromEntries(); }); diff --git a/test/built-ins/Object/fromEntries/string-entry-primitive-throws.js b/test/built-ins/Object/fromEntries/string-entry-primitive-throws.js index 2a678e3d8a..09dcf75894 100644 --- a/test/built-ins/Object/fromEntries/string-entry-primitive-throws.js +++ b/test/built-ins/Object/fromEntries/string-entry-primitive-throws.js @@ -7,6 +7,7 @@ esid: sec-object.fromentries features: [Object.fromEntries] ---*/ +assert.sameValue(typeof Object.fromEntries, 'function'); assert.throws(TypeError, function() { Object.fromEntries(['ab']); }); -- GitLab