From 7445d77d6d6b81dd92bc0f9a9f0e25a12b511e0e Mon Sep 17 00:00:00 2001
From: Leonardo Balter <leonardo.balter@gmail.com>
Date: Tue, 23 Feb 2016 13:50:13 -0500
Subject: [PATCH] Update descriptor tests for %TypedArray%.prototype properties
---
.../TypedArray/prototype/buffer/prop-desc.js | 12 +++++++++---
.../prototype/byteLength/prop-desc.js | 12 +++++++++---
.../prototype/byteOffset/prop-desc.js | 12 +++++++++---
.../TypedArray/prototype/length/prop-desc.js | 12 +++++++++---
.../prototype/toString/prop-desc.js | 19 +++++++++++++++++++
5 files changed, 55 insertions(+), 12 deletions(-)
create mode 100644 test/built-ins/TypedArray/prototype/toString/prop-desc.js
diff --git a/test/built-ins/TypedArray/prototype/buffer/prop-desc.js b/test/built-ins/TypedArray/prototype/buffer/prop-desc.js
index a413419495..f026c0668e 100644
--- a/test/built-ins/TypedArray/prototype/buffer/prop-desc.js
+++ b/test/built-ins/TypedArray/prototype/buffer/prop-desc.js
@@ -7,11 +7,17 @@ description: >
info: >
%TypedArray%.prototype.buffer is an accessor property whose set accessor
function is undefined.
-includes: [testTypedArray.js]
+
+ Section 17: Every accessor property described in clauses 18 through 26 and in
+ Annex B.2 has the attributes {[[Enumerable]]: false, [[Configurable]]: true }
+includes: [propertyHelper.js, testTypedArray.js]
---*/
var TypedArrayPrototype = TypedArray.prototype;
-var desc = Object.getOwnPropertyDescriptor(TypedArrayPrototype, 'buffer');
+var desc = Object.getOwnPropertyDescriptor(TypedArrayPrototype, "buffer");
assert.sameValue(desc.set, undefined);
-assert.sameValue(typeof desc.get, 'function');
+assert.sameValue(typeof desc.get, "function");
+
+verifyNotEnumerable(TypedArrayPrototype, "buffer");
+verifyConfigurable(TypedArrayPrototype, "buffer");
diff --git a/test/built-ins/TypedArray/prototype/byteLength/prop-desc.js b/test/built-ins/TypedArray/prototype/byteLength/prop-desc.js
index 8ceec38253..3f227ee448 100644
--- a/test/built-ins/TypedArray/prototype/byteLength/prop-desc.js
+++ b/test/built-ins/TypedArray/prototype/byteLength/prop-desc.js
@@ -7,11 +7,17 @@ description: >
info: >
%TypedArray%.prototype.byteLength is an accessor property whose set accessor
function is undefined.
-includes: [testTypedArray.js]
+
+ Section 17: Every accessor property described in clauses 18 through 26 and in
+ Annex B.2 has the attributes {[[Enumerable]]: false, [[Configurable]]: true }
+includes: [propertyHelper.js, testTypedArray.js]
---*/
var TypedArrayPrototype = TypedArray.prototype;
-var desc = Object.getOwnPropertyDescriptor(TypedArrayPrototype, 'byteLength');
+var desc = Object.getOwnPropertyDescriptor(TypedArrayPrototype, "byteLength");
assert.sameValue(desc.set, undefined);
-assert.sameValue(typeof desc.get, 'function');
+assert.sameValue(typeof desc.get, "function");
+
+verifyNotEnumerable(TypedArrayPrototype, "byteLength");
+verifyConfigurable(TypedArrayPrototype, "byteLength");
diff --git a/test/built-ins/TypedArray/prototype/byteOffset/prop-desc.js b/test/built-ins/TypedArray/prototype/byteOffset/prop-desc.js
index 7b180db704..f03c4963d6 100644
--- a/test/built-ins/TypedArray/prototype/byteOffset/prop-desc.js
+++ b/test/built-ins/TypedArray/prototype/byteOffset/prop-desc.js
@@ -7,11 +7,17 @@ description: >
info: >
%TypedArray%.prototype.byteOffset is an accessor property whose set accessor
function is undefined.
-includes: [testTypedArray.js]
+
+ Section 17: Every accessor property described in clauses 18 through 26 and in
+ Annex B.2 has the attributes {[[Enumerable]]: false, [[Configurable]]: true }
+includes: [propertyHelper.js, testTypedArray.js]
---*/
var TypedArrayPrototype = TypedArray.prototype;
-var desc = Object.getOwnPropertyDescriptor(TypedArrayPrototype, 'byteOffset');
+var desc = Object.getOwnPropertyDescriptor(TypedArrayPrototype, "byteOffset");
assert.sameValue(desc.set, undefined);
-assert.sameValue(typeof desc.get, 'function');
+assert.sameValue(typeof desc.get, "function");
+
+verifyNotEnumerable(TypedArrayPrototype, "byteOffset");
+verifyConfigurable(TypedArrayPrototype, "byteOffset");
diff --git a/test/built-ins/TypedArray/prototype/length/prop-desc.js b/test/built-ins/TypedArray/prototype/length/prop-desc.js
index 3f40eae893..ff2718060b 100644
--- a/test/built-ins/TypedArray/prototype/length/prop-desc.js
+++ b/test/built-ins/TypedArray/prototype/length/prop-desc.js
@@ -7,11 +7,17 @@ description: >
info: >
%TypedArray%.prototype.length is an accessor property whose set accessor
function is undefined.
-includes: [testTypedArray.js]
+
+ Section 17: Every accessor property described in clauses 18 through 26 and in
+ Annex B.2 has the attributes {[[Enumerable]]: false, [[Configurable]]: true }
+includes: [propertyHelper.js, testTypedArray.js]
---*/
var TypedArrayPrototype = TypedArray.prototype;
-var desc = Object.getOwnPropertyDescriptor(TypedArrayPrototype, 'length');
+var desc = Object.getOwnPropertyDescriptor(TypedArrayPrototype, "length");
assert.sameValue(desc.set, undefined);
-assert.sameValue(typeof desc.get, 'function');
+assert.sameValue(typeof desc.get, "function");
+
+verifyNotEnumerable(TypedArrayPrototype, "length");
+verifyConfigurable(TypedArrayPrototype, "length");
diff --git a/test/built-ins/TypedArray/prototype/toString/prop-desc.js b/test/built-ins/TypedArray/prototype/toString/prop-desc.js
new file mode 100644
index 0000000000..c5277b1477
--- /dev/null
+++ b/test/built-ins/TypedArray/prototype/toString/prop-desc.js
@@ -0,0 +1,19 @@
+// Copyright (C) 2016 the V8 project authors. All rights reserved.
+// This code is governed by the BSD license found in the LICENSE file.
+/*---
+es6id: 22.2.3.28
+esid: sec-%typedarray%.prototype.tostring
+description: >
+ "String" property of TypedArrayPrototype
+info: >
+ ES6 section 17: Every other data property described in clauses 18 through
+ 26 and in Annex B.2 has the attributes { [[Writable]]: true,
+ [[Enumerable]]: false, [[Configurable]]: true } unless otherwise specified.
+includes: [propertyHelper.js, testTypedArray.js]
+---*/
+
+var TypedArrayPrototype = TypedArray.prototype;
+
+verifyNotEnumerable(TypedArrayPrototype, "toString");
+verifyWritable(TypedArrayPrototype, "toString");
+verifyConfigurable(TypedArrayPrototype, "toString");
--
GitLab