From 812e071f039f1bbf40095a56bb8fb759cd81697d Mon Sep 17 00:00:00 2001
From: Valerie R Young <spectranaut@riseup.net>
Date: Fri, 29 Sep 2017 14:11:43 -0400
Subject: [PATCH] fixup: Add boolean/Symbol() tests for trim(Start/End)

---
 .../prototype/trimEnd/this-value-boolean.js   | 28 +++++++++++++------
 .../trimEnd/this-value-symbol-typeerror.js    | 13 +++++----
 .../prototype/trimStart/this-value-boolean.js | 26 +++++++++++------
 .../trimStart/this-value-symbol-typeerror.js  | 13 +++++----
 4 files changed, 53 insertions(+), 27 deletions(-)

diff --git a/test/built-ins/String/prototype/trimEnd/this-value-boolean.js b/test/built-ins/String/prototype/trimEnd/this-value-boolean.js
index 1a695e3b97..8075fb994b 100644
--- a/test/built-ins/String/prototype/trimEnd/this-value-boolean.js
+++ b/test/built-ins/String/prototype/trimEnd/this-value-boolean.js
@@ -2,20 +2,30 @@
 // This code is governed by the BSD license found in the LICENSE file.
 
 /*---
-esid: pending
-description: Behavoir when "this" value is a boolean.
+esid: sec-string.prototype.trimEnd
+description: Behavior when "this" value is a boolean.
+info: |
+  TrimString
+  2. Let S be ? ToString(str).
+
+  ToString
+  Argument Type: Boolean
+  Result:
+    If argument is true, return "true".
+    If argument is false, return "false".
+features: [string-trimming]
 ---*/
 
-var trimStart = String.prototype.trimStart
+var trimEnd = String.prototype.trimEnd
 
 assert.sameValue(
-    trimStart.call(true),
-    'true',
-    'String.prototype.trimStart.call(true)'
+  trimEnd.call(true),
+  'true',
+  'String.prototype.trimEnd.call(true)'
 );
 
 assert.sameValue(
-    String.prototype.trimStart.call(false),
-    'false',
-    'String.prototype.trimStart.call(false)'
+  String.prototype.trimEnd.call(false),
+  'false',
+  'String.prototype.trimEnd.call(false)'
 );
diff --git a/test/built-ins/String/prototype/trimEnd/this-value-symbol-typeerror.js b/test/built-ins/String/prototype/trimEnd/this-value-symbol-typeerror.js
index e9f32fb76b..6c98396e04 100644
--- a/test/built-ins/String/prototype/trimEnd/this-value-symbol-typeerror.js
+++ b/test/built-ins/String/prototype/trimEnd/this-value-symbol-typeerror.js
@@ -2,7 +2,7 @@
 // This code is governed by the BSD license found in the LICENSE file.
 
 /*---
-esid: pending
+esid: sec-string.prototype.trimEnd
 description: Type error when "this" value is a Symbol
 info: |
   TrimString
@@ -11,11 +11,14 @@ info: |
   ToString
   Argument Type: Symbol
   Result: Throw a TypeError exception
+features: [string-trimming]
 ---*/
 
 var trimEnd = String.prototype.trimEnd;
-var symbol = Symbol()
+var symbol = Symbol();
 
-assert.throws(TypeError, function() {
-  trimEnd.call(symbol);
-}, 'Symbol()');
+assert.throws(
+  TypeError,
+  function() { trimEnd.call(symbol); },
+  'String.prototype.trimEnd.call(Symbol())'
+);
diff --git a/test/built-ins/String/prototype/trimStart/this-value-boolean.js b/test/built-ins/String/prototype/trimStart/this-value-boolean.js
index 1a695e3b97..5997bae754 100644
--- a/test/built-ins/String/prototype/trimStart/this-value-boolean.js
+++ b/test/built-ins/String/prototype/trimStart/this-value-boolean.js
@@ -2,20 +2,30 @@
 // This code is governed by the BSD license found in the LICENSE file.
 
 /*---
-esid: pending
-description: Behavoir when "this" value is a boolean.
+esid: sec-string.prototype.trimStart
+description: Behavior when "this" value is a boolean.
+info: |
+  TrimString
+  2. Let S be ? ToString(str).
+
+  ToString
+  Argument Type: Boolean
+  Result:
+    If argument is true, return "true".
+    If argument is false, return "false".
+features: [string-trimming]
 ---*/
 
 var trimStart = String.prototype.trimStart
 
 assert.sameValue(
-    trimStart.call(true),
-    'true',
-    'String.prototype.trimStart.call(true)'
+  trimStart.call(true),
+  'true',
+  'String.prototype.trimStart.call(true)'
 );
 
 assert.sameValue(
-    String.prototype.trimStart.call(false),
-    'false',
-    'String.prototype.trimStart.call(false)'
+  String.prototype.trimStart.call(false),
+  'false',
+  'String.prototype.trimStart.call(false)'
 );
diff --git a/test/built-ins/String/prototype/trimStart/this-value-symbol-typeerror.js b/test/built-ins/String/prototype/trimStart/this-value-symbol-typeerror.js
index b3b87c63f8..5d26ec6173 100644
--- a/test/built-ins/String/prototype/trimStart/this-value-symbol-typeerror.js
+++ b/test/built-ins/String/prototype/trimStart/this-value-symbol-typeerror.js
@@ -2,7 +2,7 @@
 // This code is governed by the BSD license found in the LICENSE file.
 
 /*---
-esid: pending
+esid: sec-string.prototype.trimStart
 description: Type error when "this" value is a Symbol
 info: |
   TrimString
@@ -11,11 +11,14 @@ info: |
   ToString
   Argument Type: Symbol
   Result: Throw a TypeError exception
+features: [string-trimming]
 ---*/
 
 var trimStart = String.prototype.trimStart;
-var symbol = Symbol()
+var symbol = Symbol();
 
-assert.throws(TypeError, function() {
-  trimStart.call(symbol);
-}, 'Symbol()');
+assert.throws(
+  TypeError,
+  function() { trimStart.call(symbol); },
+  'String.prototype.trimStart.call(Symbol())'
+);
-- 
GitLab