From a266cfa8cb8c17f5724298f2205c03c26c7c83e0 Mon Sep 17 00:00:00 2001
From: Claude Pache <claude.pache@gmail.com>
Date: Wed, 1 Mar 2017 21:32:46 +0100
Subject: [PATCH] Add tests for known violation of invariants (#841)
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Some popular JavaScript engines display violation of invariants about
property attributes for some non-standard but “web-reality†object
properties. Add tests against such violations
Closes #653
Fixes #649
---
.../consistent-value-function-arguments.js | 31 ++++++++++++++++
.../consistent-value-function-caller.js | 35 +++++++++++++++++++
.../consistent-value-regexp-$1.js | 28 +++++++++++++++
.../consistent-writable-regexp-$1.js | 22 ++++++++++++
4 files changed, 116 insertions(+)
create mode 100644 test/built-ins/Object/internals/DefineOwnProperty/consistent-value-function-arguments.js
create mode 100644 test/built-ins/Object/internals/DefineOwnProperty/consistent-value-function-caller.js
create mode 100644 test/built-ins/Object/internals/DefineOwnProperty/consistent-value-regexp-$1.js
create mode 100644 test/built-ins/Object/internals/DefineOwnProperty/consistent-writable-regexp-$1.js
diff --git a/test/built-ins/Object/internals/DefineOwnProperty/consistent-value-function-arguments.js b/test/built-ins/Object/internals/DefineOwnProperty/consistent-value-function-arguments.js
new file mode 100644
index 0000000000..4970e78262
--- /dev/null
+++ b/test/built-ins/Object/internals/DefineOwnProperty/consistent-value-function-arguments.js
@@ -0,0 +1,31 @@
+// Copyright (C) 2017 Claude Pache. All rights reserved.
+// This code is governed by the BSD license found in the LICENSE file.
+/*---
+esid: sec-invariants-of-the-essential-internal-methods
+es6id: 6.1.7.3
+description: >
+ Value of non-writable, non-configurable data property must not change
+ ("arguments" property of a non-strict function)
+info: |
+ [[GetOwnProperty]] (P)
+ [...]
+ - If a property P is described as a data property with Desc.[[Value]] equal
+ to v and Desc.[[Writable]] and Desc.[[Configurable]] are both false, then
+ the SameValue must be returned for the Desc.[[Value]] attribute of the
+ property on all future calls to [[GetOwnProperty]] ( P ).
+ [...]
+ (This invariant was violated for the specific property under test by a number
+ of implementations as of January 2017.)
+---*/
+
+function f() {
+ return Reflect.getOwnPropertyDescriptor(f, 'arguments');
+}
+
+Reflect.defineProperty(f, 'arguments', { writable: false, configurable: false });
+
+var desc = Reflect.getOwnPropertyDescriptor(f, 'arguments');
+if (desc && desc.configurable === false && desc.writable === false) {
+ var desc2 = f();
+ assert.sameValue(desc.value, desc2.value);
+}
diff --git a/test/built-ins/Object/internals/DefineOwnProperty/consistent-value-function-caller.js b/test/built-ins/Object/internals/DefineOwnProperty/consistent-value-function-caller.js
new file mode 100644
index 0000000000..736ccf3ee0
--- /dev/null
+++ b/test/built-ins/Object/internals/DefineOwnProperty/consistent-value-function-caller.js
@@ -0,0 +1,35 @@
+// Copyright (C) 2017 Claude Pache. All rights reserved.
+// This code is governed by the BSD license found in the LICENSE file.
+/*---
+esid: sec-invariants-of-the-essential-internal-methods
+es6id: 6.1.7.3
+description: >
+ Value of non-writable, non-configurable data property must not change
+ ("caller" property of a non-strict function)
+info: |
+ [[GetOwnProperty]] (P)
+ [...]
+ - If a property P is described as a data property with Desc.[[Value]] equal
+ to v and Desc.[[Writable]] and Desc.[[Configurable]] are both false, then
+ the SameValue must be returned for the Desc.[[Value]] attribute of the
+ property on all future calls to [[GetOwnProperty]] ( P ).
+ [...]
+ (This invariant was violated for the specific property under test by a number
+ of implementations as of January 2017.)
+---*/
+
+function f() {
+ return Reflect.getOwnPropertyDescriptor(f, 'caller');
+}
+
+function g() {
+ return f();
+}
+
+Reflect.defineProperty(f, 'caller', { writable: false, configurable: false });
+
+var desc = Reflect.getOwnPropertyDescriptor(f, 'caller');
+if (desc && desc.configurable === false && desc.writable === false) {
+ var desc2 = g();
+ assert.sameValue(desc.value, desc2.value);
+}
diff --git a/test/built-ins/Object/internals/DefineOwnProperty/consistent-value-regexp-$1.js b/test/built-ins/Object/internals/DefineOwnProperty/consistent-value-regexp-$1.js
new file mode 100644
index 0000000000..4d80030e9d
--- /dev/null
+++ b/test/built-ins/Object/internals/DefineOwnProperty/consistent-value-regexp-$1.js
@@ -0,0 +1,28 @@
+// Copyright (C) 2017 Claude Pache. All rights reserved.
+// This code is governed by the BSD license found in the LICENSE file.
+/*---
+esid: sec-invariants-of-the-essential-internal-methods
+es6id: 6.1.7.3
+description: >
+ Value of non-writable, non-configurable data property must not change
+ ("$1" property of the RegExp built-in)
+info: |
+ [[GetOwnProperty]] (P)
+ [...]
+ - If a property P is described as a data property with Desc.[[Value]] equal
+ to v and Desc.[[Writable]] and Desc.[[Configurable]] are both false, then
+ the SameValue must be returned for the Desc.[[Value]] attribute of the
+ property on all future calls to [[GetOwnProperty]] ( P ).
+ [...]
+ (This invariant was violated for the specific property under test by at least
+ one implementation as of January 2017.)
+---*/
+
+Reflect.defineProperty(RegExp, '$1', { writable: false, configurable: false });
+
+var desc = Reflect.getOwnPropertyDescriptor(RegExp, '$1');
+if (desc && desc.configurable === false && desc.writable === false) {
+ /(x)/.exec('x');
+ var desc2 = Reflect.getOwnPropertyDescriptor(RegExp, '$1');
+ assert.sameValue(desc.value, desc2.value);
+}
diff --git a/test/built-ins/Object/internals/DefineOwnProperty/consistent-writable-regexp-$1.js b/test/built-ins/Object/internals/DefineOwnProperty/consistent-writable-regexp-$1.js
new file mode 100644
index 0000000000..38ab43d2df
--- /dev/null
+++ b/test/built-ins/Object/internals/DefineOwnProperty/consistent-writable-regexp-$1.js
@@ -0,0 +1,22 @@
+// Copyright (C) 2017 Claude Pache. All rights reserved.
+// This code is governed by the BSD license found in the LICENSE file.
+/*---
+esid: sec-invariants-of-the-essential-internal-methods
+es6id: 6.1.7.3
+description: >
+ A property made non-writable, non-configurable must not be reported as writable
+ ("$1" property of the RegExp built-in)
+info: |
+ [[GetOwnProperty]] (P)
+ [...]
+ - If the [[Writable]] attribute may change from false to true,
+ then the [[Configurable]] attribute must be true..
+ [...]
+ (This invariant was violated for the specific property under test by at least
+ one implementation as of January 2017.)
+---*/
+
+if (Reflect.defineProperty(RegExp, '$1', { writable: false, configurable: false })) {
+ var desc = Reflect.getOwnPropertyDescriptor(RegExp, '$1');
+ assert.sameValue(desc.writable, false);
+}
--
GitLab