From ccaa9571ea98af7a05f3fd655acb979e48d24857 Mon Sep 17 00:00:00 2001 From: Mike Pennisi <mike@mikepennisi.com> Date: Sun, 8 Jul 2018 11:38:19 -0400 Subject: [PATCH] Refactor string literal test for parsers Thsi test for the parsing of string literals was expressed using `eval`. This made the test more complex than necessary and also prevented the test from providing value to ECMAScript parsers. Remove the use of `eval` and instead express the expectation with literal source text. --- ...> legacy-octal-escape-sequence-prologue-strict.js} | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) rename test/language/literals/string/{7.8.4-1-s.js => legacy-octal-escape-sequence-prologue-strict.js} (64%) diff --git a/test/language/literals/string/7.8.4-1-s.js b/test/language/literals/string/legacy-octal-escape-sequence-prologue-strict.js similarity index 64% rename from test/language/literals/string/7.8.4-1-s.js rename to test/language/literals/string/legacy-octal-escape-sequence-prologue-strict.js index b28c833069..0887991869 100644 --- a/test/language/literals/string/7.8.4-1-s.js +++ b/test/language/literals/string/legacy-octal-escape-sequence-prologue-strict.js @@ -6,9 +6,14 @@ es5id: 7.8.4-1-s description: > A directive preceeding an 'use strict' directive may not contain an OctalEscapeSequence +negative: + phase: parse + type: SyntaxError ---*/ - -assert.throws(SyntaxError, function() { - eval(' "asterisk: \\052" /* octal escape sequences forbidden in strict mode*/ ; "use strict";'); +throw "Test262: This statement should not be evaluated."; + +(function() { + "asterisk: \052"; + "use strict"; }); -- GitLab