From ce2e4214648437cdc7617c56a9f01c802019292b Mon Sep 17 00:00:00 2001
From: Mike Pennisi <mike@mikepennisi.com>
Date: Thu, 30 Jun 2016 13:55:01 -0400
Subject: [PATCH] Add tests for interpretation of `let` token

---
 .../for-in/head-let-destructuring.js          | 31 ++++++++++++++
 .../statements/for-in/head-lhs-let.js         | 38 +++++++++++++++++
 .../for-of/head-let-destructuring.js          | 28 +++++++++++++
 .../statements/for-of/head-lhs-let.js         | 21 ++++++++++
 .../statements/for/head-let-destructuring.js  | 30 ++++++++++++++
 test/language/statements/for/head-lhs-let.js  | 41 +++++++++++++++++++
 6 files changed, 189 insertions(+)
 create mode 100644 test/language/statements/for-in/head-let-destructuring.js
 create mode 100644 test/language/statements/for-in/head-lhs-let.js
 create mode 100644 test/language/statements/for-of/head-let-destructuring.js
 create mode 100644 test/language/statements/for-of/head-lhs-let.js
 create mode 100644 test/language/statements/for/head-let-destructuring.js
 create mode 100644 test/language/statements/for/head-lhs-let.js

diff --git a/test/language/statements/for-in/head-let-destructuring.js b/test/language/statements/for-in/head-let-destructuring.js
new file mode 100644
index 0000000000..604d80e95b
--- /dev/null
+++ b/test/language/statements/for-in/head-let-destructuring.js
@@ -0,0 +1,31 @@
+// Copyright (C) 2016 the V8 project authors. All rights reserved.
+// This code is governed by the BSD license found in the LICENSE file.
+/*---
+esid: sec-iteration-statements
+es6id: 13.7
+description: >
+  The token sequence `let [`is interpreted as the beginning of a destructuring
+  binding pattern
+info: |
+  Syntax
+
+  IterationStatement[Yield, Return]:
+
+    for ( [lookahead ∉ { let [ } ] LeftHandSideExpression[?Yield] in
+      Expression[+In, ?Yield] ) Statement[?Yield, ?Return]
+
+    for ( ForDeclaration[?Yield] in Expression[+In, ?Yield] )
+      Statement[?Yield, ?Return]
+---*/
+
+var obj = Object.create(null);
+var value;
+
+obj.key = 1;
+
+for ( let[x] in obj ) {
+  value = x;
+}
+
+assert.sameValue(typeof x, 'undefined', 'binding is block-scoped');
+assert.sameValue(value, 'k');
diff --git a/test/language/statements/for-in/head-lhs-let.js b/test/language/statements/for-in/head-lhs-let.js
new file mode 100644
index 0000000000..80294a11dc
--- /dev/null
+++ b/test/language/statements/for-in/head-lhs-let.js
@@ -0,0 +1,38 @@
+// Copyright (C) 2016 the V8 project authors. All rights reserved.
+// This code is governed by the BSD license found in the LICENSE file.
+/*---
+esid: sec-iteration-statements
+es6id: 13.7
+description: >
+  The `let` token is interpreted as an Identifier when it is not followed by a
+  `[` token
+info: |
+  Syntax
+
+  IterationStatement[Yield, Return]:
+
+    for ( [lookahead ∉ { let [ } ] LeftHandSideExpression[?Yield] in
+      Expression[+In, ?Yield] ) Statement[?Yield, ?Return]
+
+    for ( ForDeclaration[?Yield] in Expression[+In, ?Yield] )
+      Statement[?Yield, ?Return]
+flags: [noStrict]
+---*/
+
+var obj = Object.create(null);
+var let, value;
+
+obj.key = 1;
+
+for ( let in obj ) ;
+
+assert.sameValue(let, 'key', 'IdentifierReference');
+
+Object.defineProperty(Array.prototype, '1', {
+  set: function(param) {
+    value = param;
+  }
+});
+for ( [let][1] in obj ) ;
+
+assert.sameValue(value, 'key', 'MemberExpression');
diff --git a/test/language/statements/for-of/head-let-destructuring.js b/test/language/statements/for-of/head-let-destructuring.js
new file mode 100644
index 0000000000..66c93ad946
--- /dev/null
+++ b/test/language/statements/for-of/head-let-destructuring.js
@@ -0,0 +1,28 @@
+// Copyright (C) 2016 the V8 project authors. All rights reserved.
+// This code is governed by the BSD license found in the LICENSE file.
+/*---
+esid: sec-for-in-and-for-of-statements
+es6id: 13.7.5
+description: >
+  The token sequence `let [`is interpreted as the beginning of a destructuring
+  binding pattern
+info: |
+  Syntax
+
+  IterationStatement[Yield, Return]:
+
+    for ( [lookahead ≠ let]LeftHandSideExpression[?Yield] of
+      AssignmentExpression[+In, ?Yield] ) Statement[?Yield, ?Return]
+
+    for ( ForDeclaration[?Yield] of AssignmentExpression[+In, ?Yield] )
+      Statement[?Yield, ?Return]
+---*/
+
+var value;
+
+for ( let[x] of [[34]] ) {
+  value = x;
+}
+
+assert.sameValue(typeof x, 'undefined', 'binding is block-scoped');
+assert.sameValue(value, 34);
diff --git a/test/language/statements/for-of/head-lhs-let.js b/test/language/statements/for-of/head-lhs-let.js
new file mode 100644
index 0000000000..8c3e0fe2f6
--- /dev/null
+++ b/test/language/statements/for-of/head-lhs-let.js
@@ -0,0 +1,21 @@
+// Copyright (C) 2016 the V8 project authors. All rights reserved.
+// This code is governed by the BSD license found in the LICENSE file.
+/*---
+esid: sec-for-in-and-for-of-statements
+es6id: 13.7.5
+description: >
+  The `let` token is disallowed when not followed by a `[` token
+info: |
+  Syntax
+
+  IterationStatement[Yield, Return]:
+
+    for ( [lookahead ≠ let]LeftHandSideExpression[?Yield] of
+      AssignmentExpression[+In, ?Yield] ) Statement[?Yield, ?Return]
+
+    for ( ForDeclaration[?Yield] of AssignmentExpression[+In, ?Yield] )
+      Statement[?Yield, ?Return]
+negative: SyntaxError
+---*/
+
+for ( let of [] ) ;
diff --git a/test/language/statements/for/head-let-destructuring.js b/test/language/statements/for/head-let-destructuring.js
new file mode 100644
index 0000000000..283f6285ae
--- /dev/null
+++ b/test/language/statements/for/head-let-destructuring.js
@@ -0,0 +1,30 @@
+// Copyright (C) 2016 the V8 project authors. All rights reserved.
+// This code is governed by the BSD license found in the LICENSE file.
+/*---
+esid: sec-iteration-statements
+es6id: 13.7
+description: >
+  The token sequence `let [`is interpreted as the beginning of a destructuring
+  binding pattern
+info: |
+  Syntax
+
+  IterationStatement[Yield, Return]:
+
+    for ( [lookahead ∉ { let [ } ] Expression[~In, ?Yield]opt ;
+      Expression[+In, ?Yield]opt ; Expression[+In, ?Yield]opt )
+      Statement[?Yield, ?Return]
+
+    for ( LexicalDeclaration[~In, ?Yield] Expression[+In, ?Yield]opt ;
+      Expression[+In, ?Yield]opt) Statement[?Yield, ?Return]
+---*/
+
+var value;
+
+for ( let[x] = [23]; ; ) {
+  value = x;
+  break;
+}
+
+assert.sameValue(typeof x, 'undefined', 'binding is block-scoped');
+assert.sameValue(value, 23);
diff --git a/test/language/statements/for/head-lhs-let.js b/test/language/statements/for/head-lhs-let.js
new file mode 100644
index 0000000000..cd705ec107
--- /dev/null
+++ b/test/language/statements/for/head-lhs-let.js
@@ -0,0 +1,41 @@
+// Copyright (C) 2016 the V8 project authors. All rights reserved.
+// This code is governed by the BSD license found in the LICENSE file.
+/*---
+esid: sec-iteration-statements
+es6id: 13.7
+description: >
+  The `let` token is interpreted as an Identifier when it is not followed by a
+  `[` token
+info: |
+  Syntax
+
+  IterationStatement[Yield, Return]:
+
+    for ( [lookahead ∉ { let [ } ] Expression[~In, ?Yield]opt ;
+      Expression[+In, ?Yield]opt ; Expression[+In, ?Yield]opt )
+      Statement[?Yield, ?Return]
+
+    for ( LexicalDeclaration[~In, ?Yield] Expression[+In, ?Yield]opt ;
+      Expression[+In, ?Yield]opt) Statement[?Yield, ?Return]
+flags: [noStrict]
+---*/
+
+var let;
+
+let = 1;
+for ( let; ; )
+  break;
+
+assert.sameValue(let, 1, 'IdentifierReference');
+
+let = 2;
+for ( let = 3; ; )
+  break;
+
+assert.sameValue(let, 3, 'AssignmentExpression');
+
+let = 4;
+for ( [let][0]; ; )
+  break;
+
+assert.sameValue(let, 4, 'MemberExpression');
-- 
GitLab