From d231b90ea8bf37abc21f9ca4ca43d4a9fc53f9be Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Andr=C3=A9=20Bargull?= <andre.bargull@gmail.com>
Date: Fri, 8 Dec 2017 13:20:42 -0800
Subject: [PATCH] Add tests for direct-eval calls with spread expressions
---
.../call/eval-spread-empty-leading.js | 41 ++++++++++++++++
.../call/eval-spread-empty-trailing.js | 41 ++++++++++++++++
.../expressions/call/eval-spread-empty.js | 34 +++++++++++++
test/language/expressions/call/eval-spread.js | 49 +++++++++++++++++++
4 files changed, 165 insertions(+)
create mode 100644 test/language/expressions/call/eval-spread-empty-leading.js
create mode 100644 test/language/expressions/call/eval-spread-empty-trailing.js
create mode 100644 test/language/expressions/call/eval-spread-empty.js
create mode 100644 test/language/expressions/call/eval-spread.js
diff --git a/test/language/expressions/call/eval-spread-empty-leading.js b/test/language/expressions/call/eval-spread-empty-leading.js
new file mode 100644
index 0000000000..74ddaa89e9
--- /dev/null
+++ b/test/language/expressions/call/eval-spread-empty-leading.js
@@ -0,0 +1,41 @@
+// Copyright (C) 2017 André Bargull. All rights reserved.
+// This code is governed by the BSD license found in the LICENSE file.
+
+/*---
+id: sec-function-calls-runtime-semantics-evaluation
+info: >
+ Direct eval call with empty leading spread.
+description: |
+ 12.3.4.1 Runtime Semantics: Evaluation
+ ...
+ 3. If Type(ref) is Reference and IsPropertyReference(ref) is false and GetReferencedName(ref) is "eval", then
+ a. If SameValue(func, %eval%) is true, then
+ i. Let argList be ? ArgumentListEvaluation(Arguments).
+ ii. If argList has no elements, return undefined.
+ iii. Let evalText be the first element of argList.
+ ...
+
+features: [Symbol.iterator]
+---*/
+
+var nextCount = 0;
+var iter = {};
+iter[Symbol.iterator] = function() {
+ return {
+ next: function() {
+ var i = nextCount++;
+ return {done: true, value: undefined};
+ }
+ };
+};
+
+var x = "global";
+
+(function() {
+ var x = "local";
+ eval(...iter, "x = 0;");
+ assert.sameValue(x, 0);
+})();
+
+assert.sameValue(x, "global");
+assert.sameValue(nextCount, 1);
diff --git a/test/language/expressions/call/eval-spread-empty-trailing.js b/test/language/expressions/call/eval-spread-empty-trailing.js
new file mode 100644
index 0000000000..ee92dc95b7
--- /dev/null
+++ b/test/language/expressions/call/eval-spread-empty-trailing.js
@@ -0,0 +1,41 @@
+// Copyright (C) 2017 André Bargull. All rights reserved.
+// This code is governed by the BSD license found in the LICENSE file.
+
+/*---
+id: sec-function-calls-runtime-semantics-evaluation
+info: >
+ Direct eval call with empty trailing spread.
+description: |
+ 12.3.4.1 Runtime Semantics: Evaluation
+ ...
+ 3. If Type(ref) is Reference and IsPropertyReference(ref) is false and GetReferencedName(ref) is "eval", then
+ a. If SameValue(func, %eval%) is true, then
+ i. Let argList be ? ArgumentListEvaluation(Arguments).
+ ii. If argList has no elements, return undefined.
+ iii. Let evalText be the first element of argList.
+ ...
+
+features: [Symbol.iterator]
+---*/
+
+var nextCount = 0;
+var iter = {};
+iter[Symbol.iterator] = function() {
+ return {
+ next: function() {
+ var i = nextCount++;
+ return {done: true, value: undefined};
+ }
+ };
+};
+
+var x = "global";
+
+(function() {
+ var x = "local";
+ eval("x = 0;", ...iter);
+ assert.sameValue(x, 0);
+})();
+
+assert.sameValue(x, "global");
+assert.sameValue(nextCount, 1);
diff --git a/test/language/expressions/call/eval-spread-empty.js b/test/language/expressions/call/eval-spread-empty.js
new file mode 100644
index 0000000000..3c462a686d
--- /dev/null
+++ b/test/language/expressions/call/eval-spread-empty.js
@@ -0,0 +1,34 @@
+// Copyright (C) 2017 André Bargull. All rights reserved.
+// This code is governed by the BSD license found in the LICENSE file.
+
+/*---
+id: sec-function-calls-runtime-semantics-evaluation
+info: >
+ Direct eval call with empty spread.
+description: |
+ 12.3.4.1 Runtime Semantics: Evaluation
+ ...
+ 3. If Type(ref) is Reference and IsPropertyReference(ref) is false and GetReferencedName(ref) is "eval", then
+ a. If SameValue(func, %eval%) is true, then
+ i. Let argList be ? ArgumentListEvaluation(Arguments).
+ ii. If argList has no elements, return undefined.
+ ...
+
+features: [Symbol.iterator]
+---*/
+
+var nextCount = 0;
+var iter = {};
+iter[Symbol.iterator] = function() {
+ return {
+ next: function() {
+ var i = nextCount++;
+ return {done: true, value: undefined};
+ }
+ };
+};
+
+var result = eval(...iter);
+
+assert.sameValue(result, undefined);
+assert.sameValue(nextCount, 1);
diff --git a/test/language/expressions/call/eval-spread.js b/test/language/expressions/call/eval-spread.js
new file mode 100644
index 0000000000..8ad99fcf9c
--- /dev/null
+++ b/test/language/expressions/call/eval-spread.js
@@ -0,0 +1,49 @@
+// Copyright (C) 2017 André Bargull. All rights reserved.
+// This code is governed by the BSD license found in the LICENSE file.
+
+/*---
+id: sec-function-calls-runtime-semantics-evaluation
+info: >
+ Direct eval call with spread.
+description: |
+ 12.3.4.1 Runtime Semantics: Evaluation
+ ...
+ 3. If Type(ref) is Reference and IsPropertyReference(ref) is false and GetReferencedName(ref) is "eval", then
+ a. If SameValue(func, %eval%) is true, then
+ i. Let argList be ? ArgumentListEvaluation(Arguments).
+ ii. If argList has no elements, return undefined.
+ iii. Let evalText be the first element of argList.
+ ...
+
+features: [Symbol.iterator]
+---*/
+
+var elements = [
+ "x = 1;",
+ "x = 2;",
+];
+
+var nextCount = 0;
+var iter = {};
+iter[Symbol.iterator] = function() {
+ return {
+ next: function() {
+ var i = nextCount++;
+ if (i < elements.length) {
+ return {done: false, value: elements[i]};
+ }
+ return {done: true, value: undefined};
+ }
+ };
+};
+
+var x = "global";
+
+(function() {
+ var x = "local";
+ eval(...iter);
+ assert.sameValue(x, 1);
+})();
+
+assert.sameValue(x, "global");
+assert.sameValue(nextCount, 3);
--
GitLab