From d3effa125f8661aa4f36915e17ef979b66a61b7f Mon Sep 17 00:00:00 2001
From: Leonardo Balter <leonardo.balter@gmail.com>
Date: Mon, 16 May 2016 11:32:43 -0400
Subject: [PATCH] Add tests for DataView.prototype.setUint32

---
 .../byteoffset-is-different-integer-throws.js | 62 +++++++++++++
 .../byteoffset-is-negative-throws.js          | 37 ++++++++
 ...etached-buffer-after-integer-byteoffset.js | 38 ++++++++
 .../detached-buffer-after-number-value.js     | 39 ++++++++
 ...hed-buffer-before-outofrange-byteoffset.js | 40 +++++++++
 .../prototype/setUint32/detached-buffer.js    | 31 +++++++
 .../index-check-before-value-conversion.js    |  7 +-
 .../setUint32/index-is-out-of-range.js        | 90 +++++++++++++++++++
 .../prototype/setUint32/index-to-integer.js   |  2 +-
 .../prototype/setUint32/no-value-arg.js       | 39 ++++++++
 .../range-check-after-value-conversion.js     | 14 ++-
 ...-abrupt-from-tonumber-byteoffset-symbol.js | 31 +++++++
 .../return-abrupt-from-tonumber-byteoffset.js | 44 +++++++++
 ...eturn-abrupt-from-tonumber-value-symbol.js | 31 +++++++
 .../return-abrupt-from-tonumber-value.js      | 44 +++++++++
 .../set-values-little-endian-order.js         | 58 ++++++++++++
 .../setUint32/set-values-return-undefined.js  | 53 +++++++++++
 .../this-has-no-dataview-internal.js          | 43 +++++++++
 .../prototype/setUint32/this-is-not-object.js | 51 +++++++++++
 .../setUint32/to-boolean-littleendian.js      | 47 ++++++++++
 20 files changed, 789 insertions(+), 12 deletions(-)
 create mode 100644 test/built-ins/DataView/prototype/setUint32/byteoffset-is-different-integer-throws.js
 create mode 100644 test/built-ins/DataView/prototype/setUint32/byteoffset-is-negative-throws.js
 create mode 100644 test/built-ins/DataView/prototype/setUint32/detached-buffer-after-integer-byteoffset.js
 create mode 100644 test/built-ins/DataView/prototype/setUint32/detached-buffer-after-number-value.js
 create mode 100644 test/built-ins/DataView/prototype/setUint32/detached-buffer-before-outofrange-byteoffset.js
 create mode 100644 test/built-ins/DataView/prototype/setUint32/detached-buffer.js
 create mode 100644 test/built-ins/DataView/prototype/setUint32/index-is-out-of-range.js
 create mode 100644 test/built-ins/DataView/prototype/setUint32/no-value-arg.js
 create mode 100644 test/built-ins/DataView/prototype/setUint32/return-abrupt-from-tonumber-byteoffset-symbol.js
 create mode 100644 test/built-ins/DataView/prototype/setUint32/return-abrupt-from-tonumber-byteoffset.js
 create mode 100644 test/built-ins/DataView/prototype/setUint32/return-abrupt-from-tonumber-value-symbol.js
 create mode 100644 test/built-ins/DataView/prototype/setUint32/return-abrupt-from-tonumber-value.js
 create mode 100644 test/built-ins/DataView/prototype/setUint32/set-values-little-endian-order.js
 create mode 100644 test/built-ins/DataView/prototype/setUint32/set-values-return-undefined.js
 create mode 100644 test/built-ins/DataView/prototype/setUint32/this-has-no-dataview-internal.js
 create mode 100644 test/built-ins/DataView/prototype/setUint32/this-is-not-object.js
 create mode 100644 test/built-ins/DataView/prototype/setUint32/to-boolean-littleendian.js

diff --git a/test/built-ins/DataView/prototype/setUint32/byteoffset-is-different-integer-throws.js b/test/built-ins/DataView/prototype/setUint32/byteoffset-is-different-integer-throws.js
new file mode 100644
index 0000000000..d8327a4fde
--- /dev/null
+++ b/test/built-ins/DataView/prototype/setUint32/byteoffset-is-different-integer-throws.js
@@ -0,0 +1,62 @@
+// Copyright (C) 2016 the V8 project authors. All rights reserved.
+// This code is governed by the BSD license found in the LICENSE file.
+
+/*---
+esid: sec-dataview.prototype.setuint32
+es6id: 24.2.4.20
+description: >
+  Throws a RangeError if numberIndex ≠ getIndex
+info: |
+  24.2.4.20 DataView.prototype.setUint32 ( byteOffset, value [ , littleEndian ] )
+
+  1. Let v be the this value.
+  2. If littleEndian is not present, let littleEndian be false.
+  3. Return ? SetViewValue(v, byteOffset, littleEndian, "Uint32", value).
+
+  24.2.1.2 SetViewValue ( view, requestIndex, isLittleEndian, type, value )
+
+  ...
+  4. Let numberIndex be ? ToNumber(requestIndex).
+  5. Let getIndex be ToInteger(numberIndex).
+  6. If numberIndex ≠ getIndex or getIndex < 0, throw a RangeError exception.
+  ...
+features: [DataView.prototype.getUint32]
+---*/
+
+var buffer = new ArrayBuffer(12);
+var sample = new DataView(buffer, 0);
+
+assert.throws(RangeError, function() {
+  sample.setUint32();
+}, "no args");
+assert.sameValue(sample.getUint32(0), 0, "no args - no value was set");
+
+assert.throws(RangeError, function() {
+  sample.setUint32(undefined, 39);
+}, "undefined");
+assert.sameValue(sample.getUint32(0), 0, "undefined - no value was set");
+
+assert.throws(RangeError, function() {
+  sample.setUint32(1.1, 39);
+}, "floating number");
+assert.sameValue(sample.getUint32(0), 0, "floating number - no value was set");
+
+assert.throws(RangeError, function() {
+  sample.setUint32(0.1, 39);
+}, "0.1");
+assert.sameValue(sample.getUint32(0), 0, "0.1 - no value was set");
+
+assert.throws(RangeError, function() {
+  sample.setUint32(NaN, 39);
+}, "NaN");
+assert.sameValue(sample.getUint32(0), 0, "NaN - no value was set");
+
+assert.throws(RangeError, function() {
+  sample.setUint32(-0.1, 39);
+}, "-0.1");
+assert.sameValue(sample.getUint32(0), 0, "-0.1 - no value was set");
+
+assert.throws(RangeError, function() {
+  sample.setUint32(-1.1, 39);
+}, "-1.1");
+assert.sameValue(sample.getUint32(0), 0, "-1.1 - no value was set");
diff --git a/test/built-ins/DataView/prototype/setUint32/byteoffset-is-negative-throws.js b/test/built-ins/DataView/prototype/setUint32/byteoffset-is-negative-throws.js
new file mode 100644
index 0000000000..dbc5705583
--- /dev/null
+++ b/test/built-ins/DataView/prototype/setUint32/byteoffset-is-negative-throws.js
@@ -0,0 +1,37 @@
+// Copyright (C) 2016 the V8 project authors. All rights reserved.
+// This code is governed by the BSD license found in the LICENSE file.
+
+/*---
+esid: sec-dataview.prototype.setuint32
+es6id: 24.2.4.20
+description: >
+  Throws a RangeError if getIndex < 0
+info: |
+  24.2.4.20 DataView.prototype.setUint32 ( byteOffset, value [ , littleEndian ] )
+
+  1. Let v be the this value.
+  2. If littleEndian is not present, let littleEndian be false.
+  3. Return ? SetViewValue(v, byteOffset, littleEndian, "Uint32", value).
+
+  24.2.1.2 SetViewValue ( view, requestIndex, isLittleEndian, type, value )
+
+  ...
+  4. Let numberIndex be ? ToNumber(requestIndex).
+  5. Let getIndex be ToInteger(numberIndex).
+  6. If numberIndex ≠ getIndex or getIndex < 0, throw a RangeError exception.
+  ...
+features: [DataView.prototype.getUint32]
+---*/
+
+var buffer = new ArrayBuffer(12);
+var sample = new DataView(buffer, 0);
+
+assert.throws(RangeError, function() {
+  sample.setUint32(-1, 39);
+}, "-1");
+assert.sameValue(sample.getUint32(0), 0, "-1 - no value was set");
+
+assert.throws(RangeError, function() {
+  sample.setUint32(-Infinity, 39);
+}, "-Infinity");
+assert.sameValue(sample.getUint32(0), 0, "-Infinity - no value was set");
diff --git a/test/built-ins/DataView/prototype/setUint32/detached-buffer-after-integer-byteoffset.js b/test/built-ins/DataView/prototype/setUint32/detached-buffer-after-integer-byteoffset.js
new file mode 100644
index 0000000000..4fe6c41df7
--- /dev/null
+++ b/test/built-ins/DataView/prototype/setUint32/detached-buffer-after-integer-byteoffset.js
@@ -0,0 +1,38 @@
+// Copyright (C) 2016 the V8 project authors. All rights reserved.
+// This code is governed by the BSD license found in the LICENSE file.
+
+/*---
+esid: sec-dataview.prototype.setuint32
+es6id: 24.2.4.20
+description: >
+  Detached buffer is checked after checking If numberIndex ≠ getIndex or
+  getIndex < 0
+info: |
+  24.2.4.20 DataView.prototype.setUint32 ( byteOffset, value [ , littleEndian ] )
+
+  1. Let v be the this value.
+  2. If littleEndian is not present, let littleEndian be false.
+  3. Return ? SetViewValue(v, byteOffset, littleEndian, "Uint32", value).
+
+  24.2.1.2 SetViewValue ( view, requestIndex, isLittleEndian, type, value )
+
+  ...
+  6. If numberIndex ≠ getIndex or getIndex < 0, throw a RangeError exception.
+  ...
+  9. Let buffer be the value of view's [[ViewedArrayBuffer]] internal slot.
+  10. If IsDetachedBuffer(buffer) is true, throw a TypeError exception.
+  ...
+includes: [detachArrayBuffer.js]
+---*/
+
+var buffer = new ArrayBuffer(12);
+var sample = new DataView(buffer, 0);
+
+$DETACHBUFFER(buffer);
+assert.throws(RangeError, function() {
+  sample.setUint32(1.1, 0);
+});
+
+assert.throws(RangeError, function() {
+  sample.setUint32(-1, 0);
+});
diff --git a/test/built-ins/DataView/prototype/setUint32/detached-buffer-after-number-value.js b/test/built-ins/DataView/prototype/setUint32/detached-buffer-after-number-value.js
new file mode 100644
index 0000000000..471de56a3f
--- /dev/null
+++ b/test/built-ins/DataView/prototype/setUint32/detached-buffer-after-number-value.js
@@ -0,0 +1,39 @@
+// Copyright (C) 2016 the V8 project authors. All rights reserved.
+// This code is governed by the BSD license found in the LICENSE file.
+
+/*---
+esid: sec-dataview.prototype.setuint32
+es6id: 24.2.4.20
+description: >
+  Detached buffer is checked after ToNumber(value)
+info: |
+  24.2.4.20 DataView.prototype.setUint32 ( byteOffset, value [ , littleEndian ] )
+
+  1. Let v be the this value.
+  2. If littleEndian is not present, let littleEndian be false.
+  3. Return ? SetViewValue(v, byteOffset, littleEndian, "Uint32", value).
+
+  24.2.1.2 SetViewValue ( view, requestIndex, isLittleEndian, type, value )
+
+  ...
+  7. Let numberValue be ? ToNumber(value).
+  ...
+  9. Let buffer be the value of view's [[ViewedArrayBuffer]] internal slot.
+  10. If IsDetachedBuffer(buffer) is true, throw a TypeError exception.
+  ...
+includes: [detachArrayBuffer.js]
+---*/
+
+var buffer = new ArrayBuffer(8);
+var sample = new DataView(buffer, 0);
+
+var v = {
+  valueOf: function() {
+    throw new Test262Error();
+  }
+};
+
+$DETACHBUFFER(buffer);
+assert.throws(Test262Error, function() {
+  sample.setUint32(0, v);
+});
diff --git a/test/built-ins/DataView/prototype/setUint32/detached-buffer-before-outofrange-byteoffset.js b/test/built-ins/DataView/prototype/setUint32/detached-buffer-before-outofrange-byteoffset.js
new file mode 100644
index 0000000000..7c48893667
--- /dev/null
+++ b/test/built-ins/DataView/prototype/setUint32/detached-buffer-before-outofrange-byteoffset.js
@@ -0,0 +1,40 @@
+// Copyright (C) 2016 the V8 project authors. All rights reserved.
+// This code is governed by the BSD license found in the LICENSE file.
+
+/*---
+esid: sec-dataview.prototype.setuint32
+es6id: 24.2.4.20
+description: >
+  Detached buffer is checked before out of range byteOffset's value
+info: |
+  24.2.4.20 DataView.prototype.setUint32 ( byteOffset, value [ , littleEndian ] )
+
+  1. Let v be the this value.
+  2. If littleEndian is not present, let littleEndian be false.
+  3. Return ? SetViewValue(v, byteOffset, littleEndian, "Uint32", value).
+
+  24.2.1.2 SetViewValue ( view, requestIndex, isLittleEndian, type, value )
+
+  ...
+  9. Let buffer be the value of view's [[ViewedArrayBuffer]] internal slot.
+  10. If IsDetachedBuffer(buffer) is true, throw a TypeError exception.
+  ...
+  14. If getIndex + elementSize > viewSize, throw a RangeError exception.
+  ...
+includes: [detachArrayBuffer.js]
+---*/
+
+var sample;
+var buffer = new ArrayBuffer(12);
+
+sample = new DataView(buffer, 0);
+
+$DETACHBUFFER(buffer);
+
+assert.throws(TypeError, function() {
+  sample.setUint32(Infinity, 0);
+}, "Infinity");
+
+assert.throws(TypeError, function() {
+  sample.setUint32(13, 0);
+}, "13");
diff --git a/test/built-ins/DataView/prototype/setUint32/detached-buffer.js b/test/built-ins/DataView/prototype/setUint32/detached-buffer.js
new file mode 100644
index 0000000000..e13f02135e
--- /dev/null
+++ b/test/built-ins/DataView/prototype/setUint32/detached-buffer.js
@@ -0,0 +1,31 @@
+// Copyright (C) 2016 the V8 project authors. All rights reserved.
+// This code is governed by the BSD license found in the LICENSE file.
+
+/*---
+esid: sec-dataview.prototype.setuint32
+es6id: 24.2.4.20
+description: >
+  Throws a TypeError if buffer is detached
+info: |
+  24.2.4.20 DataView.prototype.setUint32 ( byteOffset, value [ , littleEndian ] )
+
+  1. Let v be the this value.
+  2. If littleEndian is not present, let littleEndian be false.
+  3. Return ? SetViewValue(v, byteOffset, littleEndian, "Uint32", value).
+
+  24.2.1.2 SetViewValue ( view, requestIndex, isLittleEndian, type, value )
+
+  ...
+  9. Let buffer be the value of view's [[ViewedArrayBuffer]] internal slot.
+  10. If IsDetachedBuffer(buffer) is true, throw a TypeError exception.
+  ...
+includes: [detachArrayBuffer.js]
+---*/
+
+var buffer = new ArrayBuffer(1);
+var sample = new DataView(buffer, 0);
+
+$DETACHBUFFER(buffer);
+assert.throws(TypeError, function() {
+  sample.setUint32(0, 0);
+});
diff --git a/test/built-ins/DataView/prototype/setUint32/index-check-before-value-conversion.js b/test/built-ins/DataView/prototype/setUint32/index-check-before-value-conversion.js
index 59c9ed55d1..b9abf5028d 100755
--- a/test/built-ins/DataView/prototype/setUint32/index-check-before-value-conversion.js
+++ b/test/built-ins/DataView/prototype/setUint32/index-check-before-value-conversion.js
@@ -4,7 +4,8 @@
 /*---
 esid: sec-dataview.prototype.setuint32
 description: >
-  Throws a RangeError if the index is negative or non-integral number.
+  RangeError exception for negative or non-integral index is thrown before
+  the value conversion.
 info: >
   ...
   3. Return SetViewValue(v, byteOffset, littleEndian, "Uint32", value).
@@ -18,11 +19,11 @@ info: >
     ...
 ---*/
 
-var dataView = new DataView(new ArrayBuffer(8));
+var dataView = new DataView(new ArrayBuffer(8), 0);
 
 var poisoned = {
   valueOf: function() {
-    $ERROR("valueOf called");
+    throw new Test262Error("valueOf called");
   }
 };
 
diff --git a/test/built-ins/DataView/prototype/setUint32/index-is-out-of-range.js b/test/built-ins/DataView/prototype/setUint32/index-is-out-of-range.js
new file mode 100644
index 0000000000..dc72c9e986
--- /dev/null
+++ b/test/built-ins/DataView/prototype/setUint32/index-is-out-of-range.js
@@ -0,0 +1,90 @@
+// Copyright (C) 2016 the V8 project authors. All rights reserved.
+// This code is governed by the BSD license found in the LICENSE file.
+
+/*---
+esid: sec-dataview.prototype.setuint32
+es6id: 24.2.4.20
+description: >
+  Throws a RangeError if getIndex + elementSize > viewSize
+info: |
+  24.2.4.20 DataView.prototype.setUint32 ( byteOffset, value [ , littleEndian ] )
+
+  1. Let v be the this value.
+  2. If littleEndian is not present, let littleEndian be false.
+  3. Return ? SetViewValue(v, byteOffset, littleEndian, "Uint32", value).
+
+  24.2.1.2 SetViewValue ( view, requestIndex, isLittleEndian, type, value )
+
+  ...
+  11. Let viewOffset be the value of view's [[ByteOffset]] internal slot.
+  12. Let viewSize be the value of view's [[ByteLength]] internal slot.
+  13. Let elementSize be the Number value of the Element Size value specified in
+  Table 50 for Element Type type.
+  14. If getIndex + elementSize > viewSize, throw a RangeError exception.
+  ...
+features: [DataView.prototype.getUint32]
+---*/
+
+var sample;
+var buffer = new ArrayBuffer(12);
+
+sample = new DataView(buffer, 0);
+
+assert.throws(RangeError, function() {
+  sample.setUint32(Infinity, 39);
+}, "getIndex == Infinity");
+
+assert.throws(RangeError, function() {
+  sample.setUint32(13, 39);
+}, "13 + 4 > 12");
+
+assert.throws(RangeError, function() {
+  sample.setUint32(12, 39);
+}, "12 + 4 > 12");
+
+assert.throws(RangeError, function() {
+  sample.setUint32(11, 39);
+}, "11 + 4 > 12");
+
+assert.throws(RangeError, function() {
+  sample.setUint32(10, 39);
+}, "10 + 4 > 12");
+
+assert.throws(RangeError, function() {
+  sample.setUint32(9, 39);
+}, "9 + 4 > 12");
+
+sample = new DataView(buffer, 8);
+assert.throws(RangeError, function() {
+  sample.setUint32(1, 39);
+}, "1 + 4 > 4 (offset)");
+
+sample = new DataView(buffer, 9);
+assert.throws(RangeError, function() {
+  sample.setUint32(0, 39);
+}, "0 + 4 > 3 (offset)");
+
+sample = new DataView(buffer, 0, 4);
+assert.throws(RangeError, function() {
+  sample.setUint32(1, 39);
+}, "1 + 4 > 4 (length)");
+
+sample = new DataView(buffer, 0, 3);
+assert.throws(RangeError, function() {
+  sample.setUint32(0, 39);
+}, "0 + 4 > 3 (length)");
+
+sample = new DataView(buffer, 4, 4);
+assert.throws(RangeError, function() {
+  sample.setUint32(1, 39);
+}, "1 + 4 > 4 (offset+length)");
+
+sample = new DataView(buffer, 4, 3);
+assert.throws(RangeError, function() {
+  sample.setUint32(0, 39);
+}, "0 + 4 > 3 (offset+length)");
+
+sample = new DataView(buffer, 0);
+assert.sameValue(sample.getUint32(0), 0, "[0] no value was set");
+assert.sameValue(sample.getUint32(4), 0, "[1] no value was set");
+assert.sameValue(sample.getUint32(8), 0, "[2] no value was set");
diff --git a/test/built-ins/DataView/prototype/setUint32/index-to-integer.js b/test/built-ins/DataView/prototype/setUint32/index-to-integer.js
index a3fabfdc75..81488f4337 100755
--- a/test/built-ins/DataView/prototype/setUint32/index-to-integer.js
+++ b/test/built-ins/DataView/prototype/setUint32/index-to-integer.js
@@ -17,7 +17,7 @@ info: >
     ...
 ---*/
 
-var dataView = new DataView(new ArrayBuffer(8));
+var dataView = new DataView(new ArrayBuffer(8), 0);
 
 dataView.setUint32(+0, 1);
 assert.sameValue(dataView.getUint32(0), 1, "setUint32(+0, 1)");
diff --git a/test/built-ins/DataView/prototype/setUint32/no-value-arg.js b/test/built-ins/DataView/prototype/setUint32/no-value-arg.js
new file mode 100644
index 0000000000..bbea0ef9e9
--- /dev/null
+++ b/test/built-ins/DataView/prototype/setUint32/no-value-arg.js
@@ -0,0 +1,39 @@
+// Copyright (C) 2016 the V8 project authors. All rights reserved.
+// This code is governed by the BSD license found in the LICENSE file.
+
+/*---
+esid: sec-dataview.prototype.setuint32
+es6id: 24.2.4.20
+description: >
+  Set value as undefined (cast to 0) when value argument is not present
+info: |
+  24.2.4.20 DataView.prototype.setUint32 ( byteOffset, value [ , littleEndian ] )
+
+  1. Let v be the this value.
+  2. If littleEndian is not present, let littleEndian be false.
+  3. Return ? SetViewValue(v, byteOffset, littleEndian, "Uint32", value).
+
+  24.2.1.2 SetViewValue ( view, requestIndex, isLittleEndian, type, value )
+
+  ...
+  15. Let bufferIndex be getIndex + viewOffset.
+  16. Return SetValueInBuffer(buffer, bufferIndex, type, numberValue, isLittleEndian).
+
+  24.1.1.6 SetValueInBuffer ( arrayBuffer, byteIndex, type, value [ , isLittleEndian ] )
+
+  ...
+  11. Store the individual bytes of rawBytes into block, in order, starting at
+  block[byteIndex].
+  12. Return NormalCompletion(undefined).
+features: [DataView.prototype.getUint32]
+---*/
+
+var buffer = new ArrayBuffer(8);
+var sample = new DataView(buffer, 0);
+
+sample.setUint32(0, 42);
+
+var result = sample.setUint32(0);
+
+assert.sameValue(sample.getUint32(0), 0);
+assert.sameValue(result, undefined);
diff --git a/test/built-ins/DataView/prototype/setUint32/range-check-after-value-conversion.js b/test/built-ins/DataView/prototype/setUint32/range-check-after-value-conversion.js
index 09effdc332..be32633578 100755
--- a/test/built-ins/DataView/prototype/setUint32/range-check-after-value-conversion.js
+++ b/test/built-ins/DataView/prototype/setUint32/range-check-after-value-conversion.js
@@ -22,28 +22,26 @@ info: >
     ...
 ---*/
 
-var dataView = new DataView(new ArrayBuffer(8));
-
-function DummyError() { }
+var dataView = new DataView(new ArrayBuffer(8), 0);
 
 var poisoned = {
   valueOf: function() {
-    throw new DummyError();
+    throw new Test262Error();
   }
 };
 
-assert.throws(DummyError, function() {
+assert.throws(Test262Error, function() {
   dataView.setUint32(Infinity, poisoned);
 }, "setUint32(Infinity, poisoned)");
 
-assert.throws(DummyError, function() {
+assert.throws(Test262Error, function() {
   dataView.setUint32(100, poisoned);
 }, "setUint32(100, poisoned)");
 
-assert.throws(DummyError, function() {
+assert.throws(Test262Error, function() {
   dataView.setUint32('Infinity', poisoned);
 }, "setUint32('Infinity', poisoned)");
 
-assert.throws(DummyError, function() {
+assert.throws(Test262Error, function() {
   dataView.setUint32('100', poisoned);
 }, "setUint32('100', poisoned)");
diff --git a/test/built-ins/DataView/prototype/setUint32/return-abrupt-from-tonumber-byteoffset-symbol.js b/test/built-ins/DataView/prototype/setUint32/return-abrupt-from-tonumber-byteoffset-symbol.js
new file mode 100644
index 0000000000..7cdf17a575
--- /dev/null
+++ b/test/built-ins/DataView/prototype/setUint32/return-abrupt-from-tonumber-byteoffset-symbol.js
@@ -0,0 +1,31 @@
+// Copyright (C) 2016 the V8 project authors. All rights reserved.
+// This code is governed by the BSD license found in the LICENSE file.
+
+/*---
+esid: sec-dataview.prototype.setuint32
+es6id: 24.2.4.20
+description: >
+  Return abrupt from ToNumber(symbol byteOffset)
+info: |
+  24.2.4.20 DataView.prototype.setUint32 ( byteOffset, value [ , littleEndian ] )
+
+  1. Let v be the this value.
+  2. If littleEndian is not present, let littleEndian be false.
+  3. Return ? SetViewValue(v, byteOffset, littleEndian, "Uint32", value).
+
+  24.2.1.2 SetViewValue ( view, requestIndex, isLittleEndian, type, value )
+
+  ...
+  4. Let numberIndex be ? ToNumber(requestIndex).
+  ...
+features: [Symbol]
+---*/
+
+var buffer = new ArrayBuffer(1);
+var sample = new DataView(buffer, 0);
+
+var s = Symbol("1");
+
+assert.throws(TypeError, function() {
+  sample.setUint32(s, 1);
+});
diff --git a/test/built-ins/DataView/prototype/setUint32/return-abrupt-from-tonumber-byteoffset.js b/test/built-ins/DataView/prototype/setUint32/return-abrupt-from-tonumber-byteoffset.js
new file mode 100644
index 0000000000..eacf7a56f4
--- /dev/null
+++ b/test/built-ins/DataView/prototype/setUint32/return-abrupt-from-tonumber-byteoffset.js
@@ -0,0 +1,44 @@
+// Copyright (C) 2016 the V8 project authors. All rights reserved.
+// This code is governed by the BSD license found in the LICENSE file.
+
+/*---
+esid: sec-dataview.prototype.setuint32
+es6id: 24.2.4.20
+description: >
+  Return abrupt from ToNumber(byteOffset)
+info: |
+  24.2.4.20 DataView.prototype.setUint32 ( byteOffset, value [ , littleEndian ] )
+
+  1. Let v be the this value.
+  2. If littleEndian is not present, let littleEndian be false.
+  3. Return ? SetViewValue(v, byteOffset, littleEndian, "Uint32", value).
+
+  24.2.1.2 SetViewValue ( view, requestIndex, isLittleEndian, type, value )
+
+  ...
+  4. Let numberIndex be ? ToNumber(requestIndex).
+  ...
+---*/
+
+var buffer = new ArrayBuffer(1);
+var sample = new DataView(buffer, 0);
+
+var bo1 = {
+  valueOf: function() {
+    throw new Test262Error();
+  }
+};
+
+var bo2 = {
+  toString: function() {
+    throw new Test262Error();
+  }
+};
+
+assert.throws(Test262Error, function() {
+  sample.setUint32(bo1, 1);
+}, "valueOf");
+
+assert.throws(Test262Error, function() {
+  sample.setUint32(bo2, 1);
+}, "toString");
diff --git a/test/built-ins/DataView/prototype/setUint32/return-abrupt-from-tonumber-value-symbol.js b/test/built-ins/DataView/prototype/setUint32/return-abrupt-from-tonumber-value-symbol.js
new file mode 100644
index 0000000000..2fd42656f5
--- /dev/null
+++ b/test/built-ins/DataView/prototype/setUint32/return-abrupt-from-tonumber-value-symbol.js
@@ -0,0 +1,31 @@
+// Copyright (C) 2016 the V8 project authors. All rights reserved.
+// This code is governed by the BSD license found in the LICENSE file.
+
+/*---
+esid: sec-dataview.prototype.setuint32
+es6id: 24.2.4.20
+description: >
+  Return abrupt from ToNumber(symbol value)
+info: |
+  24.2.4.20 DataView.prototype.setUint32 ( byteOffset, value [ , littleEndian ] )
+
+  1. Let v be the this value.
+  2. If littleEndian is not present, let littleEndian be false.
+  3. Return ? SetViewValue(v, byteOffset, littleEndian, "Uint32", value).
+
+  24.2.1.2 SetViewValue ( view, requestIndex, isLittleEndian, type, value )
+
+  ...
+  7. Let numberValue be ? ToNumber(value).
+  ...
+features: [Symbol]
+---*/
+
+var buffer = new ArrayBuffer(8);
+var sample = new DataView(buffer, 0);
+
+var s = Symbol("1");
+
+assert.throws(TypeError, function() {
+  sample.setUint32(0, s);
+});
diff --git a/test/built-ins/DataView/prototype/setUint32/return-abrupt-from-tonumber-value.js b/test/built-ins/DataView/prototype/setUint32/return-abrupt-from-tonumber-value.js
new file mode 100644
index 0000000000..9d350b5118
--- /dev/null
+++ b/test/built-ins/DataView/prototype/setUint32/return-abrupt-from-tonumber-value.js
@@ -0,0 +1,44 @@
+// Copyright (C) 2016 the V8 project authors. All rights reserved.
+// This code is governed by the BSD license found in the LICENSE file.
+
+/*---
+esid: sec-dataview.prototype.setuint32
+es6id: 24.2.4.20
+description: >
+  Return abrupt from ToNumber(value)
+info: |
+  24.2.4.20 DataView.prototype.setUint32 ( byteOffset, value [ , littleEndian ] )
+
+  1. Let v be the this value.
+  2. If littleEndian is not present, let littleEndian be false.
+  3. Return ? SetViewValue(v, byteOffset, littleEndian, "Uint32", value).
+
+  24.2.1.2 SetViewValue ( view, requestIndex, isLittleEndian, type, value )
+
+  ...
+  7. Let numberValue be ? ToNumber(value).
+  ...
+---*/
+
+var buffer = new ArrayBuffer(8);
+var sample = new DataView(buffer, 0);
+
+var bo1 = {
+  valueOf: function() {
+    throw new Test262Error();
+  }
+};
+
+var bo2 = {
+  toString: function() {
+    throw new Test262Error();
+  }
+};
+
+assert.throws(Test262Error, function() {
+  sample.setUint32(0, bo1);
+}, "valueOf");
+
+assert.throws(Test262Error, function() {
+  sample.setUint32(0, bo2);
+}, "toString");
diff --git a/test/built-ins/DataView/prototype/setUint32/set-values-little-endian-order.js b/test/built-ins/DataView/prototype/setUint32/set-values-little-endian-order.js
new file mode 100644
index 0000000000..264f065578
--- /dev/null
+++ b/test/built-ins/DataView/prototype/setUint32/set-values-little-endian-order.js
@@ -0,0 +1,58 @@
+// Copyright (C) 2016 the V8 project authors. All rights reserved.
+// This code is governed by the BSD license found in the LICENSE file.
+
+/*---
+esid: sec-dataview.prototype.setuint32
+es6id: 24.2.4.20
+description: >
+  Set values on the little endian order
+info: |
+  24.2.4.20 DataView.prototype.setUint32 ( byteOffset, value [ , littleEndian ] )
+
+  1. Let v be the this value.
+  2. If littleEndian is not present, let littleEndian be false.
+  3. Return ? SetViewValue(v, byteOffset, littleEndian, "Uint32", value).
+
+  24.2.1.2 SetViewValue ( view, requestIndex, isLittleEndian, type, value )
+
+  ...
+  15. Let bufferIndex be getIndex + viewOffset.
+  16. Return SetValueInBuffer(buffer, bufferIndex, type, numberValue, isLittleEndian).
+
+  24.1.1.6 SetValueInBuffer ( arrayBuffer, byteIndex, type, value [ , isLittleEndian ] )
+
+  ...
+  11. Store the individual bytes of rawBytes into block, in order, starting at
+  block[byteIndex].
+  12. Return NormalCompletion(undefined).
+features: [DataView.prototype.getUint32]
+---*/
+
+var buffer = new ArrayBuffer(8);
+var sample = new DataView(buffer, 0);
+
+var result;
+
+result = sample.setUint32(0, -1870724872, true);
+assert.sameValue(result, undefined, "returns undefined #1");
+assert.sameValue(sample.getUint32(0), 4160782224);
+
+result = sample.setUint32(0, -134185072, true);
+assert.sameValue(result, undefined, "returns undefined #2");
+assert.sameValue(sample.getUint32(0), 2424242424);
+
+result = sample.setUint32(0, 1870724872, true);
+assert.sameValue(result, undefined, "returns undefined #3");
+assert.sameValue(sample.getUint32(0), 150962287);
+
+result = sample.setUint32(0, 150962287, true);
+assert.sameValue(result, undefined, "returns undefined #4");
+assert.sameValue(sample.getUint32(0), 1870724872);
+
+result = sample.setUint32(0, 4160782224, true);
+assert.sameValue(result, undefined, "returns undefined #5");
+assert.sameValue(sample.getUint32(0), 2424242424);
+
+result = sample.setUint32(0, 2424242424, true);
+assert.sameValue(result, undefined, "returns undefined #6");
+assert.sameValue(sample.getUint32(0), 4160782224);
diff --git a/test/built-ins/DataView/prototype/setUint32/set-values-return-undefined.js b/test/built-ins/DataView/prototype/setUint32/set-values-return-undefined.js
new file mode 100644
index 0000000000..a5ea2ed10f
--- /dev/null
+++ b/test/built-ins/DataView/prototype/setUint32/set-values-return-undefined.js
@@ -0,0 +1,53 @@
+// Copyright (C) 2016 the V8 project authors. All rights reserved.
+// This code is governed by the BSD license found in the LICENSE file.
+
+/*---
+esid: sec-dataview.prototype.setuint32
+es6id: 24.2.4.20
+description: >
+  Set values and return undefined
+info: |
+  24.2.4.20 DataView.prototype.setUint32 ( byteOffset, value [ , littleEndian ] )
+
+  1. Let v be the this value.
+  2. If littleEndian is not present, let littleEndian be false.
+  3. Return ? SetViewValue(v, byteOffset, littleEndian, "Uint32", value).
+
+  24.2.1.2 SetViewValue ( view, requestIndex, isLittleEndian, type, value )
+
+  ...
+  15. Let bufferIndex be getIndex + viewOffset.
+  16. Return SetValueInBuffer(buffer, bufferIndex, type, numberValue, isLittleEndian).
+
+  24.1.1.6 SetValueInBuffer ( arrayBuffer, byteIndex, type, value [ , isLittleEndian ] )
+
+  ...
+  11. Store the individual bytes of rawBytes into block, in order, starting at
+  block[byteIndex].
+  12. Return NormalCompletion(undefined).
+features: [DataView.prototype.getUint32]
+includes: [byteConversionValues.js]
+---*/
+
+var buffer = new ArrayBuffer(8);
+var sample = new DataView(buffer, 0);
+
+var values = byteConversionValues.values;
+var expectedValues = byteConversionValues.expected.Uint32;
+
+values.forEach(function(value, i) {
+  var expected = expectedValues[i];
+
+  var result = sample.setUint32(0, value, false);
+
+  assert.sameValue(
+    sample.getUint32(0),
+    expected,
+    "value: " + value
+  );
+  assert.sameValue(
+    result,
+    undefined,
+    "return is undefined, value: " + value
+  );
+});
diff --git a/test/built-ins/DataView/prototype/setUint32/this-has-no-dataview-internal.js b/test/built-ins/DataView/prototype/setUint32/this-has-no-dataview-internal.js
new file mode 100644
index 0000000000..6654c87eff
--- /dev/null
+++ b/test/built-ins/DataView/prototype/setUint32/this-has-no-dataview-internal.js
@@ -0,0 +1,43 @@
+// Copyright (C) 2016 the V8 project authors. All rights reserved.
+// This code is governed by the BSD license found in the LICENSE file.
+
+/*---
+esid: sec-dataview.prototype.setuint32
+es6id: 24.2.4.20
+description: >
+  Throws a TypeError if this does not have a [[DataView]] internal slot
+info: |
+  24.2.4.20 DataView.prototype.setUint32 ( byteOffset, value [ , littleEndian ] )
+
+  1. Let v be the this value.
+  2. If littleEndian is not present, let littleEndian be false.
+  3. Return ? SetViewValue(v, byteOffset, littleEndian, "Uint32", value).
+
+  24.2.1.2 SetViewValue ( view, requestIndex, isLittleEndian, type, value )
+
+  1. If Type(view) is not Object, throw a TypeError exception.
+  2. If view does not have a [[DataView]] internal slot, throw a TypeError
+  exception.
+  ...
+features: [Int8Array]
+---*/
+
+var setUint32 = DataView.prototype.setUint32;
+
+assert.throws(TypeError, function() {
+  setUint32.call({});
+}, "{}");
+
+assert.throws(TypeError, function() {
+  setUint32.call([]);
+}, "[]");
+
+var ab = new ArrayBuffer(1);
+assert.throws(TypeError, function() {
+  setUint32.call(ab);
+}, "ArrayBuffer");
+
+var ta = new Int8Array();
+assert.throws(TypeError, function() {
+  setUint32.call(ta);
+}, "TypedArray");
diff --git a/test/built-ins/DataView/prototype/setUint32/this-is-not-object.js b/test/built-ins/DataView/prototype/setUint32/this-is-not-object.js
new file mode 100644
index 0000000000..8709c37f41
--- /dev/null
+++ b/test/built-ins/DataView/prototype/setUint32/this-is-not-object.js
@@ -0,0 +1,51 @@
+// Copyright (C) 2016 the V8 project authors. All rights reserved.
+// This code is governed by the BSD license found in the LICENSE file.
+
+/*---
+esid: sec-dataview.prototype.setuint32
+es6id: 24.2.4.20
+description: Throws a TypeError if this is not Object
+info: |
+  24.2.4.20 DataView.prototype.setUint32 ( byteOffset, value [ , littleEndian ] )
+
+  1. Let v be the this value.
+  2. If littleEndian is not present, let littleEndian be false.
+  3. Return ? SetViewValue(v, byteOffset, littleEndian, "Uint32", value).
+
+  24.2.1.2 SetViewValue ( view, requestIndex, isLittleEndian, type, value )
+
+  1. If Type(view) is not Object, throw a TypeError exception.
+  ...
+features: [Symbol]
+---*/
+
+var setUint32 = DataView.prototype.setUint32;
+
+assert.throws(TypeError, function() {
+  setUint32.call(undefined);
+}, "undefined");
+
+assert.throws(TypeError, function() {
+  setUint32.call(null);
+}, "null");
+
+assert.throws(TypeError, function() {
+  setUint32.call(1);
+}, "1");
+
+assert.throws(TypeError, function() {
+  setUint32.call("string");
+}, "string");
+
+assert.throws(TypeError, function() {
+  setUint32.call(true);
+}, "true");
+
+assert.throws(TypeError, function() {
+  setUint32.call(false);
+}, "false");
+
+var s = Symbol("1");
+assert.throws(TypeError, function() {
+  setUint32.call(s);
+}, "symbol");
diff --git a/test/built-ins/DataView/prototype/setUint32/to-boolean-littleendian.js b/test/built-ins/DataView/prototype/setUint32/to-boolean-littleendian.js
new file mode 100644
index 0000000000..5ed4627e7f
--- /dev/null
+++ b/test/built-ins/DataView/prototype/setUint32/to-boolean-littleendian.js
@@ -0,0 +1,47 @@
+// Copyright (C) 2016 the V8 project authors. All rights reserved.
+// This code is governed by the BSD license found in the LICENSE file.
+
+/*---
+esid: sec-dataview.prototype.setuint32
+es6id: 24.2.4.20
+description: >
+  Boolean littleEndian argument coerced in ToBoolean
+info: |
+  24.2.4.20 DataView.prototype.setUint32 ( byteOffset, value [ , littleEndian ] )
+
+  1. Let v be the this value.
+  2. If littleEndian is not present, let littleEndian be false.
+  3. Return ? SetViewValue(v, byteOffset, littleEndian, "Uint32", value).
+
+  24.2.1.2 SetViewValue ( view, requestIndex, isLittleEndian, type, value )
+
+  ...
+  15. Let bufferIndex be getIndex + viewOffset.
+  16. Return SetValueInBuffer(buffer, bufferIndex, type, numberValue, isLittleEndian).
+features: [DataView.prototype.getUint32, Symbol]
+---*/
+
+var buffer = new ArrayBuffer(8);
+var sample = new DataView(buffer, 0);
+
+// False
+sample.setUint32(0, 1);
+assert.sameValue(sample.getUint32(0), 1, "no arg");
+sample.setUint32(0, 2, undefined);
+assert.sameValue(sample.getUint32(0), 2, "undefined");
+sample.setUint32(0, 3, null);
+assert.sameValue(sample.getUint32(0), 3, "null");
+sample.setUint32(0, 4, 0);
+assert.sameValue(sample.getUint32(0), 4, "0");
+sample.setUint32(0, 5, "");
+assert.sameValue(sample.getUint32(0), 5, "the empty string");
+
+// True
+sample.setUint32(0, 6, {});
+assert.sameValue(sample.getUint32(0), 100663296, "{}");
+sample.setUint32(0, 7, Symbol("1"));
+assert.sameValue(sample.getUint32(0), 117440512, "symbol");
+sample.setUint32(0, 8, 1);
+assert.sameValue(sample.getUint32(0), 134217728, "1");
+sample.setUint32(0, 9, "string");
+assert.sameValue(sample.getUint32(0), 150994944, "string");
-- 
GitLab