From d98f3f4d63c569a7a28dcc3e78085abe31dddfa3 Mon Sep 17 00:00:00 2001 From: Rick Waldron <waldron.rick@gmail.com> Date: Fri, 30 Nov 2018 09:37:16 -0500 Subject: [PATCH] Eliminate false positives: String.prototype.trimEnd, String.prototype.trimStart --- .../trimEnd/this-value-object-toprimitive-returns-object-err.js | 1 + .../trimEnd/this-value-object-tostring-returns-object-err.js | 1 + .../trimEnd/this-value-object-valueof-returns-object-err.js | 1 + .../this-value-object-toprimitive-returns-object-err.js | 1 + .../trimStart/this-value-object-tostring-returns-object-err.js | 1 + .../trimStart/this-value-object-valueof-returns-object-err.js | 1 + 6 files changed, 6 insertions(+) diff --git a/test/built-ins/String/prototype/trimEnd/this-value-object-toprimitive-returns-object-err.js b/test/built-ins/String/prototype/trimEnd/this-value-object-toprimitive-returns-object-err.js index a40d97ba89..a9c572b024 100644 --- a/test/built-ins/String/prototype/trimEnd/this-value-object-toprimitive-returns-object-err.js +++ b/test/built-ins/String/prototype/trimEnd/this-value-object-toprimitive-returns-object-err.js @@ -33,6 +33,7 @@ var thisVal = { }, }; +assert.sameValue(typeof String.prototype.trimEnd, 'function'); assert.throws(TypeError, function() { String.prototype.trimEnd.call(thisVal); }); diff --git a/test/built-ins/String/prototype/trimEnd/this-value-object-tostring-returns-object-err.js b/test/built-ins/String/prototype/trimEnd/this-value-object-tostring-returns-object-err.js index 2b4ed6006d..beb2296fe6 100644 --- a/test/built-ins/String/prototype/trimEnd/this-value-object-tostring-returns-object-err.js +++ b/test/built-ins/String/prototype/trimEnd/this-value-object-tostring-returns-object-err.js @@ -51,6 +51,7 @@ var thisVal = { }, }; +assert.sameValue(typeof String.prototype.trimEnd, 'function'); assert.throws(TypeError, function() { String.prototype.trimEnd.call(thisVal); }); diff --git a/test/built-ins/String/prototype/trimEnd/this-value-object-valueof-returns-object-err.js b/test/built-ins/String/prototype/trimEnd/this-value-object-valueof-returns-object-err.js index 20a8273150..36b182eeb5 100644 --- a/test/built-ins/String/prototype/trimEnd/this-value-object-valueof-returns-object-err.js +++ b/test/built-ins/String/prototype/trimEnd/this-value-object-valueof-returns-object-err.js @@ -52,6 +52,7 @@ var thisVal = { }, }; +assert.sameValue(typeof String.prototype.trimEnd, 'function'); assert.throws(TypeError, function() { String.prototype.trimEnd.call(thisVal); }); diff --git a/test/built-ins/String/prototype/trimStart/this-value-object-toprimitive-returns-object-err.js b/test/built-ins/String/prototype/trimStart/this-value-object-toprimitive-returns-object-err.js index a5e0bf976f..d24157432d 100644 --- a/test/built-ins/String/prototype/trimStart/this-value-object-toprimitive-returns-object-err.js +++ b/test/built-ins/String/prototype/trimStart/this-value-object-toprimitive-returns-object-err.js @@ -33,6 +33,7 @@ var thisVal = { }, }; +assert.sameValue(typeof String.prototype.trimStart, 'function'); assert.throws(TypeError, function() { String.prototype.trimStart.call(thisVal); }); diff --git a/test/built-ins/String/prototype/trimStart/this-value-object-tostring-returns-object-err.js b/test/built-ins/String/prototype/trimStart/this-value-object-tostring-returns-object-err.js index 30ee4c7511..9c4377a815 100644 --- a/test/built-ins/String/prototype/trimStart/this-value-object-tostring-returns-object-err.js +++ b/test/built-ins/String/prototype/trimStart/this-value-object-tostring-returns-object-err.js @@ -51,6 +51,7 @@ var thisVal = { }, }; +assert.sameValue(typeof String.prototype.trimStart, 'function'); assert.throws(TypeError, function() { String.prototype.trimStart.call(thisVal); }); diff --git a/test/built-ins/String/prototype/trimStart/this-value-object-valueof-returns-object-err.js b/test/built-ins/String/prototype/trimStart/this-value-object-valueof-returns-object-err.js index 85cced2dca..77c184aca5 100644 --- a/test/built-ins/String/prototype/trimStart/this-value-object-valueof-returns-object-err.js +++ b/test/built-ins/String/prototype/trimStart/this-value-object-valueof-returns-object-err.js @@ -52,6 +52,7 @@ var thisVal = { }, }; +assert.sameValue(typeof String.prototype.trimStart, 'function'); assert.throws(TypeError, function() { String.prototype.trimStart.call(thisVal); }); -- GitLab