From dcfcd17ae766f41700f96010708547ac0528c080 Mon Sep 17 00:00:00 2001 From: Daniel Ehrenberg <littledan@chromium.org> Date: Thu, 6 Apr 2017 23:51:46 +0200 Subject: [PATCH] Fix async generator test templates - Insert a missing .next() call - Avoid overlapping names used in test cases Case files like `src/dstr-binding/ary-ptrn-elem-ary-elision-init.case` are already setting bindings named `g`. Renaming them in the templates prevents overlapping names. --- .../default/async-gen-func-named-expr-dflt.template | 2 +- src/dstr-binding/default/async-gen-func-named-expr.template | 2 +- src/dstr-binding/default/cls-decl-async-gen-meth.template | 2 +- src/dstr-binding/error/async-gen-func-named-expr-dflt.template | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/dstr-binding/default/async-gen-func-named-expr-dflt.template b/src/dstr-binding/default/async-gen-func-named-expr-dflt.template index e7bec27226..fb3dbaf1f5 100644 --- a/src/dstr-binding/default/async-gen-func-named-expr-dflt.template +++ b/src/dstr-binding/default/async-gen-func-named-expr-dflt.template @@ -19,7 +19,7 @@ flags: [async] var callCount = 0; var f; -f = async function* g(/*{ elems }*/ = /*{ vals }*/) { +f = async function* h(/*{ elems }*/ = /*{ vals }*/) { /*{ body }*/ callCount = callCount + 1; }; diff --git a/src/dstr-binding/default/async-gen-func-named-expr.template b/src/dstr-binding/default/async-gen-func-named-expr.template index 8f064343b1..f96bba4096 100644 --- a/src/dstr-binding/default/async-gen-func-named-expr.template +++ b/src/dstr-binding/default/async-gen-func-named-expr.template @@ -19,7 +19,7 @@ flags: [async] var callCount = 0; var f; -f = async function* g(/*{ elems }*/) { +f = async function* h(/*{ elems }*/) { /*{ body }*/ callCount = callCount + 1; }; diff --git a/src/dstr-binding/default/cls-decl-async-gen-meth.template b/src/dstr-binding/default/cls-decl-async-gen-meth.template index d326b878c7..8ca3de418a 100644 --- a/src/dstr-binding/default/cls-decl-async-gen-meth.template +++ b/src/dstr-binding/default/cls-decl-async-gen-meth.template @@ -48,6 +48,6 @@ class C { } }; -new C().method(/*{ vals }*/).then(() => { +new C().method(/*{ vals }*/).next().then(() => { assert.sameValue(callCount, 1, 'invoked exactly once'); }).then($DONE, $DONE); diff --git a/src/dstr-binding/error/async-gen-func-named-expr-dflt.template b/src/dstr-binding/error/async-gen-func-named-expr-dflt.template index 8cb7da7808..d75f5e7197 100644 --- a/src/dstr-binding/error/async-gen-func-named-expr-dflt.template +++ b/src/dstr-binding/error/async-gen-func-named-expr-dflt.template @@ -17,7 +17,7 @@ info: | ---*/ var f; -f = async function* g(/*{ elems }*/ = /*{ vals }*/) { +f = async function* h(/*{ elems }*/ = /*{ vals }*/) { /*{ body }*/ }; -- GitLab