From e108edfd922493b4e4151e80f6453972e0a9d734 Mon Sep 17 00:00:00 2001 From: Pieter van Ginkel <pvginkel@gmail.com> Date: Sun, 14 Jun 2015 06:22:33 +0200 Subject: [PATCH] The Array.prototype.find function is an ES6 function. A number of Array.prototype.find tests were missing a feature specification. --- .../prototype/find/Array.prototype.find_empty-array-undefined.js | 1 + .../Array/prototype/find/Array.prototype.find_length-property.js | 1 + .../prototype/find/Array.prototype.find_modify-after-start.js | 1 + .../find/Array.prototype.find_non-returning-predicate.js | 1 + .../prototype/find/Array.prototype.find_noncallable-predicate.js | 1 + .../prototype/find/Array.prototype.find_predicate-arguments.js | 1 + .../prototype/find/Array.prototype.find_push-after-start.js | 1 + .../prototype/find/Array.prototype.find_remove-after-start.js | 1 + .../prototype/find/Array.prototype.find_return-found-value.js | 1 + .../Array/prototype/find/Array.prototype.find_this-defined.js | 1 + .../Array/prototype/find/Array.prototype.find_this-global.js | 1 + .../Array/prototype/find/Array.prototype.find_this-is-object.js | 1 + .../Array/prototype/find/Array.prototype.find_this-undefined.js | 1 + 13 files changed, 13 insertions(+) diff --git a/test/built-ins/Array/prototype/find/Array.prototype.find_empty-array-undefined.js b/test/built-ins/Array/prototype/find/Array.prototype.find_empty-array-undefined.js index 5a753b80c6..28edaf5ac4 100644 --- a/test/built-ins/Array/prototype/find/Array.prototype.find_empty-array-undefined.js +++ b/test/built-ins/Array/prototype/find/Array.prototype.find_empty-array-undefined.js @@ -3,6 +3,7 @@ /*--- description: Find on empty array should return undefined +features: [Array#find] ---*/ var a = [].find(function () { diff --git a/test/built-ins/Array/prototype/find/Array.prototype.find_length-property.js b/test/built-ins/Array/prototype/find/Array.prototype.find_length-property.js index 4fc9dde843..275f929225 100644 --- a/test/built-ins/Array/prototype/find/Array.prototype.find_length-property.js +++ b/test/built-ins/Array/prototype/find/Array.prototype.find_length-property.js @@ -3,6 +3,7 @@ /*--- description: The length property of the find method is 1 +features: [Array#find] ---*/ if ([].find.length !== 1) { diff --git a/test/built-ins/Array/prototype/find/Array.prototype.find_modify-after-start.js b/test/built-ins/Array/prototype/find/Array.prototype.find_modify-after-start.js index 568e67f0c9..1c64122e39 100644 --- a/test/built-ins/Array/prototype/find/Array.prototype.find_modify-after-start.js +++ b/test/built-ins/Array/prototype/find/Array.prototype.find_modify-after-start.js @@ -3,6 +3,7 @@ /*--- description: Array may be mutated by calls to the predicate +features: [Array#find] ---*/ [1, 2, 3].find(function (v, i, arr) { diff --git a/test/built-ins/Array/prototype/find/Array.prototype.find_non-returning-predicate.js b/test/built-ins/Array/prototype/find/Array.prototype.find_non-returning-predicate.js index df72d4a287..edbf75a232 100644 --- a/test/built-ins/Array/prototype/find/Array.prototype.find_non-returning-predicate.js +++ b/test/built-ins/Array/prototype/find/Array.prototype.find_non-returning-predicate.js @@ -3,6 +3,7 @@ /*--- description: Find with a predicate with no return value should return undefined +features: [Array#find] ---*/ var a = [1, 2, 3].find(function () {}); diff --git a/test/built-ins/Array/prototype/find/Array.prototype.find_noncallable-predicate.js b/test/built-ins/Array/prototype/find/Array.prototype.find_noncallable-predicate.js index 9479153c73..7c5109319f 100644 --- a/test/built-ins/Array/prototype/find/Array.prototype.find_noncallable-predicate.js +++ b/test/built-ins/Array/prototype/find/Array.prototype.find_noncallable-predicate.js @@ -6,6 +6,7 @@ description: > Array.prototype.find should throw a TypeError if IsCallable(predicate) is false includes: [runTestCase.js] +features: [Array#find] ---*/ var uncallableValues = [ diff --git a/test/built-ins/Array/prototype/find/Array.prototype.find_predicate-arguments.js b/test/built-ins/Array/prototype/find/Array.prototype.find_predicate-arguments.js index defde03255..6e3fe14306 100644 --- a/test/built-ins/Array/prototype/find/Array.prototype.find_predicate-arguments.js +++ b/test/built-ins/Array/prototype/find/Array.prototype.find_predicate-arguments.js @@ -5,6 +5,7 @@ description: > predicate is called with three arguments: the value of the element, the index of the element, and the object being traversed. +features: [Array#find] ---*/ var a = [1]; diff --git a/test/built-ins/Array/prototype/find/Array.prototype.find_push-after-start.js b/test/built-ins/Array/prototype/find/Array.prototype.find_push-after-start.js index b3ff10c5a8..2cf73cc532 100644 --- a/test/built-ins/Array/prototype/find/Array.prototype.find_push-after-start.js +++ b/test/built-ins/Array/prototype/find/Array.prototype.find_push-after-start.js @@ -5,6 +5,7 @@ description: > Elements added to array after find has been called should not be visited +features: [Array#find] ---*/ [1].find(function (v, i, arr) { diff --git a/test/built-ins/Array/prototype/find/Array.prototype.find_remove-after-start.js b/test/built-ins/Array/prototype/find/Array.prototype.find_remove-after-start.js index 509b8f50d8..bd4dca31e6 100644 --- a/test/built-ins/Array/prototype/find/Array.prototype.find_remove-after-start.js +++ b/test/built-ins/Array/prototype/find/Array.prototype.find_remove-after-start.js @@ -5,6 +5,7 @@ description: > Elements removed from array after find has been called should be visited +features: [Array#find] ---*/ var elementsVisited; diff --git a/test/built-ins/Array/prototype/find/Array.prototype.find_return-found-value.js b/test/built-ins/Array/prototype/find/Array.prototype.find_return-found-value.js index 2731a09b7f..31cbfcb0db 100644 --- a/test/built-ins/Array/prototype/find/Array.prototype.find_return-found-value.js +++ b/test/built-ins/Array/prototype/find/Array.prototype.find_return-found-value.js @@ -3,6 +3,7 @@ /*--- description: Find should return value if predicate returns true +features: [Array#find] ---*/ var testVals = [ diff --git a/test/built-ins/Array/prototype/find/Array.prototype.find_this-defined.js b/test/built-ins/Array/prototype/find/Array.prototype.find_this-defined.js index 6d25211d39..aaf6b05206 100644 --- a/test/built-ins/Array/prototype/find/Array.prototype.find_this-defined.js +++ b/test/built-ins/Array/prototype/find/Array.prototype.find_this-defined.js @@ -3,6 +3,7 @@ /*--- description: thisArg should be bound to this if provided +features: [Array#find] ---*/ var globalThis = this; diff --git a/test/built-ins/Array/prototype/find/Array.prototype.find_this-global.js b/test/built-ins/Array/prototype/find/Array.prototype.find_this-global.js index 7e94715481..174397e0ec 100644 --- a/test/built-ins/Array/prototype/find/Array.prototype.find_this-global.js +++ b/test/built-ins/Array/prototype/find/Array.prototype.find_this-global.js @@ -5,6 +5,7 @@ description: thisArg should be global object if not provided (not Strict mode) flags: [noStrict] includes: [fnGlobalObject.js] +features: [Array#find] ---*/ diff --git a/test/built-ins/Array/prototype/find/Array.prototype.find_this-is-object.js b/test/built-ins/Array/prototype/find/Array.prototype.find_this-is-object.js index d328a04735..5bde2b99df 100644 --- a/test/built-ins/Array/prototype/find/Array.prototype.find_this-is-object.js +++ b/test/built-ins/Array/prototype/find/Array.prototype.find_this-is-object.js @@ -4,6 +4,7 @@ /*--- description: Array.prototype.find should convert thisArg into an object flags: [noStrict] +features: [Array#find] ---*/ var dataTypes = [ diff --git a/test/built-ins/Array/prototype/find/Array.prototype.find_this-undefined.js b/test/built-ins/Array/prototype/find/Array.prototype.find_this-undefined.js index 2c3042a1b2..a8db0fa5f0 100644 --- a/test/built-ins/Array/prototype/find/Array.prototype.find_this-undefined.js +++ b/test/built-ins/Array/prototype/find/Array.prototype.find_this-undefined.js @@ -4,6 +4,7 @@ /*--- description: thisArg should be undefined if not provided (Strict mode) flags: [onlyStrict] +features: [Array#find] ---*/ -- GitLab