From e2ee94f4526210d5adfd640d85d0e9869609abb3 Mon Sep 17 00:00:00 2001 From: Daniel Ehrenberg <microdan@gmail.com> Date: Wed, 28 Jun 2017 16:29:47 +0200 Subject: [PATCH] Fix tests for toFixed and toExponential (#1080) toExponential had a typo, and toFixed was against an earlier version of the specification proposal. The tests pass against a version of V8 which attempts to implement the new spec. --- test/built-ins/Number/prototype/toExponential/range.js | 2 +- test/built-ins/Number/prototype/toFixed/range.js | 8 ++++---- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/test/built-ins/Number/prototype/toExponential/range.js b/test/built-ins/Number/prototype/toExponential/range.js index f7a27c029f..a90dec080a 100644 --- a/test/built-ins/Number/prototype/toExponential/range.js +++ b/test/built-ins/Number/prototype/toExponential/range.js @@ -13,7 +13,7 @@ info: > ---*/ assert.sameValue((3).toExponential(0), "3e+0"); -assert.throws(RangeError, () => (3).toExponential(0)); +assert.throws(RangeError, () => (3).toExponential(-1)); assert.sameValue((3).toExponential(100), "3.0000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000e+0"); assert.throws(RangeError, () => (3).toExponential(101)); diff --git a/test/built-ins/Number/prototype/toFixed/range.js b/test/built-ins/Number/prototype/toFixed/range.js index 9a9c004ffd..56c851880b 100644 --- a/test/built-ins/Number/prototype/toFixed/range.js +++ b/test/built-ins/Number/prototype/toFixed/range.js @@ -3,17 +3,17 @@ /*--- esid: sec-number.prototype.tofixed -description: Number.prototype.toFixed permits fractionDigits from -20 to 100 +description: Number.prototype.toFixed permits fractionDigits from 0 to 100 info: > Number.prototype.toFixed ( fractionDigits ) ... - 3. If _f_ < -20 or _f_ > 100, throw a *RangeError* exception. + 3. If _f_ < 0 or _f_ > 100, throw a *RangeError* exception. ... ---*/ -assert.sameValue((3).toFixed(-20), "0"); -assert.throws(RangeError, () => (3).toFixed(-21)); +assert.sameValue((3).toFixed(-0), "3"); +assert.throws(RangeError, () => (3).toFixed(-1)); assert.sameValue((3).toFixed(100), "3.0000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000"); assert.throws(RangeError, () => (3).toFixed(101)); -- GitLab