From ef5128a76ab74f941a7b75d404b7a0cdddf50a35 Mon Sep 17 00:00:00 2001
From: Nayeem Rahman <muhammed.rahman17@imperial.ac.uk>
Date: Wed, 30 Oct 2019 12:04:04 +0000
Subject: [PATCH] Add new linter rules
- no-var
- prefer-const
---
.eslintrc.json | 5 ++++-
src/app.js | 8 ++++----
src/room.js | 8 ++++----
src/y-webrtc/index.js | 2 +-
4 files changed, 13 insertions(+), 10 deletions(-)
diff --git a/.eslintrc.json b/.eslintrc.json
index 87e12f2..285f121 100644
--- a/.eslintrc.json
+++ b/.eslintrc.json
@@ -14,5 +14,8 @@
"ecmaVersion": 2018,
"sourceType": "module"
},
- "rules": {}
+ "rules": {
+ "no-var": "error",
+ "prefer-const": "error"
+ }
}
diff --git a/src/app.js b/src/app.js
index 8a881f8..7ff5946 100644
--- a/src/app.js
+++ b/src/app.js
@@ -91,10 +91,10 @@ HTML.rectangle.addEventListener("click", () => {
showElement(HTML.palette)
})
-let svg = HTML.wheel.children
-for (var i = 1; i < svg.length; i++) {
+const svg = HTML.wheel.children
+for (let i = 1; i < svg.length; i++) {
svg[i].addEventListener("click", (event) => {
- let paletteColour = event.target.getAttribute("fill")
+ const paletteColour = event.target.getAttribute("fill")
HTML.rectangle.style.backgroundColor = paletteColour
HTML.picker.value = paletteColour
HTML.labelColour.style.backgroundColor = paletteColour
@@ -112,7 +112,7 @@ function hideElement(element) {
}
HTML.picker.addEventListener("change", () => {
- let paletteColour = event.target.value
+ const paletteColour = event.target.value
HTML.rectangle.style.backgroundColor = paletteColour
HTML.labelColour.style.backgroundColor = paletteColour
canvas.setStrokeColour(paletteColour)
diff --git a/src/room.js b/src/room.js
index 08df894..b726ba5 100644
--- a/src/room.js
+++ b/src/room.js
@@ -34,9 +34,9 @@ class Room extends EventTarget {
}
getPaths() {
- let paths = new Map()
+ const paths = new Map()
- for (let id of this._y.share.strokeAdd.keys()) {
+ for (const id of this._y.share.strokeAdd.keys()) {
paths.set(id, this._generatePath(id))
}
@@ -55,13 +55,13 @@ class Room extends EventTarget {
// Generate an array of points [x, y, exist] by merging the path's add and erase sets
_generatePath(id) {
- let addSet = this._y.share.strokeAdd.get(id)
+ const addSet = this._y.share.strokeAdd.get(id)
if (addSet === undefined) {
return []
}
- let eraseSet = this._y.share.strokeErase.get(id) || { get: () => false }
+ const eraseSet = this._y.share.strokeErase.get(id) || { get: () => false }
return addSet
.toArray()
diff --git a/src/y-webrtc/index.js b/src/y-webrtc/index.js
index 4c5d4b9..d6e0d68 100644
--- a/src/y-webrtc/index.js
+++ b/src/y-webrtc/index.js
@@ -109,7 +109,7 @@ function extend(Y) {
return
}
- for (let f of this.userEventListeners) {
+ for (const f of this.userEventListeners) {
f({ action: "userID", id: id })
}
--
GitLab