Simple draw undo implementation (!64) · Merge requests · sweng-group-15 / drawing-app · GitLab

Snippets Groups Projects

Merged Momo Langenstein requested to merge easy-draw-undo into master 5 years ago

All threads resolved!

@mnr17 @gc4117 @im2517 Please review

Approval is optional

Activity

Nayeem Rahman @mnr17 started a thread on an old version of the diff 5 years ago

Resolved 5 years ago by Nayeem Rahman
Last reply by Nayeem Rahman 5 years ago

Momo Langenstein added 1 commit 5 years ago

added 1 commit

daa54aaf - (ml5717) Moved undo disabling to room.canUndo check

Compare with previous version

Nayeem Rahman resolved all threads 5 years ago

resolved all threads

Nayeem Rahman @mnr17 · 5 years ago

Maintainer

Resolved 5 years ago by Nayeem Rahman

LGTM

(Nit: I wouldn't use get/set unless as some kind of compatibility hack. If it abstracts code, make it a method.)

Edited 5 years ago by Nayeem Rahman
Last reply by Momo Langenstein 5 years ago

Iurii Maksymets @im2517 started a thread on an old version of the diff 5 years ago

Resolved 5 years ago by Iurii Maksymets

Iurii Maksymets @im2517 started a thread on an old version of the diff 5 years ago

Resolved 5 years ago by Iurii Maksymets

Momo Langenstein added 1 commit 5 years ago

added 1 commit

1515be88 - (ml5717) Addressed getter and css cleanup requests

Compare with previous version

Iurii Maksymets resolved all threads 5 years ago

resolved all threads

Iurii Maksymets @im2517 · 5 years ago

Maintainer

LGTM

Momo Langenstein merged 5 years ago

merged

Please register or sign in to reply