From 8745fd64caf3af8a2721270bf7040a87e38e5fd0 Mon Sep 17 00:00:00 2001
From: Kevin Jahns <kevin.jahns@rwth-aachen.de>
Date: Tue, 29 Sep 2015 13:59:38 +0200
Subject: [PATCH] code refactoring, and documentation
---
.travis.yml | 4 -
README.md | Bin 49 -> 7959 bytes
gulpfile.js | 4 +-
src/Connector.js | 46 ++++++-----
src/Notes.md | 12 +++
src/OperationStore.js | 137 +++++++++++++++----------------
src/OperationStores/IndexedDB.js | 2 +-
src/Types/Array.js | 5 +-
src/Types/Map.js | 10 ++-
src/Types/TextBind.js | 5 +-
src/y.js | 8 --
11 files changed, 116 insertions(+), 117 deletions(-)
create mode 100644 src/Notes.md
diff --git a/.travis.yml b/.travis.yml
index 45b66d72..7a150b62 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -1,12 +1,8 @@
language: node_js
before_install:
- "npm install -g bower"
- - "bower install"
node_js:
- "0.12"
- - "0.11"
- - "0.10"
branches:
only:
- master
- - 0.6
diff --git a/README.md b/README.md
index c618007beef4b8f73a1a3478a2d8555b404bb293..34b41376b98509aad02ca5e0a451204e5ee31004 100644
GIT binary patch
literal 7959
zcmbVRYjf1d70u`Q6%ACfGgBT7P)kzfESrEKyQc6$VN<)VDGK*UJ)Sm_TB~k(tc3jc
zoO4?mjcwLpm!iOy`f;D<o_jTVpzbYBFZ_q`I)rL}K5u6iK5_N=d}VXv=ecfO6Xq=*
z`pfglXtcPuc;47NQ^!GvrrYPSG1U6f`dMmaH;>uwiiiL9A{+}5l=VuhRjmuNarGy)
za<y_*u!Z%(rYd!1+SIiv)0RJn+T}`@nbJ*gh3;0Ya+?NK8}ITaSXV0i^=n<5Ol3M~
z723-9M4hb7&PBGUa#NTx@cz<l)SHu8Za<l8SL*!S)i$gPxwNX?rOk|29^&P?R;#8=
zd7;j2XqEPAam;I9`46&w@uo86f!mnnheT1=4VGZPJue|zaB2-z@|_!l(sG`s2D)Ba
zn75|ll=W&y86}dQn5(d-UU^sU$$h^Zy-w86Ms;#RuK+XER!5t8R~V(M3f6+<T<OKw
zVGR!q_NVolS}oRCT<LRjJ47Z49OoL9>Qbe((ZMK0i*lQ-(Z$}%Xm9gY%w8L~)$GYS
zZVMWAhWmo45dbADffL|&96^()WeYQ{Y-!7L72vhPX!+T#<k!x(@fxl-rEhA3cRDDG
zzg}I!CE1?ZtP#&*`nUw<XFwp5JmO2DYHTh|-MZ4Kjm>j~-^$SFJa2JorkV<m!#ZAz
z7?u4Kv9ivgeAaHQJ%k$VIvRaeKXJqF{qtG9Fg~p<a=?{1WcCOCsNcD5)Xv=U!XSx0
zt7jSP)>P024x@2vQ@BeBs>;;CBK+Y7I5F->)Pb$jhS>lw8)hn2APJOjs>;>DWQjT~
z)4a(L^R}cjMvE4y=EHyx=df|JOc3Y-MfivBClsg8<lL5@Z~~vJZSG1Oe}xFV(VH9^
zGVbrXcUZ;Sk93I~K*DeLGBab~NwhWIK%~+@eIM#34TwXp#wIyWBxa%_vI9}mr%gN#
z`C04o+|Zslzr!L}Tzf*qHtLZcNP;4v5?4ijm-KioMk{Zah*vO?Uc5OPr09|tD6w&X
zrdBO&nMuky^}Kc)Z)$Gn94%f8K%Beo=X(lp;PPBAT}^PH!SML&?&V4ZkM?_rm8uC_
z!|W*(h96IkUT>dtR-UdOP37gZnoek<+NSIOCuhIr3$pUn?-1A%J^-*Lvw&JZ8oe(C
zn;p!J0@2qs=)(fg<%CynAHRivy+?ErK!CIo%93z^uhIpzbPZww&ezIUCbcUmhegqp
z9e#6TaH-3$VQg1ZVMipc0gU-n!xw--CNt4@X%xa%l2HTQGBbqXPIbUOQ|j6}54=ZF
z=|o2=M1_&7Ul0YU4=o+;$#YyWJ#b}-tb=8yw*p{``GDiN2--R|1CZ!UEu=7Q>?f;+
zIz%>c3oF1mxNLsVc#wkGa3wPCK*&SLThxL<2d2UbA?h{^_utTDe>D1P0KX2}UyImC
zl&@WSV_k%Ts=6x|uZpT-e826&3tksgXT?QK{c`jcA=u=>&JYdtEM@Vmoh#IM@ypA%
zvxg7AeG-p{&3TqEJcJc0DM568Whz;etOHO-QV&e04(VM&#T8!`tHYefJ@#B$4K}lU
zcXB{=gSoq4@IB9c2Jq>_iDZ(`>E)`aE9c1r4}~G@@-Xl@R4`ywW^&znKqYLkMlu)x
zX{kU=QFKxbtluWZXdpqX0nEBIx8M%5ST$i%<jD+FF*8HtpBo`4$Pp@6Rz+OA1V^le
zRFHmb8Aavtwg8H3iv#t+P4`Bl6GX7iE_E5CKA}LP0QIbN3p%@XSV+lKCCQ!GbB%O<
zDZfW@#I<ENxM^JBR$%2IRm4S@e_tJd*|C%gH2@$09l$3d4MTnkI=K=*)KHg-DMaLU
zM~{)%g?dt(3unuC(X+CBUuJG!@n1F7WjpOybaW#*x4AND113Ue0&INX@#ry(8Us!H
zM!;l~c;sP;ASY8m?ie~!uz6qoyoPhwr7)iG_5|6mCv_DZw%dV1E4X%DcsYek=!9$=
ze=7|tCA0|~nZ+7Ri9&6zT@h`VsF!eWD<lF@DgBBQ@gT$6ZHR0_mko$kFUPLrl+^~n
z_~^j{^&Zh`!@Vtq2h9fK*meprAkCGgRiqCgST2ya-iF)V03h~XP0d<Y2*a1f5us69
zKG{34po8rRxCwZpS3Cd?LX5MqgUBEdAOKVl7M04?XBylnM&2n`(C#HjB+?+wN#><`
zKoG<V(w?;$CBV}4Ao+MKtbQShw?(;_hStp|LMU#nM!pXEY&M$&54yg&(&;B;BAZ|K
zM-O1==S=F++1c4h&fQ+#H_7tqg#M;_Hd17Xrra*k_mOF5wnp_tgsf@+GmYB`6)l7s
zmH{~Ar0-(WpnRP^y`RkG&X4RIVGT67lx*H67ykbD-_7IF?`5CJ`cqZNFHoqzL16>R
zlh>Cfu6u?!p#xw%VK`lVMsqa9w&}jCI#o|$@n0LrJ-&|<?oa;S-J(v%lhGmCh8iN1
z*7Wp~5X+2Ag$SR<F0nMoRxDcMdPHZ(5EvC*qcYyzqzBALK+>i|ui0PI_YvDRZO|f$
zehCiWLVV5wPRHGiuI?2WJy55~k*?y<B6^GY0q01(VaCw)tr|rYEQa2a9g?_Gb_yVL
z%JPDx2C7-<deKd(3w^0O2fmR`Y^WJgfjfFKX~{scZ`^k+FZ&E~ODRlSY=uF^k8Ej3
z-R@ZT>ZXX8XRtM1bOLur4;hl7nB@*2pA_!j=&f~R5asOs@jP>>pQE_XdFrvWyYqK_
z|2Y34cT1grj0gL9{D0nEFoA8sVqYE{J&POF--JRt4;qe!AM_mn%MgWY5JF3XEP!%p
zYAV(M3>RoBvObFm1gi6UfPKz~2peFj#9Tj**j5M0xQL<5?yayW83!^2kvL}%6}mzg
zwTU-jd>_&D5fAQz|1)|f39lLVgQGECP5v`dvS&W0;6*FH&>^G$cELC8D!^{cpK>wm
z5QCC1b3K4LL_?|Do{)fhAOn?}LiPZ3VPXLbSy_j^{#r0-b<5{0kUXfwXye9VG%Cg}
zjij;e&&2@fF!rAD9fg*J02&jV(J*5WCCf4LGd!Pm<N15>xOmO63G>Kb<6_F(CR`5A
zW`fy~=!HDkS;kde@Ql0v>v-x3WIpR3ozbFQ<H9-&3xQN2c3_lP@WnbVPD;80Pq<;P
z4Caw#Xhf$`Nc_ZhYZ`@{#<7y8AWhkevWhbF;u6{-YefA3jYSVA&GW!5svR~m5;6ij
zM&*nM(V1r+uap?~96)srmicL%rAj-rMXsm_a#?}_)XSowJm|O=@FBCT&!{2&Nm7`c
z^r%3|ID8c(FdDfhjW0{!jtWAxSc@>l1RXSDh#?-|j6V-i_*qEU^%#3Iek4!77#aP`
zsP|4BbT6J^;t6_5ZjU&@a2fr&@C&J_8fGSIpd}?auJ0<lrs=M2Y7Dt<2WRx|DXM7Z
zP|DfTW1L%h5*&qopUFHN+ch1auw3}tc4huPL#S-E=$CeA-0L$euq$R-&qtZ1*TN!+
zS|iqp20N`z=Pwi5eFYC~@A-TWlluqVmw;h}FVlMvGkEeGaf&|c#Wrwoxb%$u7;4(i
zrUNl!JQWx}QE@pXIJh59Nz^N}^eO{FVORneN=E^GSf%QQ!~yt@ZvqX*8yr&rmw!Nq
zwKjRh4heixx(&kr3W$ecJI1xfAq+{0@loRkR)BgaSxcRvM@hgN@i?)?{1y6)KR<qm
zbO`b(WLP?^=?UFGnoxZ7C>*JIDhK_A4+?ZZO|kPJ1+~_g?>(*RnJk;2YB{k01sCNc
zouFk+b3(bUPek;9Q*uSEer?#;0^y<e+Z+=!jB!A9>!3cO2l@ys^H{+GNS9MnOjzU7
zuNbJr-IIIj5cZWay0TY1sZi33c*l<pa0SS<w~#PeKf*@t&dDm_jYr8tI0CRLupc7|
zIar$wzN$!}pl}b9Cp?uQ!U#diB<dK1IJVU|g8_^a`n#x<1d8@;nF4-G*LdM!1brUF
z***dXv;HLvgQ_mH0P`#c3L6fIq;90eDsl{qr|ZZ$y(u6~FA<<0@83mEyHlxdPFNB8
zro6NehJ#!TC;eaPJQg+1{Z<&?L6DB-$Kf0Djp`Tr0)725PF&GGs5f|8Z?I8fLFfoH
z?mGmih`9hh)a8)tG>PO$`og6_GXbOq>I->})PRe?JkSL97;u)L77I|SMOS1$Oi=ww
zwbGXm1wJ^tRfW%_pq&lX|4gpu$-576|BaF^VM0B32tX>MI^h90<peJewnLlv<wp?O
z=k|Qf_9sf7sqx`AFj~h0cqV&HmIfYiLJm9ZMqQMO6UYO*1NJzZBzp8l?IRIqVeloV
z?>qv0pi2i@z%;wJ9mh`_^8KuzhsF+&M8UTRzXGFR;t})$*;>kX$<bj~s^OjMU){2%
z=1y?GC2A;GGdiR-J`^I}P&J?%<hSA&>V#1Sh)D`SLyA06i?Mw&iNJ(WUADA7sW)Lg
z(>$sKKboh7M@#$e=aV17b*-ct$WxbNFHCBRB~E<&@X@#G@S9?H#KH0<69*0~7#I-I
z2Yk!ntOAn|Y`bvFUP}8U!oX|9dI>Ve-OvFa9QiBS$5MJf=(9LFJW<`U594J1`tac8
oPscBlfbR!5<Gc34|MLr)e2-7j{U_Fa#gErFCc=LGr$7GZf8ZXQ-T(jq
delta 27
gcmbPkXUL_j5Sdl1V4!ElH91F0o&&`3*URSu0AS|^)Bpeg
diff --git a/gulpfile.js b/gulpfile.js
index 317ac0a8..5e02ceab 100644
--- a/gulpfile.js
+++ b/gulpfile.js
@@ -28,8 +28,8 @@
Specify which specs to use!
Commands:
- - build
- Build this library
+ - build:deploy
+ Build this library for deployment (es6->es5, minified)
- dev:browser
Watch the ./src directory.
Builds the library on changes.
diff --git a/src/Connector.js b/src/Connector.js
index 017b1156..88ca708d 100644
--- a/src/Connector.js
+++ b/src/Connector.js
@@ -130,7 +130,7 @@ class AbstractConnector {
}
send (uid, message) {
if (this.debug) {
- console.log(`send ${this.userId} -> ${uid}: ${message.type}`, m);// eslint-disable-line
+ console.log(`send ${this.userId} -> ${uid}: ${message.type}`, m) // eslint-disable-line
}
}
/*
@@ -141,7 +141,7 @@ class AbstractConnector {
return
}
if (this.debug) {
- console.log(`receive ${sender} -> ${this.userId}: ${m.type}`, m);// eslint-disable-line
+ console.log(`receive ${sender} -> ${this.userId}: ${m.type}`, m) // eslint-disable-line
}
if (m.type === 'sync step 1') {
// TODO: make transaction, stream the ops
@@ -212,17 +212,19 @@ class AbstractConnector {
this.y.db.apply(m.ops)
}
}
- // Currently, the HB encodes operations as JSON. For the moment I want to keep it
- // that way. Maybe we support encoding in the HB as XML in the future, but for now I don't want
- // too much overhead. Y is very likely to get changed a lot in the future
- //
- // Because we don't want to encode JSON as string (with character escaping, wich makes it pretty much unreadable)
- // we encode the JSON as XML.
- //
- // When the HB support encoding as XML, the format should look pretty much like this.
- //
- // does not support primitive values as array elements
- // expects an ltx (less than xml) object
+ /*
+ Currently, the HB encodes operations as JSON. For the moment I want to keep it
+ that way. Maybe we support encoding in the HB as XML in the future, but for now I don't want
+ too much overhead. Y is very likely to get changed a lot in the future
+
+ Because we don't want to encode JSON as string (with character escaping, wich makes it pretty much unreadable)
+ we encode the JSON as XML.
+
+ When the HB support encoding as XML, the format should look pretty much like this.
+
+ does not support primitive values as array elements
+ expects an ltx (less than xml) object
+ */
parseMessageFromXml (m) {
function parseArray (node) {
for (var n of node.children) {
@@ -256,14 +258,16 @@ class AbstractConnector {
}
parseObject(m)
}
- // encode message in xml
- // we use string because Strophe only accepts an "xml-string"..
- // So {a:4,b:{c:5}} will look like
- // <y a="4">
- // <b c="5"></b>
- // </y>
- // m - ltx element
- // json - Object
+ /*
+ encode message in xml
+ we use string because Strophe only accepts an "xml-string"..
+ So {a:4,b:{c:5}} will look like
+ <y a="4">
+ <b c="5"></b>
+ </y>
+ m - ltx element
+ json - Object
+ */
encodeMessageToXml (msg, obj) {
// attributes is optional
function encodeObject (m, json) {
diff --git a/src/Notes.md b/src/Notes.md
new file mode 100644
index 00000000..f9d2236e
--- /dev/null
+++ b/src/Notes.md
@@ -0,0 +1,12 @@
+
+# Notes
+
+### Terminology
+
+* DB: DataBase that holds all the information of the shared object. It is devided into the OS, DS, and SS. This can be a persistent database or an in-memory database. Depending on the type of database, it could make sense to store OS, DS, and SS in different tables, or maybe different databases.
+* OS: OperationStore holds all the operations. An operation is a js object with a fixed number of name fields.
+* DS: DeleteStore holds the information about which operations are deleted and which operations were garbage collected (no longer available in the OS).
+* SS: StateSet holds the current state of the OS. SS.getState(username) refers to the amount of operations that were received by that respective user.
+* Op: Operation defines an action on a shared type. But it is also the format in which we store the model of a type. This is why it is also called a Struct/Structure.
+* Type and Structure: We crearly distinguish between type and structure. Short explanation: A type (e.g. Strings, Numbers) have a number of functions that you can apply on them. (+) is well defined on both of them. They are *modeled* by a structure - the functions really change the structure of a type. Types can be implemented differently but still provide the same functionality. In Yjs, almost all types are realized as a doubly linked list (on which Yjs can provide eventual convergence)
+*
\ No newline at end of file
diff --git a/src/OperationStore.js b/src/OperationStore.js
index 6bbba9a3..37031f6a 100644
--- a/src/OperationStore.js
+++ b/src/OperationStore.js
@@ -3,6 +3,9 @@
/*
Partial definition of a transaction
+
+ A transaction provides all the the async functionality on a database.
+
By convention, a transaction has the following properties:
* ss for StateSet
* os for OperationStore
@@ -75,6 +78,10 @@ class AbstractTransaction {
constructor (store) {
this.store = store
}
+ /*
+ Get a type based on the id of its model.
+ If it does not exist yes, create it.
+ */
* getType (id) {
var sid = JSON.stringify(id)
var t = this.store.initializedTypes[sid]
@@ -87,12 +94,11 @@ class AbstractTransaction {
}
return t
}
- * createType (model) {
- var sid = JSON.stringify(model.id)
- var t = yield* Y[model.type].initType.call(this, this.store, model)
- this.store.initializedTypes[sid] = t
- return t
- }
+ /*
+ Apply operations that this user created (no remote ones!)
+ * does not check for Struct.*.requiredOps()
+ * also broadcasts it through the connector
+ */
* applyCreatedOperations (ops) {
var send = []
for (var i = 0; i < ops.length; i++) {
@@ -108,24 +114,13 @@ class AbstractTransaction {
}
}
/*
- Delete an operation from the OS, and add it to the GC, if necessary.
-
- Rulez:
- * The most left element in a list must not be deleted.
- => There is at least one element in the list
- * When an operation o is deleted, then it checks if its right operation
- can be gc'd (iff it's deleted)
+ Mark an operation as deleted, and add it to the GC, if possible.
*/
* deleteOperation (targetId) {
var target = yield* this.getOperation(targetId)
if (target == null || !target.deleted) {
this.ds.markDeleted(targetId)
- var state = yield* this.getState(targetId[0])
- if (state.clock === targetId[1]) {
- yield* this.checkDeleteStoreForState(state)
- yield* this.setState(state)
- }
}
if (target != null && target.gc == null) {
@@ -143,23 +138,16 @@ class AbstractTransaction {
var left = target.left != null ? yield* this.getOperation(target.left) : null
var right = target.right != null ? yield* this.getOperation(target.right) : null
- this.store.addToGarbageCollector(target, left, right)
+ this.store.addToGarbageCollector(target, left)
// set here because it was deleted and/or gc'd
yield* this.setOperation(target)
- if (
- left != null &&
- left.left != null &&
- this.store.addToGarbageCollector(left, yield* this.getOperation(left.left), target)
- ) {
- yield* this.setOperation(left)
- }
-
+ // check if it is possible to add right to the gc (this delete can't be responsible for left being gc'd)
if (
right != null &&
right.right != null &&
- this.store.addToGarbageCollector(right, target, yield* this.getOperation(right.right))
+ this.store.addToGarbageCollector(right, target)
) {
yield* this.setOperation(right)
}
@@ -176,31 +164,45 @@ class AbstractTransaction {
yield* this.deleteOperation(id)
o = yield* this.getOperation(id)
}
+
+ // check to increase the state of the respective user
+ var state = yield* this.getState(id[0])
+ if (state.clock === id[1]) {
+ // also check if more expected operations were gc'd
+ yield* this.checkDeleteStoreForState(state)
+ // then set the state
+ yield* this.setState(state)
+ }
+ // remove gc'd op from the left op, if it exists
if (o.left != null) {
var left = yield* this.getOperation(o.left)
left.right = o.right
yield* this.setOperation(left)
}
+ // remove gc'd op from the right op, if it exists
if (o.right != null) {
var right = yield* this.getOperation(o.right)
right.left = o.left
yield* this.setOperation(right)
}
+ // remove gc'd op from parent, if it exists
var parent = yield* this.getOperation(o.parent)
- var setParent = false
+ var setParent = false // whether to save parent to the os
if (Y.utils.compareIds(parent.start, o.id)) {
+ // gc'd op is the start
setParent = true
parent.start = o.right
}
if (Y.utils.compareIds(parent.end, o.id)) {
+ // gc'd op is the end
setParent = true
parent.end = o.left
}
if (setParent) {
yield* this.setOperation(parent)
}
- yield* this.removeOperation(o.id)
+ yield* this.removeOperation(o.id) // actually remove it from the os
yield* this.ds.markGarbageCollected(o.id)
}
}
@@ -272,10 +274,9 @@ class AbstractOperationStore {
var os = this.os
var self = this
os.iterate(null, null, function (op) {
- if (op.deleted && op.left != null && op.right != null) {
+ if (op.deleted && op.left != null) {
var left = os.find(op.left)
- var right = os.find(op.right)
- self.addToGarbageCollector(op, left, right)
+ self.addToGarbageCollector(op, left)
}
})
}
@@ -283,25 +284,21 @@ class AbstractOperationStore {
Try to add to GC.
TODO: rename this function
-
- Only gc when
- * creator of op is online
- * left & right defined and both are from the same creator as op
-
+
+ Rulez:
+ * Only gc if this user is online
+ * The most left element in a list must not be gc'd.
+ => There is at least one element in the list
+
returns true iff op was added to GC
*/
- addToGarbageCollector (op, left, right) {
+ addToGarbageCollector (op, left) {
if (
op.gc == null &&
op.deleted === true &&
this.y.connector.isSynced &&
- // (this.y.connector.connections[op.id[0]] != null || op.id[0] === this.y.connector.userId) &&
left != null &&
- right != null &&
left.deleted &&
- right.deleted &&
- left.id[0] === op.id[0] &&
- right.id[0] === op.id[0]
) {
op.gc = true
this.gc1.push(op.id)
@@ -343,23 +340,25 @@ class AbstractOperationStore {
}
return [this.userId, this.opClock++]
}
+ /*
+ Apply a list of operations.
+
+ * get a transaction
+ * check whether all Struct.*.requiredOps are in the OS
+ * check if it is an expected op (otherwise wait for it)
+ * check if was deleted, apply a delete operation after op was applied
+ */
apply (ops) {
for (var key in ops) {
var o = ops[key]
- if (o.gc == null) { // TODO: why do i get the same op twice?
- if (o.deleted == null) {
- var required = Y.Struct[o.struct].requiredOps(o)
- this.whenOperationsExist(required, o)
- } else {
- throw new Error('Ops must not contain deleted field!')
- }
- } else {
- throw new Error("Must not receive gc'd ops!")
- }
+ var required = Y.Struct[o.struct].requiredOps(o)
+ this.whenOperationsExist(required, o)
}
}
- // op is executed as soon as every operation requested is available.
- // Note that Transaction can (and should) buffer requests.
+ /*
+ op is executed as soon as every operation requested is available.
+ Note that Transaction can (and should) buffer requests.
+ */
whenOperationsExist (ids, op) {
if (ids.length > 0) {
let listener = {
@@ -390,7 +389,7 @@ class AbstractOperationStore {
this.listenersByIdRequestPending = true
var store = this
- this.requestTransaction(function *() {
+ this.requestTransaction(function * () {
var exeNow = store.listenersByIdExecuteNow
store.listenersByIdExecuteNow = []
@@ -421,6 +420,13 @@ class AbstractOperationStore {
}
})
}
+ /*
+ Actually execute an operation, when all expected operations are available.
+ If op is not yet expected, add it to the list of waiting operations.
+
+ This will also try to execute waiting operations
+ (ops that were not expected yet), after it was applied
+ */
* tryExecute (op) {
if (op.struct === 'Delete') {
yield* Y.Struct.Delete.execute.call(this, op)
@@ -439,6 +445,7 @@ class AbstractOperationStore {
yield* this.addOperation(op)
yield* this.store.operationAdded(this, op)
+ // Delete if DS says this is actually deleted
if (this.store.ds.isDeleted(op.id)) {
yield* Y.Struct['Delete'].execute.call(this, {struct: 'Delete', target: op.id})
}
@@ -479,21 +486,5 @@ class AbstractOperationStore {
yield* t._changed(transaction, Y.utils.copyObject(op))
}
}
- removeParentListener (id, f) {
- var ls = this.parentListeners[id]
- if (ls != null) {
- this.parentListeners[id] = ls.filter(function (g) {
- return (f !== g)
- })
- }
- }
- addParentListener (id, f) {
- var ls = this.parentListeners[JSON.stringify(id)]
- if (ls == null) {
- ls = []
- this.parentListeners[JSON.stringify(id)] = ls
- }
- ls.push(f)
- }
}
Y.AbstractOperationStore = AbstractOperationStore
diff --git a/src/OperationStores/IndexedDB.js b/src/OperationStores/IndexedDB.js
index f219779a..ca36f678 100644
--- a/src/OperationStores/IndexedDB.js
+++ b/src/OperationStores/IndexedDB.js
@@ -122,7 +122,7 @@ Y.IndexedDB = (function () { // eslint-disable-line
}
})()
- function handleTransactions (t) { // eslint-disable-line no-unused-vars
+ function handleTransactions (t) {
var request = t.value
if (t.done) {
return
diff --git a/src/Types/Array.js b/src/Types/Array.js
index f34e75a5..f2059343 100644
--- a/src/Types/Array.js
+++ b/src/Types/Array.js
@@ -167,15 +167,16 @@
Y.Array = new Y.utils.CustomType({
class: YArray,
createType: function * YArrayCreator () {
+ var modelid = this.store.getNextOpId()
var model = {
struct: 'List',
type: 'Array',
start: null,
end: null,
- id: this.store.getNextOpId()
+ id: modelid
}
yield* this.applyCreatedOperations([model])
- return yield* this.createType(model)
+ return modelid
},
initType: function * YArrayInitializer (os, model) {
var valArray = []
diff --git a/src/Types/Map.js b/src/Types/Map.js
index e2f73092..cb769b11 100644
--- a/src/Types/Map.js
+++ b/src/Types/Map.js
@@ -134,8 +134,9 @@
if (value instanceof Y.utils.CustomType) {
// construct a new type
this.os.requestTransaction(function *() {
- var type = yield* value.createType.call(this)
- insert.opContent = type._model
+ var typeid = yield* value.createType.call(this)
+ var type = yield* this.getType(typeid)
+ insert.opContent = typeid
insert.id = this.store.getNextOpId()
yield* this.applyCreatedOperations([insert])
resolve(type)
@@ -212,14 +213,15 @@
Y.Map = new Y.utils.CustomType({
class: YMap,
createType: function * YMapCreator () {
+ var modelid = this.store.getNextOpId()
var model = {
map: {},
struct: 'Map',
type: 'Map',
- id: this.store.getNextOpId()
+ id: modelid
}
yield* this.applyCreatedOperations([model])
- return yield* this.createType(model)
+ return modelid
},
initType: function * YMapInitializer (os, model) { // eslint-disable-line
return new YMap(os, model)
diff --git a/src/Types/TextBind.js b/src/Types/TextBind.js
index 77262bf0..37806177 100644
--- a/src/Types/TextBind.js
+++ b/src/Types/TextBind.js
@@ -267,15 +267,16 @@
Y.TextBind = new Y.utils.CustomType({
class: YTextBind,
createType: function * YTextBindCreator () {
+ var modelid = this.store.getNextOpId()
var model = {
start: null,
end: null,
struct: 'List',
type: 'TextBind',
- id: this.store.getNextOpId()
+ id: modelid
}
yield* this.applyCreatedOperations([model])
- return yield* this.createType(model)
+ return modelid
},
initType: function * YTextBindInitializer (os, model) {
var valArray = []
diff --git a/src/y.js b/src/y.js
index 81a3089b..0008f941 100644
--- a/src/y.js
+++ b/src/y.js
@@ -37,14 +37,6 @@ class YConfig {
}
reconnect () {
this.connector.reconnect()
- /* TODO: maybe do this..
- Promise.all([
- this.db.garbageCollect(),
- this.db.garbageCollect()
- ]).then(() => {
- this.connector.reconnect()
- })
- */
}
destroy () {
this.connector.disconnect()
--
GitLab