XNAT-4462: Empty values should now save. Really.

src/main/webapp/scripts/lib/form2js/src/form2js.js

@@ -258,7 +258,7 @@
     function extractNodeValues(node, nodeCallback, useIdIfEmptyName, getDisabled) {
         if (node.disabled && !getDisabled) return [];
 
-        var callbackResult, hasValue, fieldValue, result, fieldName = getFieldName(node, useIdIfEmptyName);
+        var callbackResult, fieldValue, result, fieldName = getFieldName(node, useIdIfEmptyName);
 
         callbackResult = nodeCallback && nodeCallback(node);
 
@@ -268,16 +268,14 @@
         else if (fieldName != '' && node.nodeName.match(/INPUT|TEXTAREA/i)) {
             fieldValue = getFieldValue(node, getDisabled);
 
-			hasValue = !!fieldValue;
-
 			// convert items with 'array-list' class to an actual array
-			if (hasValue && /array-list|list-array/i.test(node.className)) {
+			if (/array-list|list-array/i.test(node.className)) {
 				fieldValue = fieldValue.split(',').map(function(item, i){
 					return item.trim();
 				});
 			}
 
-            if (!hasValue) {
+			if (fieldValue === null) {
                 result = [];
             } else {
                 result = [ { name: fieldName, value: fieldValue} ];

src/main/webapp/scripts/xnat/admin/siteInfo.js

 // interractions with 'Site Info' section of admin ui
+
+console.log('siteInfo.js');
+
 (function(){
 
     var $container = $('[data-name="siteDescriptionType"]');

src/main/webapp/scripts/xnat/ui/panel.js

@@ -500,10 +500,12 @@ var XNAT = getObject(XNAT || {});
                 }
             };
 
+            var inputs = $form.find(':input').not('button, [type="submit"]').toArray();
+
             if (/json/i.test(opts.contentType||'')){
                 // ajaxConfig.data = JSON.stringify(formToJSON(this));
                 // ajaxConfig.data = JSON.stringify(form2js(this, /[:\[\]]/));
-                ajaxConfig.data = JSON.stringify(form2js(this, ':', false));
+                ajaxConfig.data = JSON.stringify(form2js(inputs, ':', false));
                 ajaxConfig.processData = false;
                 ajaxConfig.contentType = 'application/json';
                 $.ajax(ajaxConfig);