Skip to content
Snippets Groups Projects
Commit 03f0f569 authored by Rick Waldron's avatar Rick Waldron Committed by Leo Balter
Browse files

Promise.all/race with non-iterable or invalid return from Symbol.iterator. (#1496) 

Fixes gh-1490
parent 50dd1fbd
No related branches found
No related tags found
No related merge requests found
Hide whitespace changes
Inline Side-by-side
Showing
with 662 additions and 1 deletion
test/built-ins/Promise/all/iter-arg-is-false-reject.js 0 → 100644
+ 33
− 0
View file @ 03f0f569
// Copyright (C) 2018 Rick Waldron. All rights reserved.
// This code is governed by the BSD license found in the LICENSE file.
/*---
esid: sec-promise.all
description: >
Reject when argument is `false`
info: |
...
Let iteratorRecord be GetIterator(iterable).
IfAbruptRejectPromise(iteratorRecord, promiseCapability).
...
#sec-getiterator
GetIterator ( obj [ , hint [ , method ] ] )
...
Let iterator be ? Call(method, obj).
If Type(iterator) is not Object, throw a TypeError exception.
...
features: [Symbol.iterator]
flags: [async]
---*/
try {
Promise.all(false).then(function() {
$DONE('The promise should be rejected, but was resolved');
}, function(error) {
assert(error instanceof TypeError);
}).then($DONE, $DONE);
} catch (error) {
$DONE(`The promise should be rejected, but threw an exception: ${error.message}`);
}
test/built-ins/Promise/all/iter-arg-is-null-reject.js 0 → 100644
+ 33
− 0
View file @ 03f0f569
// Copyright (C) 2018 Rick Waldron. All rights reserved.
// This code is governed by the BSD license found in the LICENSE file.
/*---
esid: sec-promise.all
description: >
Reject when argument is `null`
info: |
...
Let iteratorRecord be GetIterator(iterable).
IfAbruptRejectPromise(iteratorRecord, promiseCapability).
...
#sec-getiterator
GetIterator ( obj [ , hint [ , method ] ] )
...
Let iterator be ? Call(method, obj).
If Type(iterator) is not Object, throw a TypeError exception.
...
features: [Symbol.iterator]
flags: [async]
---*/
try {
Promise.all(null).then(function() {
$DONE('The promise should be rejected, but was resolved');
}, function(error) {
assert(error instanceof TypeError);
}).then($DONE, $DONE);
} catch (error) {
$DONE(`The promise should be rejected, but threw an exception: ${error.message}`);
}
test/built-ins/Promise/all/iter-arg-is-number-reject.js 0 → 100644
+ 33
− 0
View file @ 03f0f569
// Copyright (C) 2018 Rick Waldron. All rights reserved.
// This code is governed by the BSD license found in the LICENSE file.
/*---
esid: sec-promise.all
description: >
Reject when argument is a number
info: |
...
Let iteratorRecord be GetIterator(iterable).
IfAbruptRejectPromise(iteratorRecord, promiseCapability).
...
#sec-getiterator
GetIterator ( obj [ , hint [ , method ] ] )
...
Let iterator be ? Call(method, obj).
If Type(iterator) is not Object, throw a TypeError exception.
...
features: [Symbol.iterator]
flags: [async]
---*/
try {
Promise.all(1).then(function() {
$DONE('The promise should be rejected, but was resolved');
}, function(error) {
assert(error instanceof TypeError);
}).then($DONE, $DONE);
} catch (error) {
$DONE(`The promise should be rejected, but threw an exception: ${error.message}`);
}
test/built-ins/Promise/all/iter-arg-is-string-resolve.js 0 → 100644
+ 33
− 0
View file @ 03f0f569
// Copyright (C) 2018 Rick Waldron. All rights reserved.
// This code is governed by the BSD license found in the LICENSE file.
/*---
esid: sec-promise.all
description: >
Reject when argument is a string
info: |
...
Let iteratorRecord be GetIterator(iterable).
IfAbruptRejectPromise(iteratorRecord, promiseCapability).
...
#sec-getiterator
GetIterator ( obj [ , hint [ , method ] ] )
...
Let iterator be ? Call(method, obj).
If Type(iterator) is not Object, throw a TypeError exception.
...
features: [Symbol.iterator]
flags: [async]
---*/
try {
Promise.all("").then(function() {
$DONE();
}, function() {
$DONE('The promise should be resolved, but was rejected');
}).then($DONE, $DONE);
} catch (error) {
$DONE(`The promise should be rejected, but threw an exception: ${error.message}`);
}
test/built-ins/Promise/all/iter-arg-is-symbol-reject.js 0 → 100644
+ 33
− 0
View file @ 03f0f569
// Copyright (C) 2018 Rick Waldron. All rights reserved.
// This code is governed by the BSD license found in the LICENSE file.
/*---
esid: sec-promise.all
description: >
Reject when argument is a symbol
info: |
...
Let iteratorRecord be GetIterator(iterable).
IfAbruptRejectPromise(iteratorRecord, promiseCapability).
...
#sec-getiterator
GetIterator ( obj [ , hint [ , method ] ] )
...
Let iterator be ? Call(method, obj).
If Type(iterator) is not Object, throw a TypeError exception.
...
features: [Symbol.iterator]
flags: [async]
---*/
try {
Promise.all(Symbol()).then(function() {
$DONE('The promise should be rejected, but was resolved');
}, function(error) {
assert(error instanceof TypeError);
}).then($DONE, $DONE);
} catch (error) {
$DONE(`The promise should be rejected, but threw an exception: ${error.message}`);
}
test/built-ins/Promise/all/iter-arg-is-true-reject.js 0 → 100644
+ 33
− 0
View file @ 03f0f569
// Copyright (C) 2018 Rick Waldron. All rights reserved.
// This code is governed by the BSD license found in the LICENSE file.
/*---
esid: sec-promise.all
description: >
Reject when argument is `true`
info: |
...
Let iteratorRecord be GetIterator(iterable).
IfAbruptRejectPromise(iteratorRecord, promiseCapability).
...
#sec-getiterator
GetIterator ( obj [ , hint [ , method ] ] )
...
Let iterator be ? Call(method, obj).
If Type(iterator) is not Object, throw a TypeError exception.
...
features: [Symbol.iterator]
flags: [async]
---*/
try {
Promise.all(true).then(function() {
$DONE('The promise should be rejected, but was resolved');
}, function(error) {
assert(error instanceof TypeError);
}).then($DONE, $DONE);
} catch (error) {
$DONE(`The promise should be rejected, but threw an exception: ${error.message}`);
}
test/built-ins/Promise/all/iter-arg-is-undefined-reject.js 0 → 100644
+ 33
− 0
View file @ 03f0f569
// Copyright (C) 2018 Rick Waldron. All rights reserved.
// This code is governed by the BSD license found in the LICENSE file.
/*---
esid: sec-promise.all
description: >
Reject when argument is `undefined`
info: |
...
Let iteratorRecord be GetIterator(iterable).
IfAbruptRejectPromise(iteratorRecord, promiseCapability).
...
#sec-getiterator
GetIterator ( obj [ , hint [ , method ] ] )
...
Let iterator be ? Call(method, obj).
If Type(iterator) is not Object, throw a TypeError exception.
...
features: [Symbol.iterator]
flags: [async]
---*/
try {
Promise.all(undefined).then(function() {
$DONE('The promise should be rejected, but was resolved');
}, function(error) {
assert(error instanceof TypeError);
}).then($DONE, $DONE);
} catch (error) {
$DONE(`The promise should be rejected, but threw an exception: ${error.message}`);
}
test/built-ins/Promise/all/iter-assigned-false-reject.js 0 → 100644
+ 35
− 0
View file @ 03f0f569
// Copyright (C) 2018 Rick Waldron. All rights reserved.
// This code is governed by the BSD license found in the LICENSE file.
/*---
esid: sec-promise.all
description: >
Reject when argument's Symbol.iterator property has the value false
info: |
...
Let iteratorRecord be GetIterator(iterable).
IfAbruptRejectPromise(iteratorRecord, promiseCapability).
...
#sec-getiterator
GetIterator ( obj [ , hint [ , method ] ] )
...
Let iterator be ? Call(method, obj).
If Type(iterator) is not Object, throw a TypeError exception.
...
features: [Symbol.iterator]
flags: [async]
---*/
try {
Promise.all({
[Symbol.iterator]: false
}).then(function() {
$DONE('The promise should be rejected, but was resolved');
}, function(error) {
assert(error instanceof TypeError);
}).then($DONE, $DONE);
} catch (error) {
$DONE(`The promise should be rejected, but threw an exception: ${error.message}`);
}
test/built-ins/Promise/all/iter-assigned-null-reject.js 0 → 100644
+ 35
− 0
View file @ 03f0f569
// Copyright (C) 2018 Rick Waldron. All rights reserved.
// This code is governed by the BSD license found in the LICENSE file.
/*---
esid: sec-promise.all
description: >
Reject when argument's Symbol.iterator property has the value null
info: |
...
Let iteratorRecord be GetIterator(iterable).
IfAbruptRejectPromise(iteratorRecord, promiseCapability).
...
#sec-getiterator
GetIterator ( obj [ , hint [ , method ] ] )
...
Let iterator be ? Call(method, obj).
If Type(iterator) is not Object, throw a TypeError exception.
...
features: [Symbol.iterator]
flags: [async]
---*/
try {
Promise.all({
[Symbol.iterator]: null
}).then(function() {
$DONE('The promise should be rejected, but was resolved');
}, function(error) {
assert(error instanceof TypeError);
}).then($DONE, $DONE);
} catch (error) {
$DONE(`The promise should be rejected, but threw an exception: ${error.message}`);
}
test/built-ins/Promise/all/iter-assigned-number-reject.js 0 → 100644
+ 35
− 0
View file @ 03f0f569
// Copyright (C) 2018 Rick Waldron. All rights reserved.
// This code is governed by the BSD license found in the LICENSE file.
/*---
esid: sec-promise.all
description: >
Reject when argument's Symbol.iterator property has the value 1
info: |
...
Let iteratorRecord be GetIterator(iterable).
IfAbruptRejectPromise(iteratorRecord, promiseCapability).
...
#sec-getiterator
GetIterator ( obj [ , hint [ , method ] ] )
...
Let iterator be ? Call(method, obj).
If Type(iterator) is not Object, throw a TypeError exception.
...
features: [Symbol.iterator]
flags: [async]
---*/
try {
Promise.all({
[Symbol.iterator]: 1
}).then(function() {
$DONE('The promise should be rejected, but was resolved');
}, function(error) {
assert(error instanceof TypeError);
}).then($DONE, $DONE);
} catch (error) {
$DONE(`The promise should be rejected, but threw an exception: ${error.message}`);
}
test/built-ins/Promise/all/iter-assigned-string-reject.js 0 → 100644
+ 35
− 0
View file @ 03f0f569
// Copyright (C) 2018 Rick Waldron. All rights reserved.
// This code is governed by the BSD license found in the LICENSE file.
/*---
esid: sec-promise.all
description: >
Reject when argument's Symbol.iterator property has the value ""
info: |
...
Let iteratorRecord be GetIterator(iterable).
IfAbruptRejectPromise(iteratorRecord, promiseCapability).
...
#sec-getiterator
GetIterator ( obj [ , hint [ , method ] ] )
...
Let iterator be ? Call(method, obj).
If Type(iterator) is not Object, throw a TypeError exception.
...
features: [Symbol.iterator]
flags: [async]
---*/
try {
Promise.all({
[Symbol.iterator]: ""
}).then(function() {
$DONE('The promise should be rejected, but was resolved');
}, function(error) {
assert(error instanceof TypeError);
}).then($DONE, $DONE);
} catch (error) {
$DONE(`The promise should be rejected, but threw an exception: ${error.message}`);
}
test/built-ins/Promise/all/iter-assigned-symbol-reject.js 0 → 100644
+ 35
− 0
View file @ 03f0f569
// Copyright (C) 2018 Rick Waldron. All rights reserved.
// This code is governed by the BSD license found in the LICENSE file.
/*---
esid: sec-promise.all
description: >
Reject when argument's Symbol.iterator property has the value Symbol()
info: |
...
Let iteratorRecord be GetIterator(iterable).
IfAbruptRejectPromise(iteratorRecord, promiseCapability).
...
#sec-getiterator
GetIterator ( obj [ , hint [ , method ] ] )
...
Let iterator be ? Call(method, obj).
If Type(iterator) is not Object, throw a TypeError exception.
...
features: [Symbol.iterator]
flags: [async]
---*/
try {
Promise.all({
[Symbol.iterator]: Symbol()
}).then(function() {
$DONE('The promise should be rejected, but was resolved');
}, function(error) {
assert(error instanceof TypeError);
}).then($DONE, $DONE);
} catch (error) {
$DONE(`The promise should be rejected, but threw an exception: ${error.message}`);
}
test/built-ins/Promise/all/iter-assigned-true-reject.js 0 → 100644
+ 35
− 0
View file @ 03f0f569
// Copyright (C) 2018 Rick Waldron. All rights reserved.
// This code is governed by the BSD license found in the LICENSE file.
/*---
esid: sec-promise.all
description: >
Reject when argument's Symbol.iterator property has the value true
info: |
...
Let iteratorRecord be GetIterator(iterable).
IfAbruptRejectPromise(iteratorRecord, promiseCapability).
...
#sec-getiterator
GetIterator ( obj [ , hint [ , method ] ] )
...
Let iterator be ? Call(method, obj).
If Type(iterator) is not Object, throw a TypeError exception.
...
features: [Symbol.iterator]
flags: [async]
---*/
try {
Promise.all({
[Symbol.iterator]: true
}).then(function() {
$DONE('The promise should be rejected, but was resolved');
}, function(error) {
assert(error instanceof TypeError);
}).then($DONE, $DONE);
} catch (error) {
$DONE(`The promise should be rejected, but threw an exception: ${error.message}`);
}
test/built-ins/Promise/all/iter-assigned-undefined-reject.js 0 → 100644
+ 35
− 0
View file @ 03f0f569
// Copyright (C) 2018 Rick Waldron. All rights reserved.
// This code is governed by the BSD license found in the LICENSE file.
/*---
esid: sec-promise.all
description: >
Reject when argument's Symbol.iterator property has the value undefined
info: |
...
Let iteratorRecord be GetIterator(iterable).
IfAbruptRejectPromise(iteratorRecord, promiseCapability).
...
#sec-getiterator
GetIterator ( obj [ , hint [ , method ] ] )
...
Let iterator be ? Call(method, obj).
If Type(iterator) is not Object, throw a TypeError exception.
...
features: [Symbol.iterator]
flags: [async]
---*/
try {
Promise.all({
[Symbol.iterator]: undefined
}).then(function() {
$DONE('The promise should be rejected, but was resolved');
}, function(error) {
assert(error instanceof TypeError);
}).then($DONE, $DONE);
} catch (error) {
$DONE(`The promise should be rejected, but threw an exception: ${error.message}`);
}
test/built-ins/Promise/all/iter-next-val-err-reject.js
+ 1
− 1
View file @ 03f0f569
......@@ -48,7 +48,7 @@ iterNextValThrows[Symbol.iterator] = function() {
};
Promise.all(iterNextValThrows).then(function() {
$ERROR('The promise should be rejected.');
$DONE('The promise should be rejected.');
}, function(reason) {
assert.sameValue(reason, error);
}).then($DONE, $DONE);
test/built-ins/Promise/all/iter-returns-false-reject.js 0 → 100644
+ 37
− 0
View file @ 03f0f569
// Copyright (C) 2018 Rick Waldron. All rights reserved.
// This code is governed by the BSD license found in the LICENSE file.
/*---
esid: sec-promise.all
description: >
Reject when argument's Symbol.iterator returns false
info: |
...
Let iteratorRecord be GetIterator(iterable).
IfAbruptRejectPromise(iteratorRecord, promiseCapability).
...
#sec-getiterator
GetIterator ( obj [ , hint [ , method ] ] )
...
Let iterator be ? Call(method, obj).
If Type(iterator) is not Object, throw a TypeError exception.
...
features: [Symbol.iterator]
flags: [async]
---*/
try {
Promise.all({
[Symbol.iterator]() {
return false;
}
}).then(function() {
$DONE('The promise should be rejected, but was resolved');
}, function(error) {
assert(error instanceof TypeError);
}).then($DONE, $DONE);
} catch (error) {
$DONE(`The promise should be rejected, but threw an exception: ${error.message}`);
}
test/built-ins/Promise/all/iter-returns-null-reject.js 0 → 100644
+ 37
− 0
View file @ 03f0f569
// Copyright (C) 2018 Rick Waldron. All rights reserved.
// This code is governed by the BSD license found in the LICENSE file.
/*---
esid: sec-promise.all
description: >
Reject when argument's Symbol.iterator returns null
info: |
...
Let iteratorRecord be GetIterator(iterable).
IfAbruptRejectPromise(iteratorRecord, promiseCapability).
...
#sec-getiterator
GetIterator ( obj [ , hint [ , method ] ] )
...
Let iterator be ? Call(method, obj).
If Type(iterator) is not Object, throw a TypeError exception.
...
features: [Symbol.iterator]
flags: [async]
---*/
try {
Promise.all({
[Symbol.iterator]() {
return null;
}
}).then(function() {
$DONE('The promise should be rejected, but was resolved');
}, function(error) {
assert(error instanceof TypeError);
}).then($DONE, $DONE);
} catch (error) {
$DONE(`The promise should be rejected, but threw an exception: ${error.message}`);
}
test/built-ins/Promise/all/iter-returns-number-reject.js 0 → 100644
+ 37
− 0
View file @ 03f0f569
// Copyright (C) 2018 Rick Waldron. All rights reserved.
// This code is governed by the BSD license found in the LICENSE file.
/*---
esid: sec-promise.all
description: >
Reject when argument's Symbol.iterator returns a number
info: |
...
Let iteratorRecord be GetIterator(iterable).
IfAbruptRejectPromise(iteratorRecord, promiseCapability).
...
#sec-getiterator
GetIterator ( obj [ , hint [ , method ] ] )
...
Let iterator be ? Call(method, obj).
If Type(iterator) is not Object, throw a TypeError exception.
...
features: [Symbol.iterator]
flags: [async]
---*/
try {
Promise.all({
[Symbol.iterator]() {
return 1;
}
}).then(function() {
$DONE('The promise should be rejected, but was resolved');
}, function(error) {
assert(error instanceof TypeError);
}).then($DONE, $DONE);
} catch (error) {
$DONE(`The promise should be rejected, but threw an exception: ${error.message}`);
}
test/built-ins/Promise/all/iter-returns-string-reject.js 0 → 100644
+ 37
− 0
View file @ 03f0f569
// Copyright (C) 2018 Rick Waldron. All rights reserved.
// This code is governed by the BSD license found in the LICENSE file.
/*---
esid: sec-promise.all
description: >
Reject when argument's Symbol.iterator returns a string
info: |
...
Let iteratorRecord be GetIterator(iterable).
IfAbruptRejectPromise(iteratorRecord, promiseCapability).
...
#sec-getiterator
GetIterator ( obj [ , hint [ , method ] ] )
...
Let iterator be ? Call(method, obj).
If Type(iterator) is not Object, throw a TypeError exception.
...
features: [Symbol.iterator]
flags: [async]
---*/
try {
Promise.all({
[Symbol.iterator]() {
return "";
}
}).then(function() {
$DONE('The promise should be rejected, but was resolved');
}, function(error) {
assert(error instanceof TypeError);
}).then($DONE, $DONE);
} catch (error) {
$DONE(`The promise should be rejected, but threw an exception: ${error.message}`);
}
test/built-ins/Promise/all/iter-returns-symbol-reject.js 0 → 100644
+ 37
− 0
View file @ 03f0f569
// Copyright (C) 2018 Rick Waldron. All rights reserved.
// This code is governed by the BSD license found in the LICENSE file.
/*---
esid: sec-promise.all
description: >
Reject when argument's Symbol.iterator returns a symbol
info: |
...
Let iteratorRecord be GetIterator(iterable).
IfAbruptRejectPromise(iteratorRecord, promiseCapability).
...
#sec-getiterator
GetIterator ( obj [ , hint [ , method ] ] )
...
Let iterator be ? Call(method, obj).
If Type(iterator) is not Object, throw a TypeError exception.
...
features: [Symbol.iterator]
flags: [async]
---*/
try {
Promise.all({
[Symbol.iterator]() {
return Symbol();
}
}).then(function() {
$DONE('The promise should be rejected, but was resolved');
}, function(error) {
assert(error instanceof TypeError);
}).then($DONE, $DONE);
} catch (error) {
$DONE(`The promise should be rejected, but threw an exception: ${error.message}`);
}
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment