Improve `for..of` control flow tests

- Expand ambiguous assertion messages and assert execution paths more
  finely.
- Improve variable names in `for..of` tests
  While the object created by a GeneratorFunction may be considered an
  "iterable", it is being used as an iterator in these tests. Naming the
  variable according to the way it is used improves the readability of
  the test body.
- Add 'features' attribute to test frontmatter
- Move tests
- Introduce additional `for..of` control flow tests

test/language/for-of/break-from-catch.js → test/language/statements/for-of/break-from-catch.js

@@ -5,25 +5,27 @@ es6id: 13.6.4.13 S5.n
 description: >
     Control flow during body evaluation should honor `break` statements within
     the `catch` block of `try` statements.
+features: [generators]
 ---*/
 
 function* values() {
   yield 1;
-  yield 1;
+  $ERROR('This code is unreachable (following `yield` statement).');
 }
-var iterable = values();
+var iterator = values();
 var i = 0;
 
-for (var x of iterable) {
-  i++;
+for (var x of iterator) {
 
   try {
     throw new Error();
   } catch (err) {
+    i++;
     break;
+    $ERROR('This code is unreachable (following `break` statement).');
   }
 
-  $ERROR('This code is unreachable.');
+  $ERROR('This code is unreachable (following `try` statement).');
 }
 
 assert.sameValue(i, 1);

test/language/statements/for-of/break-from-finally.js

+// Copyright (C) 2015 the V8 project authors. All rights reserved.
+// This code is governed by the BSD license found in the LICENSE file.
+/*---
+es6id: 13.6.4.13 S5.n
+description: >
+    Control flow during body evaluation should honor `break` statements within
+    `finally` blocks.
+features: [generators]
+---*/
+
+function* values() {
+  yield 1;
+  $ERROR('This code is unreachable (following `yield` statement).');
+}
+var iterator = values();
+var i = 0;
+
+for (var x of iterator) {
+  try {
+  } finally {
+    i++;
+    break;
+
+    $ERROR('This code is unreachable (following `break` statement).');
+  }
+
+  $ERROR('This code is unreachable (following `try` statement).');
+}
+
+assert.sameValue(i, 1);

test/language/for-of/break-from-try.js → test/language/statements/for-of/break-from-try.js

@@ -5,24 +5,25 @@ es6id: 13.6.4.13 S5.n
 description: >
     Control flow during body evaluation should honor `break` statements within
     `try` blocks.
+features: [generators]
 ---*/
 
 function* values() {
   yield 1;
-  yield 1;
+  $ERROR('This code is unreachable (following `yield` statement).');
 }
-var iterable = values();
+var iterator = values();
 var i = 0;
 
-for (var x of iterable) {
-  i++;
-
+for (var x of iterator) {
   try {
+    i++;
     break;
-    $ERROR('This code is unreachable.');
+
+    $ERROR('This code is unreachable (following `break` statement).');
   } catch (err) {}
 
-  $ERROR('This code is unreachable.');
+  $ERROR('This code is unreachable (following `try` statement).');
 }
 
 assert.sameValue(i, 1);

test/language/statements/for-of/break-label-from-catch.js

+// Copyright (C) 2015 the V8 project authors. All rights reserved.
+// This code is governed by the BSD license found in the LICENSE file.
+/*---
+es6id: 13.6.4.13 S5.n
+description: >
+    Control flow during body evaluation should honor `break` statements within
+    `try` blocks.
+features: [generators]
+---*/
+
+function* values() {
+  yield 1;
+  $ERROR('This code is unreachable (following `yield` statement).');
+}
+var iterator = values();
+var i = 0;
+
+outer:
+while (true) {
+  for (var x of iterator) {
+    try {
+      throw new Error();
+    } catch (err) {
+      i++;
+      break outer;
+      $ERROR('This code is unreachable (following `break` statement).');
+    }
+
+    $ERROR('This code is unreachable (following `try` statement).');
+  }
+
+  $ERROR('This code is unreachable (following `for..of` statement).');
+}
+
+assert.sameValue(i, 1);

test/language/statements/for-of/break-label-from-finally.js

+// Copyright (C) 2015 the V8 project authors. All rights reserved.
+// This code is governed by the BSD license found in the LICENSE file.
+/*---
+es6id: 13.6.4.13 S5.n
+description: >
+    Control flow during body evaluation should honor `break` statements within
+    `try` blocks.
+features: [generators]
+---*/
+
+function* values() {
+  yield 1;
+  $ERROR('This code is unreachable (following `yield` statement).');
+}
+var iterator = values();
+var i = 0;
+
+outer:
+while (true) {
+  for (var x of iterator) {
+    try {
+    } finally {
+      i++;
+      break outer;
+      $ERROR('This code is unreachable (following `break` statement).');
+    }
+
+    $ERROR('This code is unreachable (following `try` statement).');
+  }
+
+  $ERROR('This code is unreachable (following `for..of` statement).');
+}
+
+assert.sameValue(i, 1);

test/language/statements/for-of/break-label-from-try.js

+// Copyright (C) 2015 the V8 project authors. All rights reserved.
+// This code is governed by the BSD license found in the LICENSE file.
+/*---
+es6id: 13.6.4.13 S5.n
+description: >
+    Control flow during body evaluation should honor `break` statements within
+    `try` blocks.
+features: [generators]
+---*/
+
+function* values() {
+  yield 1;
+  $ERROR('This code is unreachable (following `yield` statement).');
+}
+var iterator = values();
+var i = 0;
+
+outer:
+while (true) {
+  for (var x of iterator) {
+    try {
+      i++;
+      break outer;
+      $ERROR('This code is unreachable (following `break` statement).');
+    } catch (err) {}
+
+    $ERROR('This code is unreachable (following `try` statement).');
+  }
+
+  $ERROR('This code is unreachable (following `for..of` statement).');
+}
+
+assert.sameValue(i, 1);

test/language/for-of/break-label.js → test/language/statements/for-of/break-label.js

@@ -5,24 +5,25 @@ es6id: 13.6.4.13 S5.n
 description: >
     Control flow during body evaluation should honor labeled `break`
     statements.
+features: [generators]
 ---*/
 
 function* values() {
   yield 1;
-  yield 1;
+  $ERROR('This code is unreachable (following `yield` statement).');
 }
-var iterable = values();
+var iterator = values();
 var i = 0;
 
 outer:
 while (true) {
-  for (var x of iterable) {
+  for (var x of iterator) {
     i++;
     break outer;
 
-    $ERROR('This code is unreachable.');
+    $ERROR('This code is unreachable (following `break` statement).');
   }
-  $ERROR('This code is unreachable.');
+  $ERROR('This code is unreachable (following `for..of` statement).');
 }
 
 assert.sameValue(i, 1);

test/language/for-of/break.js → test/language/statements/for-of/break.js

@@ -4,16 +4,17 @@
 es6id: 13.6.4.13 S5.n
 description: >
     Control flow during body evaluation should honor `break` statements.
+features: [generators]
 ---*/
 
 function* values() {
   yield 1;
-  yield 1;
+  $ERROR('This code is unreachable (following `yield` statement).');
 }
-var iterable = values();
+var iterator = values();
 var i = 0;
 
-for (var x of iterable) {
+for (var x of iterator) {
   i++;
   break;
 

test/language/for-of/continue-from-catch.js → test/language/statements/for-of/continue-from-catch.js

@@ -5,24 +5,27 @@ es6id: 13.6.4.13 S5.n
 description: >
     Control flow during body evaluation should honor `continue` statements
     within the `catch` block of `try` statements.
+features: [generators]
 ---*/
 
 function* values() {
   yield 1;
   yield 1;
 }
-var iterable = values();
+var iterator = values();
 var i = 0;
 
-for (var x of iterable) {
-  i++;
+for (var x of iterator) {
   try {
     throw new Error();
   } catch (err) {
+    i++;
     continue;
+
+    $ERROR('This code is unreachable (following `continue` statement).');
   }
 
-  $ERROR('This code is unreachable.');
+  $ERROR('This code is unreachable (following `try` statement).');
 }
 
 assert.sameValue(i, 2);

test/language/statements/for-of/continue-from-finally.js

+// Copyright (C) 2015 the V8 project authors. All rights reserved.
+// This code is governed by the BSD license found in the LICENSE file.
+/*---
+es6id: 13.6.4.13 S5.n
+description: >
+    Control flow during body evaluation should honor `continue` statements
+    within the `finally` block of `try` statements.
+features: [generators]
+---*/
+
+function* values() {
+  yield 1;
+  yield 1;
+}
+var iterator = values();
+var i = 0;
+
+for (var x of iterator) {
+  try {
+    throw new Error();
+  } catch (err) {
+  } finally {
+    i++;
+    continue;
+
+    $ERROR('This code is unreachable (following `continue` statement).');
+  }
+
+  $ERROR('This code is unreachable (following `try` statement).');
+}
+
+assert.sameValue(i, 2);

test/language/for-of/continue-from-try.js → test/language/statements/for-of/continue-from-try.js

@@ -5,23 +5,25 @@ es6id: 13.6.4.13 S5.n
 description: >
     Control flow during body evaluation should honor `continue` statements
     within `try` blocks.
+features: [generators]
 ---*/
 
 function* values() {
   yield 1;
   yield 1;
 }
-var iterable = values();
+var iterator = values();
 var i = 0;
 
-for (var x of iterable) {
-  i++;
+for (var x of iterator) {
   try {
+    i++;
     continue;
-    $ERROR('This code is unreachable.');
+
+    $ERROR('This code is unreachable (following `continue` statement).');
   } catch (err) {}
 
-  $ERROR('This code is unreachable.');
+  $ERROR('This code is unreachable (following `try` statement).');
 }
 
 assert.sameValue(i, 2);

test/language/statements/for-of/continue-label-from-catch.js

+// Copyright (C) 2015 the V8 project authors. All rights reserved.
+// This code is governed by the BSD license found in the LICENSE file.
+/*---
+es6id: 13.6.4.13 S5.n
+description: >
+    Control flow during body evaluation should honor `continue` statements
+    within the `catch` block of `try` statements.
+features: [generators]
+---*/
+
+function* values() {
+  yield 1;
+  yield 1;
+}
+var iterator = values();
+var loop = true;
+var i = 0;
+
+outer:
+while (loop) {
+  loop = false;
+
+  for (var x of iterator) {
+    try {
+      throw new Error();
+    } catch (err) {
+      i++;
+      continue outer;
+      $ERROR('This code is unreachable (following `continue` statement).');
+    }
+
+    $ERROR('This code is unreachable (following `try` statement).');
+  }
+
+  $ERROR('This code is unreachable (following `for..of` statement).');
+}
+
+assert.sameValue(i, 1);

test/language/statements/for-of/continue-label-from-finally.js

+// Copyright (C) 2015 the V8 project authors. All rights reserved.
+// This code is governed by the BSD license found in the LICENSE file.
+/*---
+es6id: 13.6.4.13 S5.n
+description: >
+    Control flow during body evaluation should honor `continue` statements
+    within the `finally` block of `try` statements.
+features: [generators]
+---*/
+
+function* values() {
+  yield 1;
+  yield 1;
+}
+var iterator = values();
+var loop = true;
+var i = 0;
+
+outer:
+while (loop) {
+  loop = false;
+
+  for (var x of iterator) {
+    try {
+      throw new Error();
+    } catch (err) {
+    } finally {
+      i++;
+      continue outer;
+
+      $ERROR('This code is unreachable (following `continue` statement).');
+    }
+
+    $ERROR('This code is unreachable (following `try` statement).');
+  }
+
+  $ERROR('This code is unreachable (following `for..of` statement).');
+}
+
+assert.sameValue(i, 1);

test/language/statements/for-of/continue-label-from-try.js

+// Copyright (C) 2015 the V8 project authors. All rights reserved.
+// This code is governed by the BSD license found in the LICENSE file.
+/*---
+es6id: 13.6.4.13 S5.n
+description: >
+    Control flow during body evaluation should honor `continue` statements
+    within `try` blocks.
+features: [generators]
+---*/
+
+function* values() {
+  yield 1;
+  yield 1;
+}
+var iterator = values();
+var loop = true;
+var i = 0;
+
+outer:
+while (loop) {
+  loop = false;
+  for (var x of iterator) {
+    try {
+      i++;
+      continue outer;
+      $ERROR('This code is unreachable (following `continue` statement).');
+    } catch (err) {}
+
+    $ERROR('This code is unreachable (following `try` statment).');
+  }
+
+  $ERROR('This code is unreachable (following `for..of` statement).');
+}
+
+assert.sameValue(i, 1);

test/language/for-of/continue-label.js → test/language/statements/for-of/continue-label.js

@@ -5,12 +5,13 @@ es6id: 13.6.4.13 S5.n
 description: >
     Control flow during body evaluation should honor labeled `continue`
     statements.
+features: [generators]
 ---*/
 
 function* values() {
   yield 1;
 }
-var iterable = values();
+var iterator = values();
 var i = 0;
 var loop = true;
 
@@ -18,7 +19,7 @@ outer:
 while (loop) {
   loop = false;
 
-  for (var x of iterable) {
+  for (var x of iterator) {
     i++;
     continue outer;
 

test/language/for-of/continue.js → test/language/statements/for-of/continue.js

@@ -4,16 +4,17 @@
 es6id: 13.6.4.13 S5.n
 description: >
     Control flow during body evaluation should honor `continue` statements.
+features: [generators]
 ---*/
 
 function* values() {
   yield 1;
   yield 1;
 }
-var iterable = values();
+var iterator = values();
 var i = 0;
 
-for (var x of iterable) {
+for (var x of iterator) {
   i++;
   continue;