Linter should require direct throw statement for raw tests instead of DONOTEVALUATE

tools/lint/lib/checks/negative.py

@@ -5,6 +5,10 @@ _THROW_STMT = re.compile(
       r'^\$DONOTEVALUATE\(\);$',
       re.MULTILINE)
 
+_THROW_STMT_LEGACY = re.compile(
+      r'^throw "Test262: This statement should not be evaluated\.";$',
+      re.MULTILINE)
+
 class CheckNegative(Check):
     '''Ensure tests have the expected YAML-formatted metadata.'''
     ID = 'NEGATIVE'
@@ -23,5 +27,9 @@ class CheckNegative(Check):
         if not 'phase' in negative:
             return '"negative" must specify a "phase" field'
 
-        if negative["phase"] in ["parse", "resolution"] and not _THROW_STMT.search(source):
-            return 'Negative tests of type "early" must include a `throw` statement'
+        if negative["phase"] in ["parse", "resolution"]:
+            if meta.get('flags') and 'raw' in meta['flags']:
+                if not _THROW_STMT_LEGACY.search(source):
+                    return 'Negative tests of type "early" must include a `throw` statement'
+            elif not _THROW_STMT.search(source):
+                return 'Negative tests of type "early" must include a $DONOTEVALUATE() call'

tools/lint/test/fixtures/negative_missing_phase.js

@@ -9,4 +9,6 @@ negative:
   type: SyntaxError
 ---*/
 
+$DONOTEVALUATE();
+
 !!!

tools/lint/test/fixtures/negative_missing_type.js

@@ -9,4 +9,6 @@ negative:
   phase: early
 ---*/
 
+$DONOTEVALUATE();
+
 !!!

tools/lint/test/fixtures/negative_no_raw_stmt.js

+^ expected errors | v input
+// Copyright (C) 2019 Leo Balter. All rights reserved.
+// This code is governed by the BSD license found in the LICENSE file.
+/*---
+esid: sec-assignment-operators-static-semantics-early-errors
+description: Minimal test
+negative:
+  type: SyntaxError
+  phase: parse
+---*/
+
+$DONOTEVALUATE();
+
+!!!

tools/lint/test/fixtures/negative_no_raw_wrong_stmt.js

+NEGATIVE
+^ expected errors | v input
+// Copyright (C) 2019 Leo Balter. All rights reserved.
+// This code is governed by the BSD license found in the LICENSE file.
+/*---
+esid: sec-assignment-operators-static-semantics-early-errors
+description: Minimal test
+negative:
+  type: SyntaxError
+  phase: parse
+---*/
+
+throw "Test262: This statement should not be evaluated!";
+
+!!!

tools/lint/test/fixtures/negative_parse_throw_bad_value.js

@@ -10,6 +10,6 @@ negative:
   phase: parse
 ---*/
 
-throw "Test262: This statement should not be evaluated!";
+$DONOTEVALUATE(1);
 
 !!!

tools/lint/test/fixtures/negative_raw_call.js

+^ expected errors | v input
+// Copyright (C) 2019 Leo Balter. All rights reserved.
+// This code is governed by the BSD license found in the LICENSE file.
+/*---
+esid: sec-assignment-operators-static-semantics-early-errors
+description: Minimal test
+negative:
+  type: SyntaxError
+  phase: parse
+flags: [raw]
+---*/
+
+throw "Test262: This statement should not be evaluated.";
+
+!!!

tools/lint/test/fixtures/negative_raw_wrong_call.js

+NEGATIVE
+^ expected errors | v input
+// Copyright (C) 2019 Leo Balter. All rights reserved.
+// This code is governed by the BSD license found in the LICENSE file.
+/*---
+esid: sec-assignment-operators-static-semantics-early-errors
+description: Minimal test
+negative:
+  type: SyntaxError
+  phase: parse
+flags: [raw]
+---*/
+
+$DONOTEVALUATE();
+
+!!!

tools/lint/test/fixtures/negative_resolution_throw_bad_value.js

@@ -11,6 +11,6 @@ negative:
   phase: resolution
 ---*/
 
-throw "Test262: This statement should not be evaluated!";
+$DONOTEVALUATE(1);
 
 import 'non-existent-module.js';