Merge pull request #1491 from bocoup/bigint-fix

Bigint fix: the remaining bugs found in #1461

test/built-ins/TypedArray/prototype/fill/BigInt/return-abrupt-from-end-as-symbol.js

@@ -33,6 +33,6 @@ var end = Symbol(1);
 testWithBigIntTypedArrayConstructors(function(TA) {
   var sample = new TA();
   assert.throws(TypeError, function() {
-    sample.fill(1, 0, end);
+    sample.fill(1n, 0, end);
   });
 });

test/built-ins/TypedArray/prototype/fill/BigInt/return-abrupt-from-start-as-symbol.js

@@ -32,6 +32,6 @@ var start = Symbol(1);
 testWithBigIntTypedArrayConstructors(function(TA) {
   var sample = new TA();
   assert.throws(TypeError, function() {
-    sample.fill(1, start);
+    sample.fill(1n, start);
   });
 });

test/built-ins/TypedArray/prototype/includes/BigInt/detached-buffer.js

@@ -23,6 +23,6 @@ testWithBigIntTypedArrayConstructors(function(TA) {
   var sample = new TA(1);
   $DETACHBUFFER(sample.buffer);
   assert.throws(TypeError, function() {
-    sample.includes(0);
+    sample.includes(0n);
   });
 });

test/built-ins/TypedArray/prototype/includes/BigInt/fromIndex-equal-or-greater-length-returns-false.js

@@ -31,6 +31,6 @@ testWithBigIntTypedArrayConstructors(function(TA) {
   var sample;
 
   sample = new TA(42);
-  assert.sameValue(sample.includes(0, 42), false);
-  assert.sameValue(sample.includes(0, 43), false);
+  assert.sameValue(sample.includes(0n, 42), false);
+  assert.sameValue(sample.includes(0n, 43), false);
 });

test/built-ins/TypedArray/prototype/includes/BigInt/length-zero-returns-false.js

@@ -33,7 +33,7 @@ testWithBigIntTypedArrayConstructors(function(TA) {
   assert.sameValue(sample.includes(0), false, "returns false");
   assert.sameValue(sample.includes(), false, "returns false - no arg");
   assert.sameValue(
-    sample.includes(0, fromIndex), false,
+    sample.includes(0n, fromIndex), false,
     "length is checked before ToInteger(fromIndex)"
   );
 });

test/built-ins/TypedArray/prototype/indexOf/BigInt/detached-buffer.js

@@ -23,6 +23,6 @@ testWithBigIntTypedArrayConstructors(function(TA) {
   var sample = new TA(1);
   $DETACHBUFFER(sample.buffer);
   assert.throws(TypeError, function() {
-    sample.indexOf(0);
+    sample.indexOf(0n);
   });
 });

test/built-ins/TypedArray/prototype/indexOf/BigInt/fromIndex-equal-or-greater-length-returns-minus-one.js

@@ -25,6 +25,6 @@ testWithBigIntTypedArrayConstructors(function(TA) {
   var sample;
 
   sample = new TA(42);
-  assert.sameValue(sample.indexOf(0, 42), -1);
-  assert.sameValue(sample.indexOf(0, 43), -1);
+  assert.sameValue(sample.indexOf(0n, 42), -1);
+  assert.sameValue(sample.indexOf(0n, 43), -1);
 });

test/built-ins/TypedArray/prototype/indexOf/BigInt/length-zero-returns-minus-one.js

@@ -29,9 +29,9 @@ var fromIndex = {
 
 testWithBigIntTypedArrayConstructors(function(TA) {
   var sample = new TA();
-  assert.sameValue(sample.indexOf(0), -1, "returns -1");
+  assert.sameValue(sample.indexOf(0n), -1, "returns -1");
   assert.sameValue(
-    sample.indexOf(0, fromIndex), -1,
+    sample.indexOf(0n, fromIndex), -1,
     "length is checked before ToInteger(fromIndex)"
   );
 });

test/built-ins/TypedArray/prototype/indexOf/BigInt/return-abrupt-tointeger-fromindex-symbol.js

@@ -27,6 +27,6 @@ testWithBigIntTypedArrayConstructors(function(TA) {
   var sample = new TA(1);
 
   assert.throws(TypeError, function() {
-    sample.indexOf(7, fromIndex);
+    sample.indexOf(7n, fromIndex);
   });
 });

test/built-ins/TypedArray/prototype/indexOf/BigInt/return-abrupt-tointeger-fromindex.js

@@ -31,6 +31,6 @@ testWithBigIntTypedArrayConstructors(function(TA) {
   var sample = new TA(1);
 
   assert.throws(Test262Error, function() {
-    sample.indexOf(7, fromIndex);
+    sample.indexOf(7n, fromIndex);
   });
 });

test/built-ins/TypedArray/prototype/lastIndexOf/BigInt/detached-buffer.js

@@ -23,6 +23,6 @@ testWithBigIntTypedArrayConstructors(function(TA) {
   var sample = new TA(1);
   $DETACHBUFFER(sample.buffer);
   assert.throws(TypeError, function() {
-    sample.lastIndexOf(0);
+    sample.lastIndexOf(0n);
   });
 });

test/built-ins/TypedArray/prototype/lastIndexOf/BigInt/length-zero-returns-minus-one.js

@@ -31,7 +31,7 @@ testWithBigIntTypedArrayConstructors(function(TA) {
   var sample = new TA();
   assert.sameValue(sample.lastIndexOf(0), -1, "returns -1");
   assert.sameValue(
-    sample.lastIndexOf(0, fromIndex), -1,
+    sample.lastIndexOf(0n, fromIndex), -1,
     "length is checked before ToInteger(fromIndex)"
   );
 });

test/built-ins/TypedArray/prototype/lastIndexOf/BigInt/return-abrupt-tointeger-fromindex-symbol.js

@@ -27,6 +27,6 @@ testWithBigIntTypedArrayConstructors(function(TA) {
   var sample = new TA(1);
 
   assert.throws(TypeError, function() {
-    sample.lastIndexOf(7, fromIndex);
+    sample.lastIndexOf(7n, fromIndex);
   });
 });

test/built-ins/TypedArray/prototype/lastIndexOf/BigInt/return-abrupt-tointeger-fromindex.js

@@ -31,6 +31,6 @@ testWithBigIntTypedArrayConstructors(function(TA) {
   var sample = new TA(1);
 
   assert.throws(Test262Error, function() {
-    sample.lastIndexOf(7, fromIndex);
+    sample.lastIndexOf(7n, fromIndex);
   });
 });

test/built-ins/TypedArray/prototype/set/BigInt/typedarray-arg-set-values-diff-buffer-other-type-sab.js

@@ -13,7 +13,8 @@ features: [BigInt, SharedArrayBuffer, TypedArray]
 
 testWithBigIntTypedArrayConstructors(function(TA) {
   var sab = new SharedArrayBuffer(2 * BigInt64Array.BYTES_PER_ELEMENT);
-  var src = new BigInt64Array(sab);
+  var otherCtor = TA === BigInt64Array ? BigUint64Array : BigInt64Array;
+  var src = new otherCtor(sab);
   src[0] = 42n;
   src[1] = 43n;
   var sample, result;

test/built-ins/TypedArray/prototype/sort/BigInt/sortcompare-with-no-tostring.js

@@ -18,10 +18,14 @@ includes: [testBigIntTypedArray.js, compareArray.js]
 features: [BigInt, TypedArray]
 ---*/
 
-var origToString = Number.prototype.toString;
+var toStringCalled = false;
+BigInt.prototype.toString = function() {
+  toStringCalled = true;
+}
 
 testWithBigIntTypedArrayConstructors(function(TA) {
   var sample = new TA([20n, 100n, 3n]);
   var result = sample.sort();
+  assert.sameValue(toStringCalled, false, "BigInt.prototype.toString will not be called");
   assert(compareArray(result, [3n, 20n, 100n]));
 });

test/built-ins/TypedArray/prototype/sort/sortcompare-with-no-tostring.js

@@ -18,10 +18,14 @@ includes: [testTypedArray.js, compareArray.js]
 features: [TypedArray]
 ---*/
 
-var origToString = Number.prototype.toString;
+var toStringCalled = false;
+Number.prototype.toString = function() {
+  toStringCalled = true;
+}
 
 testWithTypedArrayConstructors(function(TA) {
   var sample = new TA([20, 100, 3]);
   var result = sample.sort();
-  assert(compareArray(result, [3, 20, 100]));
+  assert.sameValue(toStringCalled, false, "Number.prototype.toString will not be called");
+  assert(compareArray(result, [3, 20, 100]), "Default sorting by value");
 });

test/built-ins/TypedArrayConstructors/ctors-bigint/buffer-arg/invoked-with-undefined-newtarget-sab.js

@@ -20,7 +20,7 @@ features: [BigInt, SharedArrayBuffer, TypedArray]
 ---*/
 
 testWithBigIntTypedArrayConstructors(function(TA) {
-  var buffer = new SharedArrayBuffer(4);
+  var buffer = new SharedArrayBuffer(TA.BYTES_PER_ELEMENT);
   assert.throws(TypeError, function() {
     TA(buffer);
   });

test/built-ins/TypedArrayConstructors/ctors-bigint/buffer-arg/invoked-with-undefined-newtarget.js

@@ -19,7 +19,7 @@ features: [BigInt, TypedArray]
 ---*/
 
 testWithBigIntTypedArrayConstructors(function(TA) {
-  var buffer = new ArrayBuffer(4);
+  var buffer = new ArrayBuffer(TA.BYTES_PER_ELEMENT);
   assert.throws(TypeError, function() {
     TA(buffer);
   });

test/built-ins/TypedArrayConstructors/ctors-bigint/typedarray-arg/other-ctor-buffer-ctor-access-throws.js

@@ -26,7 +26,7 @@ features: [BigInt, TypedArray]
 ---*/
 
 testWithBigIntTypedArrayConstructors(function(TA) {
-  var OtherCtor = TA === Int8Array ? Int16Array : Int8Array;
+  var OtherCtor = TA === BigInt64Array ? BigUint64Array : BigInt64Array;
   var sample = new OtherCtor();
 
   Object.defineProperty(sample.buffer, "constructor", {