Skip to content
Snippets Groups Projects
Commit e515abfa authored by Mike Pennisi's avatar Mike Pennisi
Browse files

Refactor LT tests for parsers: multi-line comment

The tests for the parsing of line terminators were expressed using eval.
This made the tests more complex than necessary and also prevented the
tests from providing value to ECMAScript parsers.

Remove the use of eval and instead express the expectations with literal
source text. Rename the files to make each test's purpose more clear.
parent 0ec9dbe3
No related branches found
No related tags found
No related merge requests found
......@@ -3,18 +3,28 @@
/*---
info: Multi line comment can contain LINE FEED (U+000A)
esid: sec-line-terminators
es5id: 7.3_A5.1_T2
description: Insert real LINE FEED into multi line comment
negative:
phase: runtime
type: Test262Error
---*/
/*CHECK#1*/
// Because this test concerns the interpretation of non-executable character
// sequences within ECMAScript source code, special care must be taken to
// ensure that executable code is evaluated as expected.
//
// Express the intended behavior by intentionally throwing an error; this
// guarantees that test runners will only consider the test "passing" if
// executable sequences are correctly interpreted as such.
var x = 0;
/*
multi
line
comment
x = 1;
*/
if (x !== 0) {
$ERROR('#1: var x = 0; /*\\nmulti\\nline\\ncomment\\nx = 1;\\n*/ x === 0. Actual: ' + (x));
if (x === 0) {
throw new Test262Error();
}
......@@ -3,16 +3,26 @@
/*---
info: Multi line comment can contain LINE SEPARATOR (U+2028)
esid: sec-line-terminators
es5id: 7.3_A5.3
description: Insert LINE SEPARATOR (U+2028) into multi line comment
negative:
phase: runtime
type: Test262Error
---*/
// CHECK#1
eval("/*\u2028 multi line \u2028 comment \u2028*/");
// Because this test concerns the interpretation of non-executable character
// sequences within ECMAScript source code, special care must be taken to
// ensure that executable code is evaluated as expected.
//
// Express the intended behavior by intentionally throwing an error; this
// guarantees that test runners will only consider the test "passing" if
// executable sequences are correctly interpreted as such.
//CHECK#2
var x = 0;
eval("/*\u2028 multi line \u2028 comment \u2028 x = 1;*/");
if (x !== 0) {
$ERROR('#1: var x = 0; eval("/*\\u2028 multi line \\u2028 comment \\u2028 x = 1;*/"); x === 0. Actual: ' + (x));
/*
x = 1;
*/
if (x === 0) {
throw new Test262Error();
}
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment