Skip to content
Snippets Groups Projects
  1. Apr 02, 2019
  2. Apr 01, 2019
    • Mike Pennisi's avatar
      Refactor `with` statement tests for parsers · 9b396d0b
      Mike Pennisi authored
      The tests for the parsing of the `with` statement were expressed using
      eval. This made the tests more complex than necessary and also prevented
      the tests from providing value to ECMAScript parsers.
      
      Remove the use of eval and instead express the expectations with literal
      source text. Rename the files to make each test's purpose more clear.
      9b396d0b
    • Mike Pennisi's avatar
      Remove redundant tests · 25533814
      Mike Pennisi authored
      These tests are syntactically equivalent to
      `test/language/statements/with/12.10.1-7-s.js` and may therefore be
      removed without degrading coverage.
      
      While `test/language/statements/with/12.10.1-9-s.js` differs slightly in
      the pattern used to enable strict mode, the relevant behavior of the
      "use strict" directive prologue is expressly tested via
      `test/language/directive-prologue/func-expr-inside-func-decl-parse.js`.
      25533814
    • Mike Pennisi's avatar
      Improve test precision · 159bcc7b
      Mike Pennisi authored
      Previously, some tests verified two independent concerns simultaneously:
      syntactic validity and runtime completion value. The former is relevant
      for ECMAScript runtimes and parsers alike, but the latter is only
      observable by runtimes.
      
      Express expectations regarding syntactic validity using literal program
      code so they can be used by parsers. Maintain the original tests which
      rely on eval in order to preserve coverage for statement completion
      values.
      159bcc7b
    • Mike Pennisi's avatar
      Refactor misc. statement tests for parsers · aa4c533d
      Mike Pennisi authored
      The tests for the parsing of various statement were expressed using
      eval. This made the tests more complex than necessary and also prevented
      the tests from providing value to ECMAScript parsers.
      
      Remove the use of eval and instead express the expectations with literal
      source text. Rename the files to make each test's purpose more clear.
      aa4c533d
    • Mike Pennisi's avatar
      Remove indirect tests · c9249a8f
      Mike Pennisi authored
      These tests are ostensibly designed to validate parsing of Regular
      Expression literals--specifically those which use Unicode escape
      sequences to declare flags. However, because the syntax is expressed in
      terms of a string literal and then evaluated dynamically, the escape
      sequences in use have no bearing on the program code which is ultimately
      parsed. These tests therefore do not extend coverage in any meaningful
      way and may be removed.
      c9249a8f
    • Mike Pennisi's avatar
      Refactor literal tests for parsers · e0120fcb
      Mike Pennisi authored
      The tests for the parsing of literal values were expressed using eval.
      This made the tests more complex than necessary and also prevented the
      tests from providing value to ECMAScript parsers.
      
      Remove the use of eval and instead express the expectations with literal
      source text. Rename the files to make each test's purpose more clear.
      e0120fcb
    • Mike Pennisi's avatar
      Remove redundant test · 937d0b1d
      Mike Pennisi authored
      The production under test is also used in the following file:
      
      test/language/literals/numeric/legacy-octal-integer-strict.js
      
      That test expresses the syntax with literal source text, making it
      useful for parsers. Remove this test in favor of the other.
      937d0b1d
  3. Mar 29, 2019
  4. Mar 26, 2019
  5. Mar 25, 2019
  6. Mar 21, 2019
  7. Mar 19, 2019
  8. Mar 17, 2019
  9. Mar 14, 2019
  10. Mar 13, 2019
  11. Mar 12, 2019
  12. Mar 11, 2019
  13. Mar 06, 2019
Loading