Skip to content
Snippets Groups Projects
  1. Feb 12, 2016
    • Mike Pennisi's avatar
      Make asynchronous test configuration explicit · 23d56620
      Mike Pennisi authored
      For asynchronous tests, the contract between test file and test runner
      is implicit: runners are expected to inspect the source code for
      references to a global `$DONE` identifier.
      
      Promote a more explicit contract between test file and test runner by
      introducing a new frontmatter "tag", `async`. This brings asynchronous
      test configuration in-line with other configuration mechanisms and also
      provides a more natural means of test filtering.
      
      The modifications to test files was made programatically using the
      `grep` and `sed` utilities:
      
          $ grep "\$DONE" test/ -r --files-with-match --null | \
              xargs -0 sed -i 's/^\(flags:\s*\)\[/\1[async, /g'
          $ grep "\$DONE" test/ -rl --null | \
              xargs -0 grep -E '^flags:' --files-without-match --null | \
              xargs -0 sed -i 's/^---\*\//flags: [async]\n---*\//'
      23d56620
  2. Jan 20, 2016
  3. Jan 07, 2016
  4. Dec 03, 2015
  5. Dec 02, 2015
  6. Nov 24, 2015
  7. Jul 10, 2015
    • Mike Pennisi's avatar
      Prefer explicit error checking where possible · 10e0d977
      Mike Pennisi authored
      The `negative` frontmatter tag expresses an expectation for the behavior
      of the test file as a whole. The `assert.throws` helper function offers
      more fine-grained control over expectations because it may be applied to
      specific statements and expressions. This makes it preferable in cases
      where it may be used (i.e. when the test body does not describe a syntax
      error or early error).
      
      Re-implement assertions for errors to use the `assert.throws` helper
      function wherever possible.
      10e0d977
  8. Jul 08, 2015
  9. Jul 07, 2015
    • Mike Pennisi's avatar
      Formalize tests for built-in Promise methods · 4e2f3508
      Mike Pennisi authored
      Uniformly and exhaustively test the generic aspects of the static- and
      instance Promise methods, including:
      
      - function `length` properties
      - function `name` properties
      - method property descriptors
      4e2f3508
  10. Jun 23, 2015
    • Mike Pennisi's avatar
      Fix bug in test · 6f2feb01
      Mike Pennisi authored
      This test's description concerns the behavior of `Promise.all` when the
      IteratorStep abstract operation fails due to an abrupt completion
      returned by the iterator's `next` method. The test body did not actually
      assert that functionality.
      
      Update the test body to correctly define the requisite iterator and
      assert that the specific error created is the one thrown from the
      invocation of `Promise.all`
      6f2feb01
  11. Jun 02, 2015
  12. Feb 12, 2015
  13. Dec 07, 2014
Loading