Skip to content
Snippets Groups Projects
  1. Apr 15, 2017
  2. Apr 13, 2017
  3. Mar 13, 2017
  4. Mar 15, 2016
  5. May 18, 2015
    • André Bargull's avatar
      Enable strict mode for more built-in tests · 56036e40
      André Bargull authored
      - Remove no longer needed noStrict flags.
      - Change tests to use propertyHelper.js for strict mode compatibility.
      - Add tests for return value of `delete` operator, e.g. `delete Array.prototype === false`.
      - Add non-writable tests for global NaN property.
      - Split some tests to run in strict mode.
      - Change tests with global `var length` declaration to use a different variable name for browser environments.
      - Merge duplicated tests symbol-data-property-configurable-non-strict and symbol-data-property-configurable-strict.
      - Merge duplicated tests symbol-data-property-writable-non-strict and symbol-data-property-writable-strict.
      - (And a small change in propertyHelper to reduce code duplication in function call.)
      56036e40
  6. Apr 21, 2015
    • Mike Pennisi's avatar
      Fix bug in `isWritable` utility function · c27938a1
      Mike Pennisi authored
      Only attempt to re-set the property value in cases where it was
      successfully modified as part of the function's execution. This avoids
      errors when the underlying value is not writable. Rename the internal
      result-tracking variable to make this more clear.
      c27938a1
  7. Mar 04, 2015
  8. Feb 20, 2015
  9. Dec 11, 2014
    • smikes's avatar
      rework: remove *PropertyAttributes fns · 49abae4f
      smikes authored
      - this change hits all files that use
      dataPropertyAttributesAreCorrect or
      acccessorPropertyAttributesAreCorrect
      
      Major changes:
      - remove include of runTestCase.js,
      dataPropertyAttributesAreCorrect.js and
      acccessorPropertyAttributesAreCorrect.js
      - add include of propertyHelper.js
      - remove function testCase() and call to
      function runTestCase()
      - instead of collecting test state into booleans,
      which are eventually returned from runTestCase,
      test conditions and throw errors immediately
      - use negative: to check error types instead of
      using `instanceof` in a catch() block
      
      Selected commit logs follow:
      
      manual conversion of accessorPropertyAttributesAreCorrect() test
       - remove runTestCase
       - remove wrapping testCase function
       - unindent
       - remove includes of runTestCase & accessor...
       - add include of propertyHelper.js
       - unpack final two args 'true, false' to explicit inline
         tests of isEnumerable and isConfigurable
       - unpack setter test into inline logic
       - unpack getter test into inline logic
      
      used script to replace includes: frontmatter
      with propertyHelper.js ; manually added back
      references to fnGlobalObject() where needed
      
      additional helper functions
      
      add helper functions for get and writable
      duplicate runTestCase so can remove runTestCase.js from
      includes of all tests in batch
      
      use keyboard macros to simplify repetitive conversions
      remove auto-save file accidentaly committed
      
      minor changes, manually remove runTestCase from remaining files
      lint etc. fixes
      
      remove now-obsolete harness files
      
      make strict/nonstrict variants
      
      tests where behavior is different in strict/nonstrict
      need two variants
      
      - strict mode throws on assign to read-only element (no setter fn)
      - strict mode separates named arguments from arguments[]
      
      fix indentation
      
      cleanup minor issues
      
      reviewing 15.2.3.7-9 tests, found some minor issues
      
      - indentation/spacing
      - duplicate test (eg, direct test of value and dataProp...)
      - remove needless try/finally
      - use assert.. helpers in place of if(is..
      - rename some assertions to 'e'
      
      rename assertX to verifyX
      new helper fn sameValue
      test "set" as well as get
      reverse order of checks
      restore test of desc2
      restore test of length
      restore test of ownProperty
      incorporate suggestions re order of ops, Object.prototype
      add test of sameValue helper
      restore return value in getter
      restore second defineProperty call
      restore check of explicit "false"
      restore explicit test of TypeError
      set noStrict flag on arguments changes
      rename catch var to "e"	b4ad0e6
      remove dataPropertyAttributesAreCorrect from tests	0d83ff2
      remove accessorPropertyAttributesAreCorrect from tests	bb926f3
      remove {data,accessor}Property... fns from harness
      
      fix writable check on array.length
      
      call $ERROR if expected exception not thrown
      fix Epected => Expected typo
      
      use assert._isSamevalue
      49abae4f
Loading