Skip to content
Snippets Groups Projects
  1. Feb 14, 2019
  2. Dec 18, 2018
  3. Nov 26, 2018
  4. Oct 23, 2018
  5. Sep 12, 2018
  6. Sep 04, 2018
    • jugglinmike's avatar
      Improve documentation for Python usage (#1703) · 9c3518a7
      jugglinmike authored
      Update the recommended invocation of `pip` to use the `python` command,
      avoiding discrepancies on systems where the `pip` and `python` commands
      are not provided by the same Python installation. In the interest of
      consistency, also update the configuration for the project's continuous
      integration service.
      
      Recommend additional tooling for users with more advanced needs.
      9c3518a7
  7. Aug 13, 2018
  8. Aug 07, 2018
  9. Jul 03, 2018
    • André Bargull's avatar
      Make Atomics tests more resilient against intermittent failures (#1617) · 8bc4e38a
      André Bargull authored
      Also fixes multiple issues and bugs in various Atomics tests.
      
      CONTRIBUTING.md and INTERPRETING.md:
      - Add missing description for `CanBlockIsFalse` flag and also introduce `CanBlockIsTrue` flag which is needed for some tests (see below).
      
      harness/atomicsHelper.js:
      - Updated `$262.agent.waitUntil` to clarify it can also be called with BigInt64Array objects.
      - Added `$262.agent.timeouts` constants to unify the various, inconsistently used timeouts in the Atomics tests. Each timeout constant has a brief description and a usage example to clarify when it should or should not be used. The default values were tested in SpiderMonkey (locally and CI) under various system load levels and should hopefully also be valid for other engines. 
      - Added `$262.agent.tryYield` to yield control from the main thread. The default implementation simply calls `$262.agent.sleep`, but test262 hosts could theoretically provide a different implementation.
      - Added `$262.agent.trySleep` to replace direct calls to `$262.agent.sleep` from the main thread. Motivation for this function: Some test262 hosts (like browsers) may be able to pause and sleep on the main thread, so they could provide their implementation for `trySleep` which performs a busy-wait or something do nothing.
      
      harness/testAtomics.js:
      - Replace `let`, `arrow-functions`, and `for-of` loops to avoid creating extremely long `features` lists in tests using this helper. Removed `Map`, `WeakMap`, `Set`, and `WeakSet` (these weren't even listed in features.yaml) for the same reason and added the missing `Symbol` entry for this file to features.yaml.
      - Updated all files including "harness/testAtomics.js" to match the new feature requirements.
      
      
      test/built-ins/Atomics/store/good-views.js and test/built-ins/Atomics/store/bigint/good-views.js:
      - Replace `arrow-functions` and `for-of` loops with ES5 alternatives.
      
      
      test/built-ins/Atomics/wait/bigint/*.js and test/built-ins/Atomics/wake/bigint/*.js
      - Some tests were using `BigInt64Array.BYTES_PER_ELEMENT * 8` for the SharedArrayBuffer length, but their non-BigInt counterparts are using `Int32Array.BYTES_PER_ELEMENT * 4`. For consistency and to make it easier to compare the BigInt against the non-BigInt versions, I've changed it to `BigInt64Array.BYTES_PER_ELEMENT * 4`.
      - Also aligned formatting and statement placement when they differed between the non-BigInt and the BigInt version of a test file. (I've diffed some of the non-BigInt and BigInt files against each other and different formatting was a nuisance.)
      
      Test files using `$262.agent.monotonicNow()`:
      - Moved `$262.agent.report()` calls outside of the block of code measured `$262.agent.monotonicNow()` to avoid measuring how long it takes to execute `$262.agent.report()`. 
      - Without this change some tests failed intermittently in certain test configurations in SpiderMonkey. For example with the flags `--ion-eager -- ion-offthread-compile=off` which forces early Ion compilation on the main thread. The `$262.agent.report()` implementation in the SpiderMonkey test262 host embedding uses a for-loop which was forcefully Ion compiled under these settings. And because Ion compilation can take some time, the test case ran longer than `$262.agent.MAX_TIME_EPSILON` which lead to intermittent failures.
      
      Test files using `CanBlockIsFalse` / `CanBlockIsTrue`:
      - Some of these tests actually expected that the main thread can wait and [[CanBlock]] is `true` for the agent record executing the test. Therefore I've added a new `CanBlockIsTrue` flag and replaced the flags where needed.
      
      test/built-ins/Atomics/wait/**/*.js and test/built-ins/Atomics/wake/**/*.js:
      - Use an atomic counter `RUNNING` in more tests to have better control when a worker agent was actually started.
      - Replace the various `$262.agent.sleep(/* Sleep X ms to ensure worker actually sleeps */)` calls with the new `$262.agent.tryYield()` function. This `X` was sometimes as low as 10 milliseconds, which is definitely too short for CI systems under heavy load (observed by intermittent CI failures for SpiderMonkey) and sometimes as high as 500 milliseconds, which is probably much longer than needed even when the system is under heavy load. 
      - Removed duplicate strings in assertion messages, presumably from copy-pasting the messages between different files.
      - Removed extra empty lines at the end of multiple files.
      
      test/built-ins/Atomics/wake/bad-range.js, test/built-ins/Atomics/wake/bigint/bad-range.js, and test/built-ins/Atomics/wait/bigint/non-bigint64-typedarray-throws.js:
      - Removed unnecessary `features` and `includes` from this file.
      
      test/built-ins/Atomics/wait/waiterlist-order-of-operations-is-fifo.js and test/built-ins/Atomics/wait/bigint/waiterlist-order-of-operations-is-fifo.js:
      - The test was actually broken and didn't test what it said it does. This probably explains #1530.
      - The test wants to ensure the waiterlist is implemented as a FIFO structure. This requires that the waiting agents all wait on the same index position, because the waiterlists are defined by each index. But if the agents wait on different indices, each agent is inserted into a different FIFO structure and therefore we can't observe any FIFO ordering between the agents when they're woken up.
      - All this requires a bit of synchronization between the main agent and the waiting agent, I hope the added comments help to review these changes.
      
      test/built-ins/Atomics/wait/good-views.js:
      - The agent sends multiple reports to the main agent, but only the first one was read.
      - This error was introduced during previous refactorings. I've changed it to back to use a while-loop as used in the first version of this file.
      
      test/built-ins/Atomics/wait/no-spurious-wakeup-no-operation.js:
      - Only the BigInt version of this test was present, copied it so we also get code coverage for the non-BigInt case.
      
      test/built-ins/Atomics/wait/waiterlist-block-indexedposition-wake.js:
      - Added extra while loops to avoid intermittent failures when the agent worker haven't started to wait.
      - This should help to avoid some of the intermittent failures we saw for SpiderMonkey.
      
      test/built-ins/Atomics/wake/wake-all-on-loc.js and test/built-ins/Atomics/wake/bigint/wake-all-on-loc.js:
      - This test was also no longer after previous refactoring sessions.
      - The "B" agent only waited for 10 milliseconds, which made it likely that it already timed out before the main agent was able to call `Atomics.wake`, which in turn rendered the test useless, because the test case wants to ensure that `Atomics.wake` cannot wake "B". But if "B" was already timed out, it can trivially not be woken by `Atomics.wake`.
      - Added some safety measure to catch the case when "B" timed out before `Atomics.wake` was called and made it a test error if that happens.
      
      test/built-ins/Atomics/wake/count-defaults-to-infinity-missing.js, test/built-ins/Atomics/wake/count-defaults-to-infinity-undefined.js, and test/built-ins/Atomics/wake/undefined-index-defaults-to-zero.js:
      - Changed the `$262.agent.start()` calls to use a for-loop to avoid code duplication.
      - (Forgot to undo the code formatting around `assert.sameValue`, still need to change it back.)
      - Also more while-loops around `Atomics.wake`.
      - These changes should fix #1529 and #1566.
      
      test/built-ins/Atomics/wake/wake-all.js:
      - Removed "B" worker agent.
      - Without this removal the test case would be exactly equal to test/built-ins/Atomics/wake/wake-all-on-loc.js.
      
      test/built-ins/Atomics/wake/wake-in-order-one-time.js:
      - Add for-loops to avoid code duplication and make the test more readable.
      - Make the `Atomics.wake` assertion messages unique by adding the current loop counter.
      - Add `$262.agent.tryYield()` to give the worker agents enough time to actually start waiting.
      
      test/built-ins/Atomics/wake/wake-in-order.js:
      - Removed the outer loop `attempt < 10` because it uses `$262.agent` in a way currently not required to work. And which actually also doesn't work in SpiderMonkey's implementation of `$262.agent`.
      - According to INTERPRETING.md `$262.agent.broadcast()` broadcasts its message to all agents ever started by `$262.agent.start()` and then blocks until all agents received the broadcast. It is not required that the agents started by the first `$262.agent.broadcast()` call will all be disabled/destroyed/whatever when the second `$262.agent.broadcast()` call occurs, which then means the second `$262.agent.broadcast()` call still tries to reach the agents started in the first loop iteration, but these may no longer accept broadcasts and therefore won't acknowledge they've received the broadcast. Which then means the second `$262.agent.broadcast()` call waits forever.
      8bc4e38a
  10. May 12, 2018
  11. May 09, 2018
  12. Jan 05, 2018
    • Mike Pennisi's avatar
      e6d674ef
    • Mike Pennisi's avatar
      Rename negative test "phase" for parsing · 13611037
      Mike Pennisi authored
      Early errors may result from parsing the source text of a test file, but
      they may also result from parsing some other source text as referenced
      through the ES2015 module syntax. The latter form of early error is not
      necessarily detectable by ECMAScript parsers, however. Because of this,
      the label "early" is not sufficiently precise for all Test262 consumers
      to correctly interpret all tests.
      
      Update the "phase" name of "early" to "parse" for all those negative
      tests that describe errors resulting from parsing of the file's source
      text directly. A forthcoming commit will update the remaining tests to
      use a "phase" name that is more specific to module resolution.
      13611037
    • Adrian Heine's avatar
      Fix typo · 60ecff7c
      Adrian Heine authored
      60ecff7c
  13. Dec 21, 2017
  14. Dec 10, 2017
  15. Dec 03, 2017
  16. Oct 21, 2017
  17. Oct 17, 2017
  18. Oct 12, 2017
  19. Oct 04, 2017
  20. Jun 28, 2017
  21. Jun 12, 2017
    • Rick Waldron's avatar
    • jugglinmike's avatar
      Lint test `features` tag (#1060) · 66bd632b
      jugglinmike authored
      A recent commit introduced a document that enumerated acceptable values
      for the test "features" metadata tag. However, this list was incomplete,
      and maintaining it placed extra burden on the project owners.
      
      Restructure the document into a machine-readable format. Add entries for
      all previously-omitted values. Add in-line documentation with
      recommendations for maintenance of the file. Extend the project's
      linting tool to validate tests according to the document's contents.
      66bd632b
  22. May 01, 2017
  23. Apr 14, 2017
  24. Apr 10, 2017
    • jugglinmike's avatar
      Automate deployment (#546) · bcb76515
      jugglinmike authored
      Introduce configuration to allow build servers provided by the Travis CI
      service to execute the test generation tool and commit the resultant
      files to the canonical upstream repository.
      
      Enabling this workflow required additional administrative work:
      
      1. Create an account with TravisCI
      2. Install the `travis` command-line utility
      3. Create a "deploy key" and an encrypted version using the command
         `./make.py github_deploy_key_enc`
      4. Register the deploy key with the project's GitHub account
      5. Check the encrypted deploy key to the repository
      6. Configure the TravisCI service to automatically build this project
      bcb76515
  25. Mar 06, 2017
  26. Oct 19, 2016
    • Mike Pennisi's avatar
      Remove "NotEarlyError" object · ade6d2e3
      Mike Pennisi authored
      Because expectations regarding error "phase" are now expressed via test
      meta-data, the test runner may now enforce this requirement on negative
      tests.
      
      Remove the "NotEarlyError" from the project source. This reduces the
      amount of domain knowledge required to author tests and lessens the
      potential for inconsistencies between tests.
      ade6d2e3
    • Mike Pennisi's avatar
      Update documentation · 0d4a07ba
      Mike Pennisi authored
      0d4a07ba
  27. Sep 27, 2016
Loading