Skip to content
Snippets Groups Projects

Erasing functionality first prototype

Merged Momo Langenstein requested to merge erasing into master
All threads resolved!

This is a very simple implementation of the erasing functionality as originally specified in our team agreement - I have gathered improved ideas from that implementation but it is still good as a proof of concept.

As we can only erase erase points that were drawn, the quality of erasing depends on the number of points drawn initially (i.e. the speed at which they were drawn).

Lastly, we are reaching the WebRTC message limits (need to investigate that further later) because of the ridiculous message overhead from yjs (as the library is far too general than what we need) - therefore, if you draw and delete too much, new clients won't be able to sync as the state cannot be fit in a single message.

@gc4117 @mnr17 @im2517 Please have a look and review

@mnr17 Please merge this merge request before !25 (merged) as there was a lot of restructuring of the drawing code

Edited by Momo Langenstein

Merge request reports

Pipeline #101434 passed

Pipeline passed for 9ca38327 on erasing

Approval is optional

Merged by  Iurii  Maksymets Iurii Maksymets 5 years ago (Oct 16, 2019 1:12pm UTC)

Merge details

  • Changes merged into master with 9ca38327.
  • Deleted the source branch.

Pipeline #101489 passed

Pipeline passed for 9ca38327 on master

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Iurii Maksymets resolved all threads

    resolved all threads

  • Please register or sign in to reply
    Loading