Skip to content
Snippets Groups Projects
  1. Nov 20, 2018
    • Rick Waldron's avatar
      Introduce $262.agent.safeBroadcast and migrate Atomics tests. · e4883091
      Rick Waldron authored
      Migrating all tests to this API is necessary to prevent tests from hanging indefinitely when a SAB is sent to a worker but the code in the worker attempts to create a non-sharable TypedArray (something that is not Int32Array or BigInt64Array). When that scenario occurs, an exception is thrown and the agent worker can no longer communicate with any other threads that control the SAB. If the main thread happens to be spinning in the $262.agent.waitUntil() while loop, it will never meet its termination condition and the test will hang indefinitely.
      
      Because we've defined $262.agent.broadcast(SAB) in https://github.com/tc39/test262/blob/master/INTERPRETING.md, there are host implementations that assume compatibility, which must be maintained.
      e4883091
  2. Oct 26, 2018
  3. Oct 23, 2018
  4. Aug 19, 2018
    • André Bargull's avatar
      Remove requirement that ToNumber(value) completes in less than $262.agent.MAX_TIME_EPSILON · d7d154b3
      André Bargull authored
      $262.agent.MAX_TIME_EPSILON was intended to be used for callers like `Atomics.wait(typedArray, indexNumber, valueNumber, timeoutNumber)` where all parameters with the `Number` suffix denote values which are already Number values. It should not be used for `Atomics.wait(typedArray, indexObject, valueObject, timeoutObject)` where all parameters with the `Object` suffix denote values which are Object values, because in that case we'd require that `ToNumber(objectValue)` (potentially invoked multiple times) completes in less than 100 milliseconds (the default value for MAX_TIME_EPSILON).
      
      Also removes $262.agent.MAX_TIME_EPSILON because it is now no longer used.
      d7d154b3
  5. Aug 17, 2018
  6. Aug 07, 2018
  7. Jul 26, 2018
  8. Jul 24, 2018
  9. Jul 03, 2018
    • André Bargull's avatar
      Make Atomics tests more resilient against intermittent failures (#1617) · 8bc4e38a
      André Bargull authored
      Also fixes multiple issues and bugs in various Atomics tests.
      
      CONTRIBUTING.md and INTERPRETING.md:
      - Add missing description for `CanBlockIsFalse` flag and also introduce `CanBlockIsTrue` flag which is needed for some tests (see below).
      
      harness/atomicsHelper.js:
      - Updated `$262.agent.waitUntil` to clarify it can also be called with BigInt64Array objects.
      - Added `$262.agent.timeouts` constants to unify the various, inconsistently used timeouts in the Atomics tests. Each timeout constant has a brief description and a usage example to clarify when it should or should not be used. The default values were tested in SpiderMonkey (locally and CI) under various system load levels and should hopefully also be valid for other engines. 
      - Added `$262.agent.tryYield` to yield control from the main thread. The default implementation simply calls `$262.agent.sleep`, but test262 hosts could theoretically provide a different implementation.
      - Added `$262.agent.trySleep` to replace direct calls to `$262.agent.sleep` from the main thread. Motivation for this function: Some test262 hosts (like browsers) may be able to pause and sleep on the main thread, so they could provide their implementation for `trySleep` which performs a busy-wait or something do nothing.
      
      harness/testAtomics.js:
      - Replace `let`, `arrow-functions`, and `for-of` loops to avoid creating extremely long `features` lists in tests using this helper. Removed `Map`, `WeakMap`, `Set`, and `WeakSet` (these weren't even listed in features.yaml) for the same reason and added the missing `Symbol` entry for this file to features.yaml.
      - Updated all files including "harness/testAtomics.js" to match the new feature requirements.
      
      
      test/built-ins/Atomics/store/good-views.js and test/built-ins/Atomics/store/bigint/good-views.js:
      - Replace `arrow-functions` and `for-of` loops with ES5 alternatives.
      
      
      test/built-ins/Atomics/wait/bigint/*.js and test/built-ins/Atomics/wake/bigint/*.js
      - Some tests were using `BigInt64Array.BYTES_PER_ELEMENT * 8` for the SharedArrayBuffer length, but their non-BigInt counterparts are using `Int32Array.BYTES_PER_ELEMENT * 4`. For consistency and to make it easier to compare the BigInt against the non-BigInt versions, I've changed it to `BigInt64Array.BYTES_PER_ELEMENT * 4`.
      - Also aligned formatting and statement placement when they differed between the non-BigInt and the BigInt version of a test file. (I've diffed some of the non-BigInt and BigInt files against each other and different formatting was a nuisance.)
      
      Test files using `$262.agent.monotonicNow()`:
      - Moved `$262.agent.report()` calls outside of the block of code measured `$262.agent.monotonicNow()` to avoid measuring how long it takes to execute `$262.agent.report()`. 
      - Without this change some tests failed intermittently in certain test configurations in SpiderMonkey. For example with the flags `--ion-eager -- ion-offthread-compile=off` which forces early Ion compilation on the main thread. The `$262.agent.report()` implementation in the SpiderMonkey test262 host embedding uses a for-loop which was forcefully Ion compiled under these settings. And because Ion compilation can take some time, the test case ran longer than `$262.agent.MAX_TIME_EPSILON` which lead to intermittent failures.
      
      Test files using `CanBlockIsFalse` / `CanBlockIsTrue`:
      - Some of these tests actually expected that the main thread can wait and [[CanBlock]] is `true` for the agent record executing the test. Therefore I've added a new `CanBlockIsTrue` flag and replaced the flags where needed.
      
      test/built-ins/Atomics/wait/**/*.js and test/built-ins/Atomics/wake/**/*.js:
      - Use an atomic counter `RUNNING` in more tests to have better control when a worker agent was actually started.
      - Replace the various `$262.agent.sleep(/* Sleep X ms to ensure worker actually sleeps */)` calls with the new `$262.agent.tryYield()` function. This `X` was sometimes as low as 10 milliseconds, which is definitely too short for CI systems under heavy load (observed by intermittent CI failures for SpiderMonkey) and sometimes as high as 500 milliseconds, which is probably much longer than needed even when the system is under heavy load. 
      - Removed duplicate strings in assertion messages, presumably from copy-pasting the messages between different files.
      - Removed extra empty lines at the end of multiple files.
      
      test/built-ins/Atomics/wake/bad-range.js, test/built-ins/Atomics/wake/bigint/bad-range.js, and test/built-ins/Atomics/wait/bigint/non-bigint64-typedarray-throws.js:
      - Removed unnecessary `features` and `includes` from this file.
      
      test/built-ins/Atomics/wait/waiterlist-order-of-operations-is-fifo.js and test/built-ins/Atomics/wait/bigint/waiterlist-order-of-operations-is-fifo.js:
      - The test was actually broken and didn't test what it said it does. This probably explains #1530.
      - The test wants to ensure the waiterlist is implemented as a FIFO structure. This requires that the waiting agents all wait on the same index position, because the waiterlists are defined by each index. But if the agents wait on different indices, each agent is inserted into a different FIFO structure and therefore we can't observe any FIFO ordering between the agents when they're woken up.
      - All this requires a bit of synchronization between the main agent and the waiting agent, I hope the added comments help to review these changes.
      
      test/built-ins/Atomics/wait/good-views.js:
      - The agent sends multiple reports to the main agent, but only the first one was read.
      - This error was introduced during previous refactorings. I've changed it to back to use a while-loop as used in the first version of this file.
      
      test/built-ins/Atomics/wait/no-spurious-wakeup-no-operation.js:
      - Only the BigInt version of this test was present, copied it so we also get code coverage for the non-BigInt case.
      
      test/built-ins/Atomics/wait/waiterlist-block-indexedposition-wake.js:
      - Added extra while loops to avoid intermittent failures when the agent worker haven't started to wait.
      - This should help to avoid some of the intermittent failures we saw for SpiderMonkey.
      
      test/built-ins/Atomics/wake/wake-all-on-loc.js and test/built-ins/Atomics/wake/bigint/wake-all-on-loc.js:
      - This test was also no longer after previous refactoring sessions.
      - The "B" agent only waited for 10 milliseconds, which made it likely that it already timed out before the main agent was able to call `Atomics.wake`, which in turn rendered the test useless, because the test case wants to ensure that `Atomics.wake` cannot wake "B". But if "B" was already timed out, it can trivially not be woken by `Atomics.wake`.
      - Added some safety measure to catch the case when "B" timed out before `Atomics.wake` was called and made it a test error if that happens.
      
      test/built-ins/Atomics/wake/count-defaults-to-infinity-missing.js, test/built-ins/Atomics/wake/count-defaults-to-infinity-undefined.js, and test/built-ins/Atomics/wake/undefined-index-defaults-to-zero.js:
      - Changed the `$262.agent.start()` calls to use a for-loop to avoid code duplication.
      - (Forgot to undo the code formatting around `assert.sameValue`, still need to change it back.)
      - Also more while-loops around `Atomics.wake`.
      - These changes should fix #1529 and #1566.
      
      test/built-ins/Atomics/wake/wake-all.js:
      - Removed "B" worker agent.
      - Without this removal the test case would be exactly equal to test/built-ins/Atomics/wake/wake-all-on-loc.js.
      
      test/built-ins/Atomics/wake/wake-in-order-one-time.js:
      - Add for-loops to avoid code duplication and make the test more readable.
      - Make the `Atomics.wake` assertion messages unique by adding the current loop counter.
      - Add `$262.agent.tryYield()` to give the worker agents enough time to actually start waiting.
      
      test/built-ins/Atomics/wake/wake-in-order.js:
      - Removed the outer loop `attempt < 10` because it uses `$262.agent` in a way currently not required to work. And which actually also doesn't work in SpiderMonkey's implementation of `$262.agent`.
      - According to INTERPRETING.md `$262.agent.broadcast()` broadcasts its message to all agents ever started by `$262.agent.start()` and then blocks until all agents received the broadcast. It is not required that the agents started by the first `$262.agent.broadcast()` call will all be disabled/destroyed/whatever when the second `$262.agent.broadcast()` call occurs, which then means the second `$262.agent.broadcast()` call still tries to reach the agents started in the first loop iteration, but these may no longer accept broadcasts and therefore won't acknowledge they've received the broadcast. Which then means the second `$262.agent.broadcast()` call waits forever.
      8bc4e38a
  10. Jun 27, 2018
  11. Jun 26, 2018
  12. Jun 25, 2018
  13. Jun 22, 2018
  14. Jun 04, 2018
  15. May 20, 2018
    • Mike Pennisi's avatar
      Formalize asynchronous failure conditions · 51bbcf59
      Mike Pennisi authored
      Previously, the error message generated by failed asynchronous tests was
      generic and underspecified. Improve the format and explicitly document
      it in project's interpreting guidelines.
      51bbcf59
  16. May 18, 2018
  17. May 03, 2018
  18. Apr 19, 2018
  19. Mar 23, 2018
  20. Mar 22, 2018
  21. Mar 18, 2018
  22. Mar 13, 2018
  23. Mar 08, 2018
  24. Mar 07, 2018
  25. Feb 27, 2018
    • Rick Waldron's avatar
    • Leo Balter's avatar
      Fix errors recently introduced. (#1448) · 27128070
      Leo Balter authored
      * Fix bad references on tests for BigInt TypedArrays
      
      * Remove bad conversions for BigInt TypedArray
      
      * Cleanup the BigInt TypedArray harness file
      
      Remove non used code (testBigIntTypedArrayConversions)
      
      Move the constructors list to inside the exposed function, this prevents early implementations to fail before the function is called.
      
      * Fix bad references in TypedArrays.of (BigInt)
      
      * Remove BigInt tests from typedarray harness test
      
      * Use BigInt for BigInt typedArrays
      
      * Apply last fixings on BigInt TypedArray tests
      
      * Apply fixes to last revision from @anba
      Unverified
      27128070
  26. Feb 15, 2018
    • Leo Balter's avatar
      Last cases of convertToBigInt · c6cd5359
      Leo Balter authored
      c6cd5359
    • Leo Balter's avatar
      Remove N() · 098c6954
      Leo Balter authored
      098c6954
    • Leo Balter's avatar
      whitespace · 3f3f2faa
      Leo Balter authored
      3f3f2faa
    • Leo Balter's avatar
      Restore original tests for TypedArrays and optimize files · c1bc43b1
      Leo Balter authored
      - optimize file names
      - BigInt folder for TAs.from and of
      - copy tests preparing for bigint
      - copy ta prototype methods for bigint
      - Use an exclusive harness for bigint typedarrays
      - add features
      - use proper harness
      - use preper harness
      - Restore original tests for TypedArrays
      - final fixes
      - fix includes
      c1bc43b1
    • Robin Templeton's avatar
      BigInt TypedArray tests · 9232d65b
      Robin Templeton authored
      - add @jakobkummerow's changes
      - remove EOL whitespace
      - use 'Array.isArray' instead of 'instanceof Array'
      - check for BigInt type in toLocaleString tests
      - specify TypedArray constructor list for non-BigInt tests
      - update TypedArray harness test for BigInt
      - add a missing type coercion
      - disable more tests for Big(U)Int64Array
      - check for BigInt before using BigInt TypedArray constructors
      9232d65b
Loading